From nobody Wed Nov 12 03:45:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1567581497; cv=none; d=zoho.com; s=zohoarc; b=FG86n2WlNfghs31qu/0To5rVorL+Wl29yskHvJ/TXZun7iwz/HTL2oYQ1NwZGces8gc9MbuZomIsb8C29j1gY0ohr+TizVp5+3KXcp4fJM03DDxT8ZO3g+1g7eO8DGwo2V2wQNWWRXuhKRSfTBL2fVStI02mBxCQrYOjQ/7bPR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567581497; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=o4RlWdYtxqMlHbFVT9ZZ9VE8q8VzUqoXL6uIpokTRqM=; b=m6C5YmCRaon01UYA6veImBwqZLptLVOJ14Rm9xcvy8Yz3khKIdKTN/cGCgFnylonLvCdbG1XZvV4MUjPCTJi1a97grCh8tkXIqSwJpAtu2fccxVboKRVJjcyKb3HRU6CmUEyIlDMSbIyBvlYR9kmusID6LpU8lvnBLN1JQjuBh4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567581497813815.7994027862876; Wed, 4 Sep 2019 00:18:17 -0700 (PDT) Received: from localhost ([::1]:54094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5PYW-0003ip-Lp for importer@patchew.org; Wed, 04 Sep 2019 03:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47947) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5PN0-0002Dj-5a for qemu-devel@nongnu.org; Wed, 04 Sep 2019 03:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5PMz-0006hi-2j for qemu-devel@nongnu.org; Wed, 04 Sep 2019 03:06:22 -0400 Received: from 3.mo6.mail-out.ovh.net ([178.33.253.26]:42714) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5PMy-0006gq-TI for qemu-devel@nongnu.org; Wed, 04 Sep 2019 03:06:21 -0400 Received: from player690.ha.ovh.net (unknown [10.109.160.62]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 0EB201DF202 for ; Wed, 4 Sep 2019 09:06:19 +0200 (CEST) Received: from kaod.org (lfbn-1-2240-157.w90-76.abo.wanadoo.fr [90.76.60.157]) (Authenticated sender: clg@kaod.org) by player690.ha.ovh.net (Postfix) with ESMTPSA id 563E094DCB0A; Wed, 4 Sep 2019 07:06:11 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: Peter Maydell Date: Wed, 4 Sep 2019 09:05:04 +0200 Message-Id: <20190904070506.1052-9-clg@kaod.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190904070506.1052-1-clg@kaod.org> References: <20190904070506.1052-1-clg@kaod.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 7091480566931950353 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudejgedgudduudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 178.33.253.26 Subject: [Qemu-devel] [PATCH 08/10] aspeed/smc: Calculate checksum on normal DMA X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Svensson , Andrew Jeffery , qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Joel Stanley Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Christian Svensson This patch adds the missing checksum calculation on normal DMA transfer. According to the datasheet this is how the SMC should behave. Verified on AST1250 that the hardware matches the behaviour. Signed-off-by: Christian Svensson Reviewed-by: Joel Stanley Signed-off-by: C=C3=A9dric Le Goater --- hw/ssi/aspeed_smc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 5c3436db5e8f..9ffc7e01179a 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -989,6 +989,7 @@ static void aspeed_smc_dma_rw(AspeedSMCState *s) s->regs[R_DMA_FLASH_ADDR] +=3D 4; s->regs[R_DMA_DRAM_ADDR] +=3D 4; s->regs[R_DMA_LEN] -=3D 4; + s->regs[R_DMA_CHECKSUM] +=3D data; } } =20 --=20 2.21.0