From nobody Fri Dec 19 15:56:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1567526105; cv=none; d=zoho.com; s=zohoarc; b=RNH6FzG5M6fh8UidMRe2hfx9eTvSCcfDdPnPywa0+v80hs1+Qwm/ceVuE9NMGpr1eaCi2haBVb/SI8CpnIMLINPVGkRYKfuJ7Rss/wpAxoLs2H44Fe+VIVkwWwEz8mxoEktchULdq9oR+nWFprSB4CAD7W6X2FQRzZCjdvQxqhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567526105; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=PQwumxLD0naoGLveJArJ+0uz+trgPMLG7ByeUUTiw3c=; b=X7APhx+pPVa6oDVC5AbDoKfvef9+9yDeodSf8wTfQ7oqR/11nqQPGS8PfPvrSjPwxWBu99IjqJoMJ1cnyf1yHZnBfozofj6pjaJPO/17DUOkEtTYyo88f6uLNMuWJQ8847Joq7+SgnQcm+Gg/2xccHPFrfTRx9Gzd94q9ynbS1E= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567526105531801.5497428278929; Tue, 3 Sep 2019 08:55:05 -0700 (PDT) Received: from localhost ([::1]:47942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5B95-0003pP-B2 for importer@patchew.org; Tue, 03 Sep 2019 11:55:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59374) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5Arc-00038d-J2 for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5Arb-00065G-Kz for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:37:00 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:40774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5Arb-00064Z-EF for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:36:59 -0400 Received: by mail-wr1-x444.google.com with SMTP id c3so17988349wrd.7 for ; Tue, 03 Sep 2019 08:36:59 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a18sm24435188wrt.18.2019.09.03.08.36.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 08:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=PQwumxLD0naoGLveJArJ+0uz+trgPMLG7ByeUUTiw3c=; b=hqVt7v0A+RHc8yPlc+/akWP8XDgvXvaCpwmsl8C06sRocrkdWgnZ4fsB2UBzgf5FeW baJvJHoeqRruO5xRJvCqaz+xq+JxV8G2WMV9sumfMKCmU3HQ4m7eLPgFn66J2AWNH3qk L/i4g+q3XJgETBgyjmZ/2vV4GchANz4g6gBUUJzIGKACnJWUpmLdF0KwmyH3lPMknZMO R1ztMvOYpqxx6GyhY3pBySM6mKd3JvVut5axbzgkHbhaGdOQWHzCTvyqpQKtgs5dENXo KaKQq/jk9fZgfyi0VPw+nb7OCqJZxwDDOlDkePssbaonwHo2wv2gNRVpVnlsVGdhw/gD ftGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PQwumxLD0naoGLveJArJ+0uz+trgPMLG7ByeUUTiw3c=; b=eZStrrTHJ6wH9HtqS0wZ4dbiBYsEznAgqPYyAMNy8ikcZKUuBqrFQymJv771c+RLw7 DsPZQHk7AeTyrl1IMdqKT15EZbtuVVFPpe/aqeXUivVLGMbB48ksgUPIH5DPm7EGRGBe +CswelAycBjR5PASXSsGYRXNnzgFghjHWZJx0hUXvcIJ/qE2IfyrcdJgBYDXbKfo+eua EdzQ3ho3hlmd0UO/+j5I4OJbslX+9fBqzHab1bKF0S4Wcjqu1UWbzcMF0/Q+HH6q8ayP OI4wx2VpGZyrdQOMlfAm6+/PLiZgD1cOb8xu31SiJP/0Aox5hv7D3CKliUfijyqJiY1n cC/w== X-Gm-Message-State: APjAAAVtGyHaLZnhvkiq+gkrHAJl1+waBCU0GEVKcqI90CvGgq4Momtf tN6lVngm+nWH3sQbxwuPsCltILcGNL+Jmg== X-Google-Smtp-Source: APXvYqxb6VFRSxmBw5yM1EvaeAJ4KQfy4lw+UlWyHv58aLXC6tn5xi88QV1KsbWpYZu8SFGnbvRkkw== X-Received: by 2002:a5d:6ac8:: with SMTP id u8mr7733455wrw.104.1567525018262; Tue, 03 Sep 2019 08:36:58 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 3 Sep 2019 16:36:32 +0100 Message-Id: <20190903153633.6651-21-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190903153633.6651-1-peter.maydell@linaro.org> References: <20190903153633.6651-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PULL 20/21] target/arm: Free TCG temps in trans_VMOV_64_sp() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The function neon_store_reg32() doesn't free the TCG temp that it is passed, so the caller must do that. We got this right in most places but forgot to free the TCG temps in trans_VMOV_64_sp(). Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20190827121931.26836-1-peter.maydell@linaro.org --- target/arm/translate-vfp.inc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index 3e8ea80493b..9ae980bef63 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -880,8 +880,10 @@ static bool trans_VMOV_64_sp(DisasContext *s, arg_VMOV= _64_sp *a) /* gpreg to fpreg */ tmp =3D load_reg(s, a->rt); neon_store_reg32(tmp, a->vm); + tcg_temp_free_i32(tmp); tmp =3D load_reg(s, a->rt2); neon_store_reg32(tmp, a->vm + 1); + tcg_temp_free_i32(tmp); } =20 return true; --=20 2.20.1