From nobody Wed Nov 12 02:02:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567491682; cv=none; d=zoho.com; s=zohoarc; b=QfAN8ZymBH0QinA66v3qb724xXUUXLn1PZec33dpXEUnhXqOubVdT6CCXTNvdaLT4K8nGdnq77Niam+88XZpiNB0ihLp5cfjfe/Ei4NUPp9PmWmSKVmL2YML0+mybTHlnXx1fOsmFT/XFqyXAiGXckZX2ttGD3DohLRCtrZfKeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567491682; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Y5KgInPmGQJDlNm+xUwQxts6V6ptZjIFRCQBs4FWxnk=; b=FQ0/vth1CB073UY1mK7l7NfcDsKtMitLxOfTkukVqo8op681Hjq6r2vu0OyYeyLZMN4WswQkpZv83aAzdLprxp+MY+kvoGoiMic5Es2cMeFZi5zmcQYu7GB9o3gk/hiZ1Rd9q0xDv9gReAW/LcBsqwTdG857MFSSlHlnHVgOEPU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567491682672943.5128952051425; Mon, 2 Sep 2019 23:21:22 -0700 (PDT) Received: from localhost ([::1]:41960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i52Bp-0000NW-UR for importer@patchew.org; Tue, 03 Sep 2019 02:21:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57001) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i529e-0007BH-Es for qemu-devel@nongnu.org; Tue, 03 Sep 2019 02:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i529d-0003Xl-Ek for qemu-devel@nongnu.org; Tue, 03 Sep 2019 02:19:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47922) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i529d-0003XG-9b for qemu-devel@nongnu.org; Tue, 03 Sep 2019 02:19:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24FBC307CDFC for ; Tue, 3 Sep 2019 06:19:00 +0000 (UTC) Received: from thuth.com (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59B53600C6; Tue, 3 Sep 2019 06:18:58 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Tue, 3 Sep 2019 08:18:44 +0200 Message-Id: <20190903061849.21493-2-thuth@redhat.com> In-Reply-To: <20190903061849.21493-1-thuth@redhat.com> References: <20190903061849.21493-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 03 Sep 2019 06:19:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/6] tests/migration: Do not use functions anymore that rely on global_qtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The migration tests deal with multiple test states, so we really should not use functions here that rely on the single global_qtest variable. Switch from qtest_start() to qtest_init() to make sure that global_qtest is not set anymore. This also revealed a regression in the migrate() function: It has once been converted to use the qtest_qmp() function, but commit b5bbd3f315d686bd511 ("Clean up string interpolation into QMP, part 2") accidentally reverted it back to qmp(). Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Thomas Huth Reviewed-by: Laurent Vivier --- tests/migration-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index b87ba99a9e..a9f81cc185 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -490,7 +490,7 @@ static void migrate(QTestState *who, const char *uri, c= onst char *fmt, ...) g_assert(!qdict_haskey(args, "uri")); qdict_put_str(args, "uri", uri); =20 - rsp =3D qmp("{ 'execute': 'migrate', 'arguments': %p}", args); + rsp =3D qtest_qmp(who, "{ 'execute': 'migrate', 'arguments': %p}", arg= s); =20 g_assert(qdict_haskey(rsp, "return")); qobject_unref(rsp); @@ -625,7 +625,7 @@ static int test_migrate_start(QTestState **from, QTestS= tate **to, cmd_dst =3D tmp; } =20 - *from =3D qtest_start(cmd_src); + *from =3D qtest_init(cmd_src); g_free(cmd_src); =20 *to =3D qtest_init(cmd_dst); @@ -715,7 +715,7 @@ static void test_deprecated(void) { QTestState *from; =20 - from =3D qtest_start("-machine none"); + from =3D qtest_init("-machine none"); =20 deprecated_set_downtime(from, 0.12345); deprecated_set_speed(from, 12345); --=20 2.18.1