From nobody Wed Nov 12 00:11:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bt.com ARC-Seal: i=1; a=rsa-sha256; t=1567388177; cv=none; d=zoho.com; s=zohoarc; b=DO1SJl5Aj+4vbZuBwmdyvi7FMrhWYgp6HjeprvI7NcwzBszw0zWFq/3eUBe96xxv0YVKHYPZfq3zMmZMFumIMDxG/epkW2jM0LXxnNKdJyAgXjUUCKQ6ly08RNjUUL6iw/7ze3MV0Ftgo4yNzUNxj9uG0Lh1j7phRVd2GQNgXRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567388177; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=HA080lAyYCX6CjOYTZV+Dhb0eVZqi9SGiFbBF0bnZ7c=; b=YncbGYE6pEVxq8X6bLH2Hb3jiznZ1uH7F7Ic1+TsZizmVRAcBN9HvvaJRJggw8CfP7+65kODobZBQBOekh3DTvkt0ISyZywU0W5wJ4I5zYPGqJtMyFWRNFGOmHr1MJNmuNmHLs93x5YmhMLsARkGMAVwH7N5GaMMfFpqb+fVJl4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567388177041762.5161326040687; Sun, 1 Sep 2019 18:36:17 -0700 (PDT) Received: from localhost ([::1]:60942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4bGN-0000E4-ND for importer@patchew.org; Sun, 01 Sep 2019 21:36:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36359) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4bEy-00086s-GM for qemu-devel@nongnu.org; Sun, 01 Sep 2019 21:34:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4bEx-0000Nn-HY for qemu-devel@nongnu.org; Sun, 01 Sep 2019 21:34:44 -0400 Received: from nsstlmta05p.bpe.bigpond.com ([203.38.21.5]:55498) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4bEw-0000KS-UW for qemu-devel@nongnu.org; Sun, 01 Sep 2019 21:34:43 -0400 Received: from smtp.telstra.com ([10.10.24.4]) by nsstlfep21p-svc.bpe.nexus.telstra.com.au with ESMTP id <20190902012254.LWWZ15045.nsstlfep21p-svc.bpe.nexus.telstra.com.au@smtp.telstra.com>; Mon, 2 Sep 2019 11:22:54 +1000 Received: from dbz.telstra.com.au (58.173.98.68) by smtp.telstra.com (5.8.335) (authenticated as tony.nguyen.git@bigpond.com) id 5D358144105D0F56; Mon, 2 Sep 2019 11:22:54 +1000 X-RG-Spam: Unknown X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduvddrudeiledggeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuuffpveftpgfvgffnuffvtfetpdfqfgfvnecuuegrihhlohhuthemucegtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhonhihucfpghhuhigvnhcuoehtohhnhidrnhhguhihvghnsegsthdrtghomheqnecukfhppeehkedrudejfedrleekrdeikeenucfrrghrrghmpehhvghlohepuggsiidrthgvlhhsthhrrgdrtghomhdrrghupdhinhgvthepheekrddujeefrdelkedrieekpdhmrghilhhfrhhomhepoehtohhnhidrnhhguhihvghnsegsthdrtghomheqpdhrtghpthhtohepoehpsghonhiiihhnihesrhgvughhrghtrdgtohhmqedprhgtphhtthhopeeoqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrgheqpdhrtghpthhtohepoehrthhhsehtfihiuggulhgvrdhnvghtqedprhgtphhtthhopeeothhonhihrdhnghhuhigvnhessghtrdgtohhmqeenucevlhhushhtvghrufhiiigvpedt X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean X-RG-VS-CLASS: clean X-Authentication-Info: Submitted using ID tony.nguyen.git@bigpond.com From: Tony Nguyen To: qemu-devel@nongnu.org Date: Mon, 2 Sep 2019 11:26:47 +1000 Message-Id: <20190902012647.1761-1-tony.nguyen@bt.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 203.38.21.5 Subject: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Nguyen , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Existing read rejecting validator was mistakenly cleared. Reads dispatched to io_mem_notdirty then segfaults as there is no read handler. Signed-off-by: Tony Nguyen Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 1df966d17a..05d664541f 100644 --- a/exec.c +++ b/exec.c @@ -2796,12 +2796,12 @@ static bool notdirty_mem_accepts(void *opaque, hwad= dr addr, =20 static const MemoryRegionOps notdirty_mem_ops =3D { .write =3D notdirty_mem_write, - .valid.accepts =3D notdirty_mem_accepts, .endianness =3D DEVICE_NATIVE_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 8, .unaligned =3D false, + .accepts =3D notdirty_mem_accepts, }, .impl =3D { .min_access_size =3D 1, --=20 2.23.0