From nobody Sun May 5 16:54:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567069457; cv=none; d=zoho.com; s=zohoarc; b=nmzZ9ufDD06bprWEJ80B4enFLQ9Hvdm38WISHD/OLgwyZlgC+YMVRRVLU1wFh5hAEo4HGs22DEhSy+u5KJI2THriCa6bSgyijs0z4ih7xo/VkwvBLQhIniZj2+c0m++zRqATJ+9MLc2oRToxhufwAN1UB8aP+jvjDNVTHDUNJIE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567069457; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=SZTRuEGNKbxalB/SilabisIHYFKrXD61B8uh9s3yebE=; b=K5ci0pyK5KxfP2emH9cfsgBC8jbBFp2l613eWmUQreyj7EvKnnTV8WLjpg6ZU1r0s4qEtjGv7ywC8IajVSmfepo4wFliNzsUDDvcU0gPDalvOFsUvsi7GMAkD4Z+QQEuoqv2QBwA0NrrRC3schVtbhx0opY9/8nNCcvpvxbZYHI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567069457142553.7835935110146; Thu, 29 Aug 2019 02:04:17 -0700 (PDT) Received: from localhost ([::1]:47060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3GLk-0003d6-7n for importer@patchew.org; Thu, 29 Aug 2019 05:04:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33185) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3GJd-0001ra-18 for qemu-devel@nongnu.org; Thu, 29 Aug 2019 05:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3GJb-00011H-Nt for qemu-devel@nongnu.org; Thu, 29 Aug 2019 05:02:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47510) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i3GJZ-0000xx-13; Thu, 29 Aug 2019 05:01:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4ED8186E86F; Thu, 29 Aug 2019 09:01:56 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-105.ams2.redhat.com [10.36.116.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2505D1001938; Thu, 29 Aug 2019 09:01:53 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, alex.williamson@redhat.com Date: Thu, 29 Aug 2019 11:01:40 +0200 Message-Id: <20190829090141.21821-2-eric.auger@redhat.com> In-Reply-To: <20190829090141.21821-1-eric.auger@redhat.com> References: <20190829090141.21821-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 29 Aug 2019 09:01:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 1/2] memory: Add IOMMU_ATTR_NEED_HW_NESTED_PAGING IOMMU memory region attribute X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, peterx@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We introduce a new IOMMU Memory Region attribute, IOMMU_ATTR_NEED_HW_NESTED_PAGING that tells whether the virtual IOMMU relies on physical IOMMU HW nested paging capability when protecting host assigned devices. Current Intel virtual IOMMU device supports "Caching Mode" and does not require 2 stages at physical level to be integrated with VFIO. However SMMUv3 does not implement such "caching mode" and requires HW nested paging. As such SMMUv3 is the first IOMMU device to advertise this attribute. This new attribute will allow the VFIO code to specialize its handling. Signed-off-by: Eric Auger --- v4 -> v5: - patches 1, 4, 5 were upstreamed separately - s/IOMMU_ATTR_HW_NESTED_PAGING/IOMMU_ATTR_NEED_HW_NESTED_PAGING v3 -> v4: - s/IOMMU_ATTR_VFIO_NESTED/IOMMU_ATTR_HW_NESTED_PAGING - add comments related to the existing attributes - fix space after the cast --- hw/arm/smmuv3.c | 12 ++++++++++++ include/exec/memory.h | 8 +++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 2eaf07fb5f..a932bf7136 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -1490,6 +1490,17 @@ static void smmuv3_notify_flag_changed(IOMMUMemoryRe= gion *iommu, } } =20 +static int smmuv3_get_attr(IOMMUMemoryRegion *iommu, + enum IOMMUMemoryRegionAttr attr, + void *data) +{ + if (attr =3D=3D IOMMU_ATTR_NEED_HW_NESTED_PAGING) { + *(bool *)data =3D true; + return 0; + } + return -EINVAL; +} + static void smmuv3_iommu_memory_region_class_init(ObjectClass *klass, void *data) { @@ -1497,6 +1508,7 @@ static void smmuv3_iommu_memory_region_class_init(Obj= ectClass *klass, =20 imrc->translate =3D smmuv3_translate; imrc->notify_flag_changed =3D smmuv3_notify_flag_changed; + imrc->get_attr =3D smmuv3_get_attr; } =20 static const TypeInfo smmuv3_type_info =3D { diff --git a/include/exec/memory.h b/include/exec/memory.h index fddc2ff48a..61493633fa 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -212,7 +212,13 @@ typedef struct MemoryRegionClass { =20 =20 enum IOMMUMemoryRegionAttr { - IOMMU_ATTR_SPAPR_TCE_FD + /* Retrieve an integer corresponding to the TCE file descriptor */ + IOMMU_ATTR_SPAPR_TCE_FD, + /* + * Retrieve a boolean that indicates whether the virtual IOMMU relies + * on physical IOMMU HW nested paging to protect host assigned devices + */ + IOMMU_ATTR_NEED_HW_NESTED_PAGING, }; =20 /** --=20 2.20.1 From nobody Sun May 5 16:54:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567069464; cv=none; d=zoho.com; s=zohoarc; b=nCBD6U7R630TcY8WNy+CiHAycIHjmyy/SrMHRsP1O/ET6HPgGGx2CyOvnfclEDg5riSkP4nYZibr/Ci49tsZwmIRdkV3KxD0Hhc+dROBvbNw9F1jS6wdcz12KU8Z0PfS1oCete6w82Clif0foa1sTcgt5c+YE7LCxBSt0Jygt4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567069464; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YVBuGdqVPEfy6yZBRFP/r4odQo3nzL2TwJuN5O5An2k=; b=K9mrxhVRC+2+LU0Kc8vLoclwRNDtaINOX1F3MAABpb01JB06ii19PAOxQ2YIU7E7qCtLNGMNMa89lHMQufUmgXBPpj6BElqPNp62c6JTqmp1LamA2gAoJTHZOf0I254h//Io4LEhR+LDkhiA2bVTJ9uF6Aiaso7+PCJ89XommWs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567069464577821.5138282817065; Thu, 29 Aug 2019 02:04:24 -0700 (PDT) Received: from localhost ([::1]:47062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3GLu-0003om-Uf for importer@patchew.org; Thu, 29 Aug 2019 05:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33232) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3GJi-0001x8-DW for qemu-devel@nongnu.org; Thu, 29 Aug 2019 05:02:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3GJh-00017P-0b for qemu-devel@nongnu.org; Thu, 29 Aug 2019 05:02:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36693) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i3GJe-00013M-0m; Thu, 29 Aug 2019 05:02:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C47F106E28D; Thu, 29 Aug 2019 09:02:01 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-105.ams2.redhat.com [10.36.116.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3A3B1001938; Thu, 29 Aug 2019 09:01:56 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, alex.williamson@redhat.com Date: Thu, 29 Aug 2019 11:01:41 +0200 Message-Id: <20190829090141.21821-3-eric.auger@redhat.com> In-Reply-To: <20190829090141.21821-1-eric.auger@redhat.com> References: <20190829090141.21821-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Thu, 29 Aug 2019 09:02:01 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 2/2] hw/vfio/common: Fail on VFIO/HW nested paging detection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, peterx@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" As of today, VFIO only works along with vIOMMU supporting caching mode. The SMMUv3 does not support this mode and requires HW nested paging to work properly with VFIO. So any attempt to run a VFIO device protected by such IOMMU would prevent the assigned device from working and at the moment the guest does not even boot as the default memory_region_iommu_replay() implementation attempts to translate the whole address space and completely stalls the guest. So let's fail on that case. Signed-off-by: Eric Auger --- v3 -> v4: - use IOMMU_ATTR_HW_NESTED_PAGING - do not abort anymore but jump to fail --- hw/vfio/common.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 3e03c495d8..e8c009d019 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -606,9 +606,19 @@ static void vfio_listener_region_add(MemoryListener *l= istener, if (memory_region_is_iommu(section->mr)) { VFIOGuestIOMMU *giommu; IOMMUMemoryRegion *iommu_mr =3D IOMMU_MEMORY_REGION(section->mr); + bool nested; int iommu_idx; =20 trace_vfio_listener_region_add_iommu(iova, end); + + if (!memory_region_iommu_get_attr(iommu_mr, + IOMMU_ATTR_NEED_HW_NESTED_PAGING, + (void *)&nested) && nested) { + error_report("VFIO/vIOMMU integration based on HW nested pagin= g " + "is not yet supported"); + ret =3D -EINVAL; + goto fail; + } /* * FIXME: For VFIO iommu types which have KVM acceleration to * avoid bouncing all map/unmaps through qemu this way, this --=20 2.20.1