From nobody Tue Feb 10 11:58:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1567023468; cv=none; d=zoho.com; s=zohoarc; b=foWDTPFxY6mJSgoKOm28DSx9elRiEiV9Invl/Ep3q130LYOJmB4LN8QQPc95HytCjGM01LKmgmll7XylchsEUgksgVAsw0dGdMc64nJjSzx+OnOWOKGqrpmqrOT6F4oY9859j1raknhz2NlVnoFqzjFT/ay8JWmHjp7s90aCNHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567023468; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=x7zkDeuRWBqPgbu0Uw/jBwIGlLUUfHJ8yMWyeY3L4GI=; b=E5CFWhGsoz+wO/957qeg1mIuF6Fqc/u1zRQLpVtZnK2YIlrlZBLRkExLdEMbMoGiPVngVJy/GSTLg1FCBEJlvTTK8Ub6Qa/cKLFsx3jzmuaxFM6OXDnDV9dlLmV7DSxGrgOCyRFqvokN3AzKBZRUDcBmkEkZgV7VZKMsN8Mg+Yg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1567023468493389.9966125252896; Wed, 28 Aug 2019 13:17:48 -0700 (PDT) Received: from localhost ([::1]:42168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i34O3-0000bL-2f for importer@patchew.org; Wed, 28 Aug 2019 16:17:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38722) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i33Gp-0003wO-7l for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i33Gn-0000ff-Dx for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:14 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:40508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i33Gm-0000bY-Gp for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:12 -0400 Received: by mail-pl1-x644.google.com with SMTP id h3so393925pls.7 for ; Wed, 28 Aug 2019 12:06:09 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id f27sm2967944pgm.60.2019.08.28.12.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 12:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x7zkDeuRWBqPgbu0Uw/jBwIGlLUUfHJ8yMWyeY3L4GI=; b=axcs5CpEI8yuoqlwGkqd94L5BMP4ASAOkiNXDU6hWnvu0S83Cg1jOCz6Muv7zNLMMj MfacYvCjljRRbZ4FM9E3NxO5haSKLTn5TleGwN1JEoaBt4t2Q0ZtWTuPNbtH03rv3A8X Fdf8VOsZ8ZxUmeX4SI3MTmHiXVy9FWXqO17a5nNO0diqdwoDBsdqC4b/W0+DO2PA8aGO 3hh3daIdiTPXjj1Voen45MBovK7++mwyjyNfQ+lIz54FyWH4mP3aYcexiW1ypfpWOKGW 5D/JHNgLCFwixKEbKRR2WTKgRTYDSIgpKs9+iCQ/QbgwO3hcakFSnOX9npr4UUGI6Pg7 AngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x7zkDeuRWBqPgbu0Uw/jBwIGlLUUfHJ8yMWyeY3L4GI=; b=RKxXSW0oeecLJvcMTGsuMtf79+RyuCwilKAG0n1C9O8qAaOhWVEb3zWYp1YoJv0taL y7KiG3RuiV4C9rAto0szl2Yz87xLLxCegTJcBmnrEvUch8ZrWItR1KQkVyuyj5+uS9tC 1P6oLJNDEO7kYXXtsfKmzBpsOCHw+NR0uMgj4ca4bfgn4qLu8f77aoaHRtGNbiEE+G8t Ciq7PwqHMql+WDVDEa9d2+eE6ea+fkxJGrDHU9CPigkW3dyRxshSzqddQlU9pymvylvc 5aRdHmuowIoT8Cj0ng7rHIANbGXcXx+TZPBDERl83nyrJYZ8Sg1ilytB9SVtnHQ6YTeJ 1XAw== X-Gm-Message-State: APjAAAW4hVHWdaBJfCV2VM0jTNJvmC4IyGcwEIq1MmtEwIRdAP4SphzY jHNTGUivSZNigspong6KO8whZNbmjvI= X-Google-Smtp-Source: APXvYqwtxB8gxq1SlavCA72/W/Fe73q0lDiX8NCMKtcsaMhX/qg6ZUZx4+yc5qEu+7RmTZ6bhvlk2w== X-Received: by 2002:a17:902:e489:: with SMTP id cj9mr5926759plb.327.1567019168623; Wed, 28 Aug 2019 12:06:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 12:04:41 -0700 Message-Id: <20190828190456.30315-55-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190828190456.30315-1-richard.henderson@linaro.org> References: <20190828190456.30315-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH v3 54/69] target/arm: Convert T16 add, compare, move (two high registers) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 49 ++---------------------------------------- target/arm/t16.decode | 10 +++++++++ 2 files changed, 12 insertions(+), 47 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index cd39329e5c..cf19f1f777 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10722,55 +10722,10 @@ static void disas_thumb_insn(DisasContext *s, uin= t32_t insn) store_reg(s, rd, tmp); break; } - if (insn & (1 << 10)) { - /* 0b0100_01xx_xxxx_xxxx - * - data processing extended, branch and exchange - */ - rd =3D (insn & 7) | ((insn >> 4) & 8); - rm =3D (insn >> 3) & 0xf; - op =3D (insn >> 8) & 3; - switch (op) { - case 0: /* add */ - tmp =3D load_reg(s, rd); - tmp2 =3D load_reg(s, rm); - tcg_gen_add_i32(tmp, tmp, tmp2); - tcg_temp_free_i32(tmp2); - if (rd =3D=3D 13) { - /* ADD SP, SP, reg */ - store_sp_checked(s, tmp); - } else { - store_reg(s, rd, tmp); - } - break; - case 1: /* cmp */ - tmp =3D load_reg(s, rd); - tmp2 =3D load_reg(s, rm); - gen_sub_CC(tmp, tmp, tmp2); - tcg_temp_free_i32(tmp2); - tcg_temp_free_i32(tmp); - break; - case 2: /* mov/cpy */ - tmp =3D load_reg(s, rm); - if (rd =3D=3D 13) { - /* MOV SP, reg */ - store_sp_checked(s, tmp); - } else { - store_reg(s, rd, tmp); - } - break; - case 3: - /* 0b0100_0111_xxxx_xxxx - * - branch [and link] exchange thumb register - * In decodetree - */ - goto illegal_op; - } - break; - } =20 /* - * 0b0100_00xx_xxxx_xxxx - * - Data-processing (two low registers), in decodetree + * - Data-processing (two low registers), in decodetree + * - data processing extended, branch and exchange, in decodetree */ goto illegal_op; =20 diff --git a/target/arm/t16.decode b/target/arm/t16.decode index edddbfb9b8..5a570484e3 100644 --- a/target/arm/t16.decode +++ b/target/arm/t16.decode @@ -146,6 +146,16 @@ CMP_xri 00101 ... ........ @arith= _1i s=3D1 ADD_rri 00110 ... ........ @arith_1i %s SUB_rri 00111 ... ........ @arith_1i %s =20 +# Add, compare, move (two high registers) + +%reg_0_7 7:1 0:3 +@addsub_2h .... .... . rm:4 ... \ + &s_rrr_shi rd=3D%reg_0_7 rn=3D%reg_0_7 shim=3D0 shty=3D0 + +ADD_rrri 0100 0100 . .... ... @addsub_2h s=3D0 +CMP_xrri 0100 0101 . .... ... @addsub_2h s=3D1 +MOV_rxri 0100 0110 . .... ... @addsub_2h s=3D0 + # Branch and exchange =20 @branchr .... .... . rm:4 ... &r --=20 2.17.1