From nobody Wed Nov 12 01:52:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566932558; cv=none; d=zoho.com; s=zohoarc; b=QkR2ioXu966oOCVzeBDK/EZxgmc/7CJN/pMDdp91LM3YFTSMAk34QdxBcIimsKTRiXPfbV6KgbEU4pZYaoUAyMAt7ncPhvkd9VZ5mHDhnYiFAHfbeRsYAjQhOs9BPgapk3Hl1R6iJiCCKFieXYs4KFe2xjKWWmLuPGbz/WW4DBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566932558; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=WHUo3Tga0CGNATwCAfQwI44kWXDmXDYMUfkHqnRgu3E=; b=TP3K9i4Prl9ums6Czrk9oh3oA36j3x8Gw6Q59JsWt9txnA1lAMg8dbSm+d9TBC8v0GHYIT+bhLE5y3NOBAHOTanAWXTor1cfiO/SV0pxMwP/fZFWMh4giQijv3yDU2sBrQhpT86i0O3j9YxW6gBrHO7pQ5T4Kn33vTAXE+x2sB4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566932558254366.6102635476683; Tue, 27 Aug 2019 12:02:38 -0700 (PDT) Received: from localhost ([::1]:56096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2gjk-0001bn-Su for importer@patchew.org; Tue, 27 Aug 2019 15:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33894) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2ggf-0008Me-QW for qemu-devel@nongnu.org; Tue, 27 Aug 2019 14:59:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2gge-0006Nx-Dt for qemu-devel@nongnu.org; Tue, 27 Aug 2019 14:59:25 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:35071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2gge-0006NX-3x; Tue, 27 Aug 2019 14:59:24 -0400 Received: by mail-wm1-x343.google.com with SMTP id l2so210042wmg.0; Tue, 27 Aug 2019 11:59:24 -0700 (PDT) Received: from localhost.localdomain (109-186-142-128.bb.netvision.net.il. [109.186.142.128]) by smtp.gmail.com with ESMTPSA id g26sm9926wmh.32.2019.08.27.11.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2019 11:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WHUo3Tga0CGNATwCAfQwI44kWXDmXDYMUfkHqnRgu3E=; b=b/YLMTPITid9bZP3cnOmIU6dozatrMb5vF2Rnzjz18yea61NNujUhqfJbs4zCjHJgN zW8qOZKm/E2bjW5ipGrRBxOC9nM0ArEClf34W9F2/06UJVk3zYWQw01CseKk1PaHYSw/ TXlfASWG4E48h7hT32o1IBunP2ioj+p/Y3YN47OK4AlnVxjU97IAhSz4+pjfNRrqDpZ2 NHH9eC99E6IfBE2V/kgUBaICVdkfp/HYYBNVhh1920FbYfyuxBd0fAqpLGNc+q7S9KvF YMy+TsP67lGCEBQrZ4h+zR+EFVeJP5N9icbNKWICY3ea0HHNAMVqdZPfAzMka9yC/bHM Qmxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WHUo3Tga0CGNATwCAfQwI44kWXDmXDYMUfkHqnRgu3E=; b=op26fAtjsmrei4liob+DCOdJiWURDHqNHHbeNwpH9MZctjhrZrb3rMh02yrUjrpUht nXQsTAXW2xxrGFMcMeTP65CmnZDpxBEdvcjZqVu+I8PN8WOy2lCive0CHdvLY98jvxIL aWkwE7ghnADNz0WQOphaUvNts1vy6gSlauMSUWsh1vvrBiAEP5Pe6DxixPxwtkFU/jZH cahL0XgRjhGizJdIAAuNlJONTiCqv86Xlm8bALbswNFCyz6anZxv2m/hnUn+XquJh+S4 jE7xDScVIfEIvS4GedeO0GmwmXc5mJ/qhYBgvuPyax66+JNLJ4Vh0WeOOzvQxOKlAm0v uu0g== X-Gm-Message-State: APjAAAXUTG5BJyJzu3uUP22LY0Ziot1/I/s5xys4AraNagSJyA77ycB7 VnOoLe/oNA+f/Jt4oyLWZuxRbB/O9DAiRw== X-Google-Smtp-Source: APXvYqwTTHq+2vwLFuj9TSBLQ1uHBO+hNP4DGmDTlIdX1MOCww1P7ZXLM2T6qwcFER+m2x7QnDVEFw== X-Received: by 2002:a1c:c018:: with SMTP id q24mr7481wmf.162.1566932359123; Tue, 27 Aug 2019 11:59:19 -0700 (PDT) From: Nir Soffer X-Google-Original-From: Nir Soffer To: qemu-devel@nongnu.org Date: Tue, 27 Aug 2019 21:59:12 +0300 Message-Id: <20190827185913.27427-2-nsoffer@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190827185913.27427-1-nsoffer@redhat.com> References: <20190827185913.27427-1-nsoffer@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v2 1/2] block: Use QEMU_IS_ALIGNED X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Max Reitz , Nir Soffer , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Replace instances of: (n & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0 And: (n & ~BDRV_SECTOR_MASK) =3D=3D 0 With: QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) Which reveals the intent of the code better, and makes it easier to locate the code checking alignment. Signed-off-by: Nir Soffer --- block/bochs.c | 4 ++-- block/cloop.c | 4 ++-- block/dmg.c | 4 ++-- block/io.c | 8 ++++---- block/qcow2-cluster.c | 4 ++-- block/qcow2.c | 4 ++-- block/vvfat.c | 8 ++++---- qemu-img.c | 2 +- 8 files changed, 19 insertions(+), 19 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 962f18592d..32bb83b268 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -248,8 +248,8 @@ bochs_co_preadv(BlockDriverState *bs, uint64_t offset, = uint64_t bytes, QEMUIOVector local_qiov; int ret; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); =20 qemu_iovec_init(&local_qiov, qiov->niov); qemu_co_mutex_lock(&s->lock); diff --git a/block/cloop.c b/block/cloop.c index 384c9735bb..4de94876d4 100644 --- a/block/cloop.c +++ b/block/cloop.c @@ -253,8 +253,8 @@ cloop_co_preadv(BlockDriverState *bs, uint64_t offset, = uint64_t bytes, int nb_sectors =3D bytes >> BDRV_SECTOR_BITS; int ret, i; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); =20 qemu_co_mutex_lock(&s->lock); =20 diff --git a/block/dmg.c b/block/dmg.c index 45f6b28f17..4a045f2b3e 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -697,8 +697,8 @@ dmg_co_preadv(BlockDriverState *bs, uint64_t offset, ui= nt64_t bytes, int nb_sectors =3D bytes >> BDRV_SECTOR_BITS; int ret, i; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); =20 qemu_co_mutex_lock(&s->lock); =20 diff --git a/block/io.c b/block/io.c index 56bbf195bb..7508703ecd 100644 --- a/block/io.c +++ b/block/io.c @@ -1080,8 +1080,8 @@ static int coroutine_fn bdrv_driver_preadv(BlockDrive= rState *bs, sector_num =3D offset >> BDRV_SECTOR_BITS; nb_sectors =3D bytes >> BDRV_SECTOR_BITS; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); assert(bytes <=3D BDRV_REQUEST_MAX_BYTES); assert(drv->bdrv_co_readv); =20 @@ -1133,8 +1133,8 @@ static int coroutine_fn bdrv_driver_pwritev(BlockDriv= erState *bs, sector_num =3D offset >> BDRV_SECTOR_BITS; nb_sectors =3D bytes >> BDRV_SECTOR_BITS; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); assert(bytes <=3D BDRV_REQUEST_MAX_BYTES); =20 assert(drv->bdrv_co_writev); diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index cc5609e27a..f2de74690d 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -470,8 +470,8 @@ static bool coroutine_fn do_perform_cow_encrypt(BlockDr= iverState *bs, { if (bytes && bs->encrypted) { BDRVQcow2State *s =3D bs->opaque; - assert((offset_in_cluster & ~BDRV_SECTOR_MASK) =3D=3D 0); - assert((bytes & ~BDRV_SECTOR_MASK) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset_in_cluster, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); assert(s->crypto); if (qcow2_co_encrypt(bs, cluster_offset, src_cluster_offset + offset_in_cluster, diff --git a/block/qcow2.c b/block/qcow2.c index 7c5a4859f7..e82961c9cf 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2072,8 +2072,8 @@ static coroutine_fn int qcow2_co_preadv(BlockDriverSt= ate *bs, uint64_t offset, } if (bs->encrypted) { assert(s->crypto); - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((cur_bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(cur_bytes, BDRV_SECTOR_SIZE)); if (qcow2_co_decrypt(bs, cluster_offset, offset, cluster_data, cur_bytes) < 0) { ret =3D -EIO; diff --git a/block/vvfat.c b/block/vvfat.c index f6c28805dd..019b8f1341 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1547,8 +1547,8 @@ vvfat_co_preadv(BlockDriverState *bs, uint64_t offset= , uint64_t bytes, int nb_sectors =3D bytes >> BDRV_SECTOR_BITS; void *buf; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); =20 buf =3D g_try_malloc(bytes); if (bytes && buf =3D=3D NULL) { @@ -3082,8 +3082,8 @@ vvfat_co_pwritev(BlockDriverState *bs, uint64_t offse= t, uint64_t bytes, int nb_sectors =3D bytes >> BDRV_SECTOR_BITS; void *buf; =20 - assert((offset & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); - assert((bytes & (BDRV_SECTOR_SIZE - 1)) =3D=3D 0); + assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)); + assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); =20 buf =3D g_try_malloc(bytes); if (bytes && buf =3D=3D NULL) { diff --git a/qemu-img.c b/qemu-img.c index 7daa05e51a..cff21facf0 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2141,7 +2141,7 @@ static int img_convert(int argc, char **argv) int64_t sval; =20 sval =3D cvtnum(optarg); - if (sval < 0 || sval & (BDRV_SECTOR_SIZE - 1) || + if (sval < 0 || !QEMU_IS_ALIGNED(sval, BDRV_SECTOR_SIZE) || sval / BDRV_SECTOR_SIZE > MAX_BUF_SECTORS) { error_report("Invalid buffer size for sparse output specif= ied. " "Valid sizes are multiples of %llu up to %llu. Select " --=20 2.20.1