From nobody Wed Nov 12 00:12:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1566908473; cv=none; d=zoho.com; s=zohoarc; b=MM//uzb9ttbc+CN/HNsySRDSWR50NKhj4XQSSO9yMDZUjz96Xy/pPUHu2hkki0W/kbEnzGciwQOdbo2UgYb6Ql6+2mbeTtKheLckZ8Ua62pY06rFp1ccSKKrjoxksh8rggxtpTCE4pjomoSbpMqxysxf7S5PkHpMefMqZSbOAlo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566908473; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=LSr8udusvAKQfLLyJhhl5YxHdfLCgd98fSLGhAWYlM8=; b=ltpu4mk02krpkdbJVsG/oAxosMtxw5qDSWnpckx+wpDlbI+PCXbJVJOhmjYH5iM2Iyy4k7jsnqlviXLVzw1wxRQ2Pp2m/udq5P3Rum+tkkR8qBObjgZhy4MJ/TIZu8aZ3EJ1rIeVkZC9iyu29h2m69/+S7EoTMkq0V5CvbfWrvU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156690847326058.22141600457405; Tue, 27 Aug 2019 05:21:13 -0700 (PDT) Received: from localhost ([::1]:50734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2aTD-0005EO-I2 for importer@patchew.org; Tue, 27 Aug 2019 08:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48863) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2aRr-0004V1-RD for qemu-devel@nongnu.org; Tue, 27 Aug 2019 08:19:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2aRm-00011X-Bn for qemu-devel@nongnu.org; Tue, 27 Aug 2019 08:19:43 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:46407) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2aRk-0000zh-Jp for qemu-devel@nongnu.org; Tue, 27 Aug 2019 08:19:38 -0400 Received: by mail-wr1-x441.google.com with SMTP id z1so18568738wru.13 for ; Tue, 27 Aug 2019 05:19:35 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id b136sm7142435wme.18.2019.08.27.05.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2019 05:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LSr8udusvAKQfLLyJhhl5YxHdfLCgd98fSLGhAWYlM8=; b=c7GhC9rAOOWRSGiwDyr1nbxkIxrTJtyYpIq9ppC1pscvJaELKtD1ZXGPWS8O3xQJX1 1OVIBbqis9Yolb9WrW4pNEvh7CcY6sd3EALoSp698TJK9d5o92w6SzLMvdRDCq9RLREs trH1CysrJ50Y8VuAMRb5FyhDEnt6xp6e+Ec5Y+7VFxmKq89uhc/s08q1kPjIn/2KbKMi NEHrvB0HzVay3rm34chUXDhxrlk3IrPbLIkdBzX5a/Z2UGGdYdqJup7/p0GegFNrX1bV OgBVx+vpHReaMnlfAB6p77GwiZRodtekgA4y5bLBCGdEqdcDkbQCvFv4AsJhmvSkOXR3 QwgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LSr8udusvAKQfLLyJhhl5YxHdfLCgd98fSLGhAWYlM8=; b=tgP/b6eSG4x9JJc5oiOiK/N3b/W1uQzvS8JlupVZaLeD++SU8aKXxhpZXeaU20SIGZ aoZFvmaombiy2Ek8y1xggBDVr6Q6Ynb/4aSzWfs59gKXRJARnfkVehWpvvmChqvzVr0U TvvS4CGuA1EosGoluhTR7ZhK+SZfkK+qUl4TxcFOXzT6NL6yBU8YXo/aegAm1Lwlnbep GqNTS92PqmJ+/cGQmgIU1X3orQbgbg1KwKefTTR9pZGujmmqhGA9ZSLo/WsUWzOYGNVk B/ejyPXfYITczcDiGG63YcUBVr5cFaFS2+FzIuj+f8f1k6iiDzy2v4lQ+NZBHWRYn0y4 wQXw== X-Gm-Message-State: APjAAAXGZNI6SPkJH13GoPJ38XuysR3GGmgMBWXs7TLokomy63KtIwsA 96rFwD/L9BCHKBZYkDdNyHaEBc4ozihmsA== X-Google-Smtp-Source: APXvYqx4UfDmID6dCDako/+YKFwWuN2fSLPk975ILQg/8Z03bKxkXQAHElrhMsYrIv5Rshj+BqTjEA== X-Received: by 2002:a5d:4d81:: with SMTP id b1mr27642954wru.27.1566908373729; Tue, 27 Aug 2019 05:19:33 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 27 Aug 2019 13:19:31 +0100 Message-Id: <20190827121931.26836-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The function neon_store_reg32() doesn't free the TCG temp that it is passed, so the caller must do that. We got this right in most places but forgot to free the TCG temps in trans_VMOV_64_sp(). Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index 3e8ea80493b..9ae980bef63 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -880,8 +880,10 @@ static bool trans_VMOV_64_sp(DisasContext *s, arg_VMOV= _64_sp *a) /* gpreg to fpreg */ tmp =3D load_reg(s, a->rt); neon_store_reg32(tmp, a->vm); + tcg_temp_free_i32(tmp); tmp =3D load_reg(s, a->rt2); neon_store_reg32(tmp, a->vm + 1); + tcg_temp_free_i32(tmp); } =20 return true; --=20 2.20.1