From nobody Mon May 13 05:17:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566868132; cv=none; d=zoho.com; s=zohoarc; b=cdOwUSEtawl5L/qSsFDx0AeltLq2XXmaNxHsw4K+LHxEvB2cqgKcN6RvOsItDBdGPAIP7jC68Kadc3XHdAbFhoQzXIXyChIm+MV1kO1yXTumL/IPfDdTN3dFYdlsNWIgTr70GM7gnrEiqOQ+IkPrzpmVl+CqVXKTUEPQeXoYNqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566868132; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tqDEwSTOPWBoQPqbyeQ+Y2yGJ4LY6S12juTuhegTdj4=; b=ZHbFe2y/f6e6/lZwjFK+dGtXswyw+MFQ2AxeSEMiWqkEoVeGUmnBRgnDwJeQ3g31BVMEJS7WCd7lAOLU5NR/sdFB0lSaSTD4smwDPB8MwdRBFMSuNMNOTRN/APs9F2Je71lQwSu0N6AhU7zbFLmdj29i8h2yaUU9bnBP0l+NwpU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566868132389713.2188447469543; Mon, 26 Aug 2019 18:08:52 -0700 (PDT) Received: from localhost ([::1]:45686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Pya-0004VI-A7 for importer@patchew.org; Mon, 26 Aug 2019 21:08:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40620) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2PvV-0001zb-P2 for qemu-devel@nongnu.org; Mon, 26 Aug 2019 21:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2PvT-000897-Le for qemu-devel@nongnu.org; Mon, 26 Aug 2019 21:05:37 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:33097) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2PvT-00088Q-E3; Mon, 26 Aug 2019 21:05:35 -0400 Received: by mail-wr1-x441.google.com with SMTP id u16so17042157wrr.0; Mon, 26 Aug 2019 18:05:35 -0700 (PDT) Received: from sparse-local.redhat.com (93-172-125-206.bb.netvision.net.il. [93.172.125.206]) by smtp.gmail.com with ESMTPSA id v7sm14161572wrn.41.2019.08.26.18.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2019 18:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tqDEwSTOPWBoQPqbyeQ+Y2yGJ4LY6S12juTuhegTdj4=; b=PhuOjHgVR22OYXzx7Dn0SKgttGPINtXPQs2SeDCKfs/6tKti8vZCa6T3zxExlsBFAS 1njaHzgkS0sEyW0GKhLYXNt72H/V2Ha2+N7zjDECcZK9vo/Tj0Pzl9JeG7qTSZ0lnR5N 4PelcQB2fLE+4uyPK+uXMqZas50CYZ77Oc2h6j3VmXiFJvFFMAQ+VD7osroIKWwagTN+ SCNrMk5kbpsqLg0gSip+Hbs1x36ZfnrB3i/2HGJ8r3Ph3HY+Qz6OJHugl84TrnlS6IZc BqmYaZ7YYQeWlkAFQkKj7R6AoGnNSiSUMOxE20jptBsaITXVbtteojTRSolLPplZ3RnS Sr3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tqDEwSTOPWBoQPqbyeQ+Y2yGJ4LY6S12juTuhegTdj4=; b=WWhpxIWbqWlJ5z1A4hWIKofKAhR7Zjamz6wnG4w03fpEKxRuIBix1DEey0NX5g+8iY kbEeLdMticV6L8hAgUOYELQt1uCSk8C+AwoywXyHSosTCLUKcjCo/oh0YuyldXvF5lwG Ulef2YLyzKUs2IFL6UQw3m4Vt3BUAijAymXFN3kFxjTFcpX6JDBpLzcFNaXEGhL9IbFI 4CYXYULPSXkc3id2tXDjmgF28ydeG5HSxWAFPiac1xEbPwC1SBRjcHGurviiTwzTJQcc v5BBoTXwp97Qga4gmSadAXzFHb55sGmcLVQ37/afL3xsUDBFVf5mlqbX3gxKHhorBJND MV5A== X-Gm-Message-State: APjAAAUr0NhsJgemkc9Ps2nntlT7FWcTGnSgI7vqQvr0vxMFhHHCPQDc prwcPDSJWBtbV9FuQnyfcOOzPVl4q1I= X-Google-Smtp-Source: APXvYqxkzb40YWaYogk7NoRkRDuITD4D24P26xRu33FqGWlQPKA7RnDTDMwYqNAKiedMdDej1VbcEg== X-Received: by 2002:a5d:65ca:: with SMTP id e10mr11765602wrw.267.1566867933824; Mon, 26 Aug 2019 18:05:33 -0700 (PDT) From: Nir Soffer X-Google-Original-From: Nir Soffer To: qemu-devel@nongnu.org Date: Tue, 27 Aug 2019 04:05:27 +0300 Message-Id: <20190827010528.8818-2-nsoffer@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190827010528.8818-1-nsoffer@redhat.com> References: <20190827010528.8818-1-nsoffer@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 1/2] block: posix: Always allocate the first block X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Nir Soffer , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When creating an image with preallocation "off" or "falloc", the first block of the image is typically not allocated. When using Gluster storage backed by XFS filesystem, reading this block using direct I/O succeeds regardless of request length, fooling alignment detection. In this case we fallback to a safe value (4096) instead of the optimal value (512), which may lead to unneeded data copying when aligning requests. Allocating the first block avoids the fallback. Since we allocate the first block even with preallocation=3Doff, we no longer create images with zero disk size: $ ./qemu-img create -f raw test.raw 1g Formatting 'test.raw', fmt=3Draw size=3D1073741824 $ ls -lhs test.raw 4.0K -rw-r--r--. 1 nsoffer nsoffer 1.0G Aug 16 23:48 test.raw And converting the image requires additional cluster: $ ./qemu-img measure -f raw -O qcow2 test.raw required size: 458752 fully allocated size: 1074135040 When using format like vmdk with multiple files per image, we allocate one block per file: $ ./qemu-img create -f vmdk -o subformat=3DtwoGbMaxExtentFlat test.vmdk= 4g Formatting 'test.vmdk', fmt=3Dvmdk size=3D4294967296 compat6=3Doff hwve= rsion=3Dundefined subformat=3DtwoGbMaxExtentFlat $ ls -lhs test*.vmdk 4.0K -rw-r--r--. 1 nsoffer nsoffer 2.0G Aug 27 03:23 test-f001.vmdk 4.0K -rw-r--r--. 1 nsoffer nsoffer 2.0G Aug 27 03:23 test-f002.vmdk 4.0K -rw-r--r--. 1 nsoffer nsoffer 353 Aug 27 03:23 test.vmdk I did quick performance test for copying disks with qemu-img convert to new raw target image to Gluster storage with sector size of 512 bytes: for i in $(seq 10); do rm -f dst.raw sleep 10 time ./qemu-img convert -f raw -O raw -t none -T none src.raw dst.r= aw done Here is a table comparing the total time spent: Type Before(s) After(s) Diff(%) Reviewed-by: Max Reitz --------------------------------------- real 530.028 469.123 -11.4 user 17.204 10.768 -37.4 sys 17.881 7.011 -60.7 We can see very clear improvement in CPU usage. Signed-off-by: Nir Soffer --- block/file-posix.c | 51 +++++++++++++++++++ tests/qemu-iotests/059.out | 2 +- tests/qemu-iotests/{150.out =3D> 150.out.qcow2} | 0 tests/qemu-iotests/150.out.raw | 12 +++++ tests/qemu-iotests/175 | 19 ++++--- tests/qemu-iotests/175.out | 8 +-- tests/qemu-iotests/178.out.qcow2 | 4 +- tests/qemu-iotests/221.out | 12 +++-- tests/qemu-iotests/253.out | 12 +++-- 9 files changed, 99 insertions(+), 21 deletions(-) rename tests/qemu-iotests/{150.out =3D> 150.out.qcow2} (100%) create mode 100644 tests/qemu-iotests/150.out.raw diff --git a/block/file-posix.c b/block/file-posix.c index fbeb0068db..447f937aa1 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1749,6 +1749,43 @@ static int handle_aiocb_discard(void *opaque) return ret; } =20 +/* + * Help alignment probing by allocating the first block. + * + * When reading with direct I/O from unallocated area on Gluster backed by= XFS, + * reading succeeds regardless of request length. In this case we fallback= to + * safe alignment which is not optimal. Allocating the first block avoids = this + * fallback. + * + * fd may be opened with O_DIRECT, but we don't know the buffer alignment = or + * request alignment, so we use safe values. + * + * Returns: 0 on success, -errno on failure. Since this is an optimization, + * caller may ignore failures. + */ +static int allocate_first_block(int fd, size_t max_size) +{ + size_t write_size =3D (max_size < MAX_BLOCKSIZE) + ? BDRV_SECTOR_SIZE + : MAX_BLOCKSIZE; + size_t max_align =3D MAX(MAX_BLOCKSIZE, getpagesize()); + void *buf; + ssize_t n; + int ret; + + buf =3D qemu_memalign(max_align, write_size); + memset(buf, 0, write_size); + + do { + n =3D pwrite(fd, buf, write_size, 0); + } while (n =3D=3D -1 && errno =3D=3D EINTR); + + ret =3D (n =3D=3D -1) ? -errno : 0; + + qemu_vfree(buf); + return ret; +} + static int handle_aiocb_truncate(void *opaque) { RawPosixAIOData *aiocb =3D opaque; @@ -1788,6 +1825,17 @@ static int handle_aiocb_truncate(void *opaque) /* posix_fallocate() doesn't set errno. */ error_setg_errno(errp, -result, "Could not preallocate new data"); + } else if (current_length =3D=3D 0) { + /* + * posix_fallocate() uses fallocate() if the filesystem + * supports it, or fallback to manually writing zeroes. If + * fallocate() was used, unaligned reads from the fallocat= ed + * area in raw_probe_alignment() will succeed, hence we ne= ed to + * allocate the first block. + * + * Optimize future alignment probing; ignore failures. + */ + allocate_first_block(fd, offset); } } else { result =3D 0; @@ -1849,6 +1897,9 @@ static int handle_aiocb_truncate(void *opaque) if (ftruncate(fd, offset) !=3D 0) { result =3D -errno; error_setg_errno(errp, -result, "Could not resize file"); + } else if (current_length =3D=3D 0 && offset > current_length) { + /* Optimize future alignment probing; ignore failures. */ + allocate_first_block(fd, offset); } return result; default: diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out index 4fab42a28c..fe3f861f3c 100644 --- a/tests/qemu-iotests/059.out +++ b/tests/qemu-iotests/059.out @@ -27,7 +27,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D10737= 41824000 subformat=3DtwoGbMax image: TEST_DIR/t.vmdk file format: vmdk virtual size: 0.977 TiB (1073741824000 bytes) -disk size: 16 KiB +disk size: 1.97 MiB Format specific information: cid: XXXXXXXX parent cid: XXXXXXXX diff --git a/tests/qemu-iotests/150.out b/tests/qemu-iotests/150.out.qcow2 similarity index 100% rename from tests/qemu-iotests/150.out rename to tests/qemu-iotests/150.out.qcow2 diff --git a/tests/qemu-iotests/150.out.raw b/tests/qemu-iotests/150.out.raw new file mode 100644 index 0000000000..3cdc7727a5 --- /dev/null +++ b/tests/qemu-iotests/150.out.raw @@ -0,0 +1,12 @@ +QA output created by 150 + +=3D=3D=3D Mapping sparse conversion =3D=3D=3D + +Offset Length File +0 0x1000 TEST_DIR/t.IMGFMT + +=3D=3D=3D Mapping non-sparse conversion =3D=3D=3D + +Offset Length File +0 0x100000 TEST_DIR/t.IMGFMT +*** done diff --git a/tests/qemu-iotests/175 b/tests/qemu-iotests/175 index 51e62c8276..7ba28b3c1b 100755 --- a/tests/qemu-iotests/175 +++ b/tests/qemu-iotests/175 @@ -37,14 +37,16 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 # the file size. This function hides the resulting difference in the # stat -c '%b' output. # Parameter 1: Number of blocks an empty file occupies -# Parameter 2: Image size in bytes +# Parameter 2: Minimal number of blocks in an image +# Parameter 3: Image size in bytes _filter_blocks() { extra_blocks=3D$1 - img_size=3D$2 + min_blocks=3D$2 + img_size=3D$3 =20 - sed -e "s/blocks=3D$extra_blocks\\(\$\\|[^0-9]\\)/nothing allocated/" \ - -e "s/blocks=3D$((extra_blocks + img_size / 512))\\(\$\\|[^0-9]\\)= /everything allocated/" + sed -e "s/blocks=3D$min_blocks\\(\$\\|[^0-9]\\)/min allocation/" \ + -e "s/blocks=3D$((extra_blocks + img_size / 512))\\(\$\\|[^0-9]\\)= /max allocation/" } =20 # get standard environment, filters and checks @@ -60,16 +62,21 @@ size=3D$((1 * 1024 * 1024)) touch "$TEST_DIR/empty" extra_blocks=3D$(stat -c '%b' "$TEST_DIR/empty") =20 +# We always write the first byte; check how many blocks this filesystem +# allocates to match empty image alloation. +printf "\0" > "$TEST_DIR/empty" +min_blocks=3D$(stat -c '%b' "$TEST_DIR/empty") + echo echo "=3D=3D creating image with default preallocation =3D=3D" _make_test_img $size | _filter_imgfmt -stat -c "size=3D%s, blocks=3D%b" $TEST_IMG | _filter_blocks $extra_blocks = $size +stat -c "size=3D%s, blocks=3D%b" $TEST_IMG | _filter_blocks $extra_blocks = $min_blocks $size =20 for mode in off full falloc; do echo echo "=3D=3D creating image with preallocation $mode =3D=3D" IMGOPTS=3Dpreallocation=3D$mode _make_test_img $size | _filter_imgfmt - stat -c "size=3D%s, blocks=3D%b" $TEST_IMG | _filter_blocks $extra_blo= cks $size + stat -c "size=3D%s, blocks=3D%b" $TEST_IMG | _filter_blocks $extra_blo= cks $min_blocks $size done =20 # success, all done diff --git a/tests/qemu-iotests/175.out b/tests/qemu-iotests/175.out index 6d9a5ed84e..263e521262 100644 --- a/tests/qemu-iotests/175.out +++ b/tests/qemu-iotests/175.out @@ -2,17 +2,17 @@ QA output created by 175 =20 =3D=3D creating image with default preallocation =3D=3D Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 -size=3D1048576, nothing allocated +size=3D1048576, min allocation =20 =3D=3D creating image with preallocation off =3D=3D Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 preallocation= =3Doff -size=3D1048576, nothing allocated +size=3D1048576, min allocation =20 =3D=3D creating image with preallocation full =3D=3D Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 preallocation= =3Dfull -size=3D1048576, everything allocated +size=3D1048576, max allocation =20 =3D=3D creating image with preallocation falloc =3D=3D Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 preallocation= =3Dfalloc -size=3D1048576, everything allocated +size=3D1048576, max allocation *** done diff --git a/tests/qemu-iotests/178.out.qcow2 b/tests/qemu-iotests/178.out.= qcow2 index 55a8dc926f..9e7d8c44df 100644 --- a/tests/qemu-iotests/178.out.qcow2 +++ b/tests/qemu-iotests/178.out.qcow2 @@ -101,7 +101,7 @@ converted image file size in bytes: 196608 =3D=3D raw input image with data (human) =3D=3D =20 Formatting 'TEST_DIR/t.qcow2', fmt=3DIMGFMT size=3D1073741824 -required size: 393216 +required size: 458752 fully allocated size: 1074135040 wrote 512/512 bytes at offset 512 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -257,7 +257,7 @@ converted image file size in bytes: 196608 =20 Formatting 'TEST_DIR/t.qcow2', fmt=3DIMGFMT size=3D1073741824 { - "required": 393216, + "required": 458752, "fully-allocated": 1074135040 } wrote 512/512 bytes at offset 512 diff --git a/tests/qemu-iotests/221.out b/tests/qemu-iotests/221.out index 9f9dd52bb0..dca024a0c3 100644 --- a/tests/qemu-iotests/221.out +++ b/tests/qemu-iotests/221.out @@ -3,14 +3,18 @@ QA output created by 221 =3D=3D=3D Check mapping of unaligned raw image =3D=3D=3D =20 Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D65537 -[{ "start": 0, "length": 66048, "depth": 0, "zero": true, "data": false, "= offset": OFFSET}] -[{ "start": 0, "length": 66048, "depth": 0, "zero": true, "data": false, "= offset": OFFSET}] +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 61952, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}] +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 61952, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}] wrote 1/1 bytes at offset 65536 1 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -[{ "start": 0, "length": 65536, "depth": 0, "zero": true, "data": false, "= offset": OFFSET}, +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 61440, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}, { "start": 65536, "length": 1, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, { "start": 65537, "length": 511, "depth": 0, "zero": true, "data": false, = "offset": OFFSET}] -[{ "start": 0, "length": 65536, "depth": 0, "zero": true, "data": false, "= offset": OFFSET}, +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 61440, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}, { "start": 65536, "length": 1, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, { "start": 65537, "length": 511, "depth": 0, "zero": true, "data": false, = "offset": OFFSET}] *** done diff --git a/tests/qemu-iotests/253.out b/tests/qemu-iotests/253.out index 607c0baa0b..3d08b305d7 100644 --- a/tests/qemu-iotests/253.out +++ b/tests/qemu-iotests/253.out @@ -3,12 +3,16 @@ QA output created by 253 =3D=3D=3D Check mapping of unaligned raw image =3D=3D=3D =20 Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048575 -[{ "start": 0, "length": 1048576, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}] -[{ "start": 0, "length": 1048576, "depth": 0, "zero": true, "data": false,= "offset": OFFSET}] +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 1044480, "depth": 0, "zero": true, "data": fals= e, "offset": OFFSET}] +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 1044480, "depth": 0, "zero": true, "data": fals= e, "offset": OFFSET}] wrote 65535/65535 bytes at offset 983040 63.999 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -[{ "start": 0, "length": 983040, "depth": 0, "zero": true, "data": false, = "offset": OFFSET}, +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 978944, "depth": 0, "zero": true, "data": false= , "offset": OFFSET}, { "start": 983040, "length": 65536, "depth": 0, "zero": false, "data": tru= e, "offset": OFFSET}] -[{ "start": 0, "length": 983040, "depth": 0, "zero": true, "data": false, = "offset": OFFSET}, +[{ "start": 0, "length": 4096, "depth": 0, "zero": false, "data": true, "o= ffset": OFFSET}, +{ "start": 4096, "length": 978944, "depth": 0, "zero": true, "data": false= , "offset": OFFSET}, { "start": 983040, "length": 65536, "depth": 0, "zero": false, "data": tru= e, "offset": OFFSET}] *** done --=20 2.20.1 From nobody Mon May 13 05:17:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566868041; cv=none; d=zoho.com; s=zohoarc; b=bL7yT/pZK1inBPkLQD5z+MxzehjXyRj+1+TJwXnVvbjIAe7Xh1Hj/z4/LZmPc0IAilw1ZdKuF58xRrsxy3PpgdthNU+X5CP855Tyr0ZpPnAz5SnGHZOxJ+NNGgepMOEkCAMP0YfHDy6Ze7SLaMKe0Oz5v0GVd+vq4h8nO3W9O7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566868041; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fIvQy1ykQXBQTJsM7YCohNrs6CVu+JoIyyx/UlVI+UI=; b=PUXcTs8UfzvBrwQmW6KoiGBJcXRm6OqPYYjUDvqWCZPPtbR5KFAQp7q+UN4fP6UENZBiuHuOA2CK49s/q/j90aP8AcibtJqs3OggH5t1EEGYWIVnFo9JymFDuSa7hkVjy0gyzq98/ujBTISx/FKOurk9ePiJbtJSnrkkn7gSp7c= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566868041555185.02201927335443; Mon, 26 Aug 2019 18:07:21 -0700 (PDT) Received: from localhost ([::1]:45674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Px5-0002sZ-4x for importer@patchew.org; Mon, 26 Aug 2019 21:07:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40623) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2PvV-0001zc-Um for qemu-devel@nongnu.org; Mon, 26 Aug 2019 21:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2PvU-00089n-Ow for qemu-devel@nongnu.org; Mon, 26 Aug 2019 21:05:37 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2PvU-00089K-JG; Mon, 26 Aug 2019 21:05:36 -0400 Received: by mail-wr1-x443.google.com with SMTP id t16so17027982wra.6; Mon, 26 Aug 2019 18:05:36 -0700 (PDT) Received: from sparse-local.redhat.com (93-172-125-206.bb.netvision.net.il. [93.172.125.206]) by smtp.gmail.com with ESMTPSA id v7sm14161572wrn.41.2019.08.26.18.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2019 18:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fIvQy1ykQXBQTJsM7YCohNrs6CVu+JoIyyx/UlVI+UI=; b=Fa0AT+eiPwDEsigpiZQFk2fybq2xdQ5hJyYuXRhZEY9r+utGiYx27OQ3Ji/aOqd4TE vZP8xNL6fSY+Iwk22dWz9DSBLX+TOoPMetpcM4TXBB4YPCSnClDianC6lggV4XDgfh03 BfctNww9iU9tDSlC1MHfsOrklxTiD4c8gRvNLzSDeYeSMGBMq2lGMIgzRLJYScjMO4Cv GhstO1N2M8APou9FLnqiziPQ0EJIp1TWGnHCCX1lOEVifN+nEmLkyZ2T/GDStNIBghG3 zm5Q9AN5iQq0HEf/AXwMf7F4pWjp5daJTLGBWCF/NxEqnZa3o4Q4eL6//HSupVzihTqA Akxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fIvQy1ykQXBQTJsM7YCohNrs6CVu+JoIyyx/UlVI+UI=; b=OilH9vpcKC6wp74fjgqHsdZyVwIiQJemkb2036UILkG9RhlwRB2FTPzSp+VWC0fCJy sWt+6jc2fZ9dxlrYh9GMbbUt0ZTf/oBReg3k3zaagBt5PP4L7ttJNH0e9JoYn7M00XqD KZ5k04Ro9jdtIuRVVTdu7WnsjPfK57euCWDQQT3EWkklplqy9tmNGbmiHjuZWyHenlBJ VPV/F5X3HGzTkhDHggPV0aQyCnpQvPAzh0GXQEoI8d3msabgjlhfBSpep5hY7ZSWkooT G3VS+G475a2RlP1XH3PqPBl/uoxUPNkSzS3P7wdwqhbHTrtLE0VaDOP3CM8XFulvehAP atJA== X-Gm-Message-State: APjAAAU0B9TzG41mZIROrdzbc6zmvGFIJ0+KcEk6JL8hOSrXCAchkq+Y 9QQ9VOlf+/Vkc5roplxM82MZ0IVeCeg= X-Google-Smtp-Source: APXvYqz37iMY1lYU4gutEvTtPstHKCeW8NfAXjrmufQCGdunB3cuFOMgGOWSMHq+56Cc9W/SYbOkRQ== X-Received: by 2002:adf:f28d:: with SMTP id k13mr24015750wro.19.1566867935320; Mon, 26 Aug 2019 18:05:35 -0700 (PDT) From: Nir Soffer X-Google-Original-From: Nir Soffer To: qemu-devel@nongnu.org Date: Tue, 27 Aug 2019 04:05:28 +0300 Message-Id: <20190827010528.8818-3-nsoffer@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190827010528.8818-1-nsoffer@redhat.com> References: <20190827010528.8818-1-nsoffer@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v3 2/2] iotests: Test allocate_first_block() with O_DIRECT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Nir Soffer , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size will work since O_DIRECT does not require any alignment. Signed-off-by: Nir Soffer Reviewed-by: Max Reitz --- tests/qemu-iotests/175 | 28 ++++++++++++++++++++++++++++ tests/qemu-iotests/175.out | 8 ++++++++ 2 files changed, 36 insertions(+) diff --git a/tests/qemu-iotests/175 b/tests/qemu-iotests/175 index 7ba28b3c1b..55db2803ed 100755 --- a/tests/qemu-iotests/175 +++ b/tests/qemu-iotests/175 @@ -49,6 +49,23 @@ _filter_blocks() -e "s/blocks=3D$((extra_blocks + img_size / 512))\\(\$\\|[^0-9]\\)= /max allocation/" } =20 +# Resize image using block_resize. +# Parameter 1: image path +# Parameter 2: new size +_block_resize() +{ + local path=3D$1 + local size=3D$2 + + $QEMU -qmp stdio -nographic -nodefaults \ + -blockdev file,node-name=3Dfile,filename=3D$path,cache.direct=3Don= \ + </dev/null + stat -c "size=3D%s, blocks=3D%b" $TEST_IMG | _filter_blocks $extra_blo= cks $min_blocks $new_size +done + # success, all done echo "*** done" rm -f $seq.full diff --git a/tests/qemu-iotests/175.out b/tests/qemu-iotests/175.out index 263e521262..39c2ee0f62 100644 --- a/tests/qemu-iotests/175.out +++ b/tests/qemu-iotests/175.out @@ -15,4 +15,12 @@ size=3D1048576, max allocation =3D=3D creating image with preallocation falloc =3D=3D Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 preallocation= =3Dfalloc size=3D1048576, max allocation + +=3D=3D resize empty image with block_resize =3D=3D +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D0 +size=3D4096, min allocation + +=3D=3D resize empty image with block_resize =3D=3D +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D0 +size=3D1048576, min allocation *** done --=20 2.20.1