From nobody Mon May 6 13:36:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1566641342; cv=none; d=zoho.com; s=zohoarc; b=P7AAvmN29bXsXPYOLN3uzZI6dnMykmTodNN6H/zEApGl+M5fJ90YXZNcb8AlOYxpUDfhnaREatsQH8IfsuuroQLBzlWwtmSJo7fRhq8l4Z7RnniMn/4kkZmlSFu4Mv+YYCGGZjLlScGb7uSQW6XXm2Uu6GQsCGOXQ1UMtOvi9nM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566641342; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=TVTOhDWhSpPyrCNVr23tWwDmDBCM2H9Z4npI5GIqcfo=; b=bEPRkvTS5JuTzRG5n2JQOH+Rv88hH0pOyD1ezvw2gbJQpEAxk0eu2jL0P60yUylgJu1H6+v59R2JV7vYpfgJx4s93bbrYiqnc54dp7d2aFvAqx87NthfjoWQiPlCI7itiNCAzzWk5ZpsCHFOG9kUXy0s9CT/MkdD4jf/gtGWXAQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15666413425651.9673992212774465; Sat, 24 Aug 2019 03:09:02 -0700 (PDT) Received: from localhost ([::1]:36774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1Syj-0006gq-HZ for importer@patchew.org; Sat, 24 Aug 2019 06:09:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51289) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1SxY-0006A9-OO for qemu-devel@nongnu.org; Sat, 24 Aug 2019 06:07:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1SxX-0005XM-PU for qemu-devel@nongnu.org; Sat, 24 Aug 2019 06:07:48 -0400 Received: from relay.sw.ru ([185.231.240.75]:60740) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i1SxU-0005Se-J3; Sat, 24 Aug 2019 06:07:44 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1i1SxR-0007AX-IJ; Sat, 24 Aug 2019 13:07:41 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Date: Sat, 24 Aug 2019 13:07:40 +0300 Message-Id: <20190824100740.61635-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH] block: fix permission update in bdrv_replace_node X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It's wrong to OR shared permissions. It may lead to crash on further permission updates. Also, no needs to consider previously calculated permissions, as at this point we already bind all new parents and bdrv_get_cumulative_perm result is enough. So fix the bug by just set permissions by bdrv_get_cumulative_perm result. Bug was introduced in long ago 234ac1a9025, in 2.9. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! I found this bug during my work around backup-top filter. It happens that on filter removing, bdrv_replace_node() breaks permissions in graph which lead to bdrv_set_backing_hd(new backing: NULL) on assert(tighten_restrictions =3D=3D false). block.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 874a29a983..5944124845 100644 --- a/block.c +++ b/block.c @@ -4165,7 +4165,6 @@ void bdrv_replace_node(BlockDriverState *from, BlockD= riverState *to, { BdrvChild *c, *next; GSList *list =3D NULL, *p; - uint64_t old_perm, old_shared; uint64_t perm =3D 0, shared =3D BLK_PERM_ALL; int ret; =20 @@ -4211,8 +4210,8 @@ void bdrv_replace_node(BlockDriverState *from, BlockD= riverState *to, bdrv_unref(from); } =20 - bdrv_get_cumulative_perm(to, &old_perm, &old_shared); - bdrv_set_perm(to, old_perm | perm, old_shared | shared); + bdrv_get_cumulative_perm(to, &perm, &shared); + bdrv_set_perm(to, perm, shared); =20 out: g_slist_free(list); --=20 2.18.0