From nobody Mon Feb 9 12:10:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566494906; cv=none; d=zoho.com; s=zohoarc; b=J/FxNu9K6fGuYWSl0qnO9CuyTtl5GrRJmZj/Kl7IT/9kR2mwxFyYQ1hEemEolC5B+DxVigek1+GMt405dM2OLX736MFZz2/RIDnkmu/+ZaqfGzrniuDd8gCh18DS2awh9u7s0TxirmFt+thD+T4azEL0Ljx+nmO5KdFQLWiDWTs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566494906; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Uu7OzCHQpIacvMyLXUPZRrl2aGOsJQdoiWq/puAr918=; b=TQOGSy0gzzltXbUgqtEnN+CBf3qnHpNA/g3q7E1Wz433D4ZQzJAFt8Ypts4mAUbmHADpZiBIi3kDSkgfZdAEgzaRhpBp91vglVPya9EGsI/gC6jXTQ7IoDZaAHYcu4ve30LUppWFvx22mWs7R9tdfnxI/qOrDACW+y0QwJFNm2A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566494906326567.201006594437; Thu, 22 Aug 2019 10:28:26 -0700 (PDT) Received: from localhost ([::1]:46696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0qso-0001fk-P8 for importer@patchew.org; Thu, 22 Aug 2019 13:28:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35615) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0qos-0005uj-7i for qemu-devel@nongnu.org; Thu, 22 Aug 2019 13:24:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0qor-00037j-9s for qemu-devel@nongnu.org; Thu, 22 Aug 2019 13:24:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41780) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0qoo-00035b-ML; Thu, 22 Aug 2019 13:24:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC5A21801587; Thu, 22 Aug 2019 17:24:13 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-105.ams2.redhat.com [10.36.116.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02B8F60610; Thu, 22 Aug 2019 17:24:11 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, peterx@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com Date: Thu, 22 Aug 2019 19:23:48 +0200 Message-Id: <20190822172350.12008-4-eric.auger@redhat.com> In-Reply-To: <20190822172350.12008-1-eric.auger@redhat.com> References: <20190822172350.12008-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Thu, 22 Aug 2019 17:24:14 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 3/5] hw/vfio/common: Fail on VFIO/HW nested paging detection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" As of today, VFIO only works along with vIOMMU supporting caching mode. The SMMUv3 does not support this mode and requires HW nested paging to work properly with VFIO. So any attempt to run a VFIO device protected by such IOMMU would prevent the assigned device from working and at the moment the guest does not even boot as the default memory_region_iommu_replay() implementation attempts to translate the whole address space and completely stalls the guest. So let's fail on that case. Signed-off-by: Eric Auger --- v3 -> v4: - use IOMMU_ATTR_HW_NESTED_PAGING - do not abort anymore but jump to fail --- hw/vfio/common.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 3e03c495d8..2b66cf7553 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -606,9 +606,19 @@ static void vfio_listener_region_add(MemoryListener *l= istener, if (memory_region_is_iommu(section->mr)) { VFIOGuestIOMMU *giommu; IOMMUMemoryRegion *iommu_mr =3D IOMMU_MEMORY_REGION(section->mr); + bool nested; int iommu_idx; =20 trace_vfio_listener_region_add_iommu(iova, end); + + if (!memory_region_iommu_get_attr(iommu_mr, + IOMMU_ATTR_HW_NESTED_PAGING, + (void *)&nested) && nested) { + error_report("VFIO/vIOMMU integration based on HW nested pagin= g " + "is not yet supported"); + ret =3D -EINVAL; + goto fail; + } /* * FIXME: For VFIO iommu types which have KVM acceleration to * avoid bouncing all map/unmaps through qemu this way, this --=20 2.20.1