From nobody Fri May 3 05:00:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566472423; cv=none; d=zoho.com; s=zohoarc; b=JwjeFFjW7nkJQQ1CuCtWc6KIY/Rlo+jobCKj/z/SLjwiXWCS6kXRy1OenMVETjlY+NQbuUG6uwRQnNFgwrzXi84sCrqFnRDEtfYZdwRb06Zbu41QLdgY2KEFl8GT46RfYGl4A1324vMTEXA0TeTOGpBq0Yp3jF/dYNmjgndGMNU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566472423; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=0HUTsfpY2dUAMzPdqIgDlrdkogtfVxopInLvMKL6+j8=; b=iCddekA5f6eaBKBs023ceduluEyCizxPWmjFz8oPvm3B51F7oo+3mflyQ0GFtrF+KK2eZznaVt+uxo8/BXtr+TM/UsKYBwaTwKssjgkxEg4b/tc581pL8fgRN+AAHESyKfPxv3c8A6Qp7gjS4X9LJ3sIpPUGogVHyTg7lAWSngg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566472423476801.9504738498346; Thu, 22 Aug 2019 04:13:43 -0700 (PDT) Received: from localhost ([::1]:40866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0l2B-0001ND-87 for importer@patchew.org; Thu, 22 Aug 2019 07:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52346) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0l0y-0000NC-BT for qemu-devel@nongnu.org; Thu, 22 Aug 2019 07:12:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0l0x-0002Lr-C9 for qemu-devel@nongnu.org; Thu, 22 Aug 2019 07:12:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53230) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0l0x-0002Lc-6V for qemu-devel@nongnu.org; Thu, 22 Aug 2019 07:12:23 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74B7C18C426C; Thu, 22 Aug 2019 11:12:22 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-231.ams2.redhat.com [10.36.117.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 717D91001B17; Thu, 22 Aug 2019 11:12:21 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, dmitry.fleytman@gmail.com, jasowang@redhat.com Date: Thu, 22 Aug 2019 12:12:18 +0100 Message-Id: <20190822111218.12079-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Thu, 22 Aug 2019 11:12:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling unregister_savevm call. Remove it, although it doesn't seem to have any bad effect. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Dmitry Fleytman --- hw/net/vmxnet3.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index b07adeed9c..39ff6624c5 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj) =20 static void vmxnet3_pci_uninit(PCIDevice *pci_dev) { - DeviceState *dev =3D DEVICE(pci_dev); VMXNET3State *s =3D VMXNET3(pci_dev); =20 VMW_CBPRN("Starting uninit..."); =20 - unregister_savevm(dev, "vmxnet3-msix", s); - vmxnet3_net_uninit(s); =20 vmxnet3_cleanup_msix(s); --=20 2.21.0