From nobody Sat May 4 18:27:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566449032; cv=none; d=zoho.com; s=zohoarc; b=lTK7OelNMPFCM5wD91t+eTOFixDJjTllbQ4cPQj1dKIw9apEUlTkUL+WUWKtfkrOSKKpIyeDHJ6XH8b+aKjuSaz141gn5i0ZRrnTfNoKtReMIalezyntqF7iouITfnvDzIYHE8xBHa1ecrOdIgcB/6kQKQNgcRrrjbIJ2nhdVEM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566449032; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wulvj+b4T819uGh0jZ1Ab8maAW7pVpAdDmsDvGOxkvU=; b=iFUePVYQggA14U/ss0cLaR5n9ORiv7q5FSYNIoMKdne1iTHXCZEzE5co+IFJvjJHNLOdmtk9RNcapxa9CL9hPBbB/YDfZhSSusvGPX8MUicbuJUfimnl/k7rzLuIg7/WLgg98xg2sRZ1hUzGdLWM4vfG/J2nUqUmZSa9g7ONH4k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156644903294728.83421410563915; Wed, 21 Aug 2019 21:43:52 -0700 (PDT) Received: from localhost ([::1]:38102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0ewx-0005Ix-O1 for importer@patchew.org; Thu, 22 Aug 2019 00:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51424) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0evY-00047X-4l for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0evX-0002co-0G for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0evW-0002cE-Pm for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:22 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 029F2103EF49 for ; Thu, 22 Aug 2019 04:42:22 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F1435C221; Thu, 22 Aug 2019 04:42:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5CC3F97A1; Thu, 22 Aug 2019 06:42:18 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 22 Aug 2019 06:42:17 +0200 Message-Id: <20190822044218.9374-2-kraxel@redhat.com> In-Reply-To: <20190822044218.9374-1-kraxel@redhat.com> References: <20190822044218.9374-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Thu, 22 Aug 2019 04:42:22 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/2] curses: assert get_wch return value is okay X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini This prevents the compiler from reporting a possible uninitialized use of maybe_keycode in function curses_refresh. Cc: Gerd Hoffmann Signed-off-by: Paolo Bonzini Message-id: 1563451264-46176-1-git-send-email-pbonzini@redhat.com [ kraxel: whitespace fixup ] Signed-off-by: Gerd Hoffmann --- ui/curses.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/curses.c b/ui/curses.c index a6e260eb964d..ec281125acbd 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -225,6 +225,8 @@ static wint_t console_getch(enum maybe_keycode *maybe_k= eycode) case ERR: ret =3D -1; break; + default: + abort(); } return ret; } --=20 2.18.1 From nobody Sat May 4 18:27:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566449034; cv=none; d=zoho.com; s=zohoarc; b=TkOtz7thNbVtKlFt8ds1GfsjeAuTbCGoh44haBNacOAqTlRzZn1TglHixUnobP2EQc0ip04qmbXeMvlTtC5wxxpuj74LQEj36jxwKnAUychlEMYturl+21DsIs8JqKVjrQSZgXVxQdfuiq72Zb+jkqlHWO6oJqRsJkfVCVnVzho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566449034; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=zUS16+oG/IOmbqyfWD6NZ1O2h45bxVJOFYdIc/jrgvc=; b=e88XyQd149gAf/46T8r39zlRiUgRlRed4aifeiKRkmJonXkyrtGG62hHZzRNybnBscRZEA5HBXh8h1Glyq4MGtIQkbDLX3jlhiAEU1KeePQIRASSIeZyaKDQCMDXaxchYSzIWeOgLolJK44L3BQaKT4CKdSlmxXZVbpdBojJZ1E= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566449034649654.4913386137791; Wed, 21 Aug 2019 21:43:54 -0700 (PDT) Received: from localhost ([::1]:38104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0ewz-0005MT-Ac for importer@patchew.org; Thu, 22 Aug 2019 00:43:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51425) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0evY-00047Y-7a for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0evW-0002cX-SE for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32840) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0evW-0002c3-L9 for qemu-devel@nongnu.org; Thu, 22 Aug 2019 00:42:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9F133084295; Thu, 22 Aug 2019 04:42:21 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 562D060F88; Thu, 22 Aug 2019 04:42:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 66BC493C9; Thu, 22 Aug 2019 06:42:18 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 22 Aug 2019 06:42:18 +0200 Message-Id: <20190822044218.9374-3-kraxel@redhat.com> In-Reply-To: <20190822044218.9374-1-kraxel@redhat.com> References: <20190822044218.9374-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 22 Aug 2019 04:42:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/2] input-linux: add shift+shift as a grab toggle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niklas Haas , Gerd Hoffmann , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Niklas Haas We have ctrl-ctrl and alt-alt; why not shift-shift? That's my preferred grab binding, personally. Signed-off-by: Niklas Haas Message-id: 20190818105038.19520-1-qemu@haasn.xyz Signed-off-by: Gerd Hoffmann --- ui/input-linux.c | 4 ++++ qapi/ui.json | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ui/input-linux.c b/ui/input-linux.c index 59456fe7658b..a7b280b25b98 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -113,6 +113,10 @@ static bool input_linux_check_toggle(InputLinux *il) return il->keydown[KEY_LEFTALT] && il->keydown[KEY_RIGHTALT]; =20 + case GRAB_TOGGLE_KEYS_SHIFT_SHIFT: + return il->keydown[KEY_LEFTSHIFT] && + il->keydown[KEY_RIGHTSHIFT]; + case GRAB_TOGGLE_KEYS_META_META: return il->keydown[KEY_LEFTMETA] && il->keydown[KEY_RIGHTMETA]; diff --git a/qapi/ui.json b/qapi/ui.json index 59e412139adc..e04525d8b44b 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1025,7 +1025,8 @@ # ## { 'enum': 'GrabToggleKeys', - 'data': [ 'ctrl-ctrl', 'alt-alt', 'meta-meta', 'scrolllock', 'ctrl-scrol= llock' ] } + 'data': [ 'ctrl-ctrl', 'alt-alt', 'shift-shift','meta-meta', 'scrolllock= ', + 'ctrl-scrolllock' ] } =20 ## # @DisplayGTK: --=20 2.18.1