From nobody Tue Feb 10 06:43:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1566386611; cv=none; d=zoho.com; s=zohoarc; b=lYutemLo2mGgkeDVlOGFJDJ6RC127tQ0pdF2xKySACBhUVlv8p+qaZsn5h4H2AGv6hSEAANgkwRaQptAOQmsWmaCyMbA7lUN7dk5B8liXvVEBEZOS8Rr585clkeSX+vBCMi8OvjQKZ6FBbDvBdspKcLwilhUhsGIC8Jl5Xnd5oM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566386611; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=d8od1JPMhT3TdqOXIyIZjtzTTMpPMIPalGjVgkjYsK4=; b=E0rjrm1HriYF7FR9F2nRO0O7d5SCl8g6vx9l7k4wF5Lnv+xWy8rJzRlPbF4Oc2NvPcV+mTzjgqyO2eZTLI8rqbnEUROYshBv417oEDMy+ai86t9Av0pzblOF7rYgbIAZJUv+B24Z0FKNM0mMN/hNmWZrZ7Z6/DdOj1SRx8TdGb8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566386611630827.3979946894481; Wed, 21 Aug 2019 04:23:31 -0700 (PDT) Received: from localhost ([::1]:47058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Oi9-0000Es-Q1 for importer@patchew.org; Wed, 21 Aug 2019 07:23:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53587) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0OfS-00057I-RC for qemu-devel@nongnu.org; Wed, 21 Aug 2019 07:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0OfQ-0006dw-SO for qemu-devel@nongnu.org; Wed, 21 Aug 2019 07:20:42 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:49615) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0OfM-0006Yy-T4; Wed, 21 Aug 2019 07:20:38 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MbBUc-1iXWU71nWC-00bcEU; Wed, 21 Aug 2019 13:20:11 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 21 Aug 2019 13:19:44 +0200 Message-Id: <20190821111947.26580-12-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu> References: <20190821111947.26580-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:/oOFEv+k3MPTZ96mUEMj/iCXZ45kRUL3eJQ8HPBaJiqO5J0VmDa 2k9TwkVRGXjuYvwXElBiKM3v1yh68CFr5ElZUw4QMLhzZnT00TuS9pM0RVWHLCql7N5U/rt RLiwj2RyW/m4hHYxtzcmKuagGjgNGtiPLatUFycPIiWpmyOUqN2oBYOQKtRKYMcQbeeS4ZJ qPhYDng9Lv9teI7IlUV0Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:BxAiurucm6M=:OTRWXvXQbGGgFzqW+rNfSQ on7IFr0c27dgp2X1cDZMDFP4dUJvJOEM7f7v/8Nmi186sFBwMSqcEukgDZcb2vtD8SZvTwAu+ 8hN4B+Wu+dANO6UJDEDWPV6Ot9HzQhHHqmS6t0PlSnkPXyqBl/zLxV6YkPVSLgaqqq4yATFG7 jMYsX8Q44wndzfNVQyF/UEMYspxqfWipLdp77fl1x7M4yHl2OuUCiBsQ+NPIP16sTCdGjEyqF EAhO66A8TEeBJurAGPEcUcLpt7ldpWeTmWGq5NPJdLPD5+eoexnC7yjmN7DmzzH8yazXkfC91 Pyo0UfKYCRj+JnrtzeDDzzYLdG5UE77ggEcfNFE/tsLAwDxiqlZ6eJNjsuZy9s9Bdk25KD0LD 8LNDt05YOMSIyct4eTdtYZITA76TmgIcxy5Pqjzo5Uf7pFN4O5W+D4bRq0Dm+jHZEk47+/WnH 755SmoZniMwwisMkThKcA2yPfGiNZBnsVUdqSkSC9DQhsei9HLRIcqCmGyuoSegTCAP5x2pRh UMPojOXps4HC1mlKohK+wWsx9HFIhtPB0dZUp6adsPpA3VlspkUkR31DcwIGMEol+2Ty66iIh pQpswTmtkioYLkkzViI6B14hgWUOW9i6IQqRJHMVClAxwIZoUUasAdw9TW+o29/2zgiRwUa3v 4AqjqR6yQsro7RoZaXiRIahjCGGApxFH8DDznAnr3xDCJlP8juZAEW5MVqX4l79JL6cnEByYQ prK/OxiJdNxlCUHtNcUkippyUzJtw0A39wJYu81p+1cf777368FRUWwCCS4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [PULL 11/14] vl: Rewrite a fall through comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Corey Minyard , Juan Quintela , qemu-trivial@nongnu.org, Stefan Weil , Jason Wang , "Michael S. Tsirkin" , Michael Tokarev , Markus Armbruster , John Snow , Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: vl.c: In function =E2=80=98qemu_ref_timedate=E2=80=99: vl.c:773:15: error: this statement may fall through [-Werror=3Dimplicit-f= allthrough=3D] 773 | value -=3D rtc_realtime_clock_offset; | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ vl.c:775:5: note: here 775 | case QEMU_CLOCK_VIRTUAL: | ^~~~ cc1: all warnings being treated as errors Rewrite the comment using 'fall through' which is recognized by GCC and static analyzers. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: John Snow Message-Id: <20190719131425.10835-7-philmd@redhat.com> Signed-off-by: Laurent Vivier --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index edd5390110b2..1588dd8fc337 100644 --- a/vl.c +++ b/vl.c @@ -772,7 +772,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock) switch (clock) { case QEMU_CLOCK_REALTIME: value -=3D rtc_realtime_clock_offset; - /* no break */ + /* fall through */ case QEMU_CLOCK_VIRTUAL: value +=3D rtc_ref_start_datetime; break; --=20 2.21.0