From nobody Fri May 3 14:14:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1566379294; cv=none; d=zoho.com; s=zohoarc; b=BCcAcTDd39vme0BFzrUVahZPCh7DJMIlPKKOdEORgFNSzAd0I6ifoXf52E+VYHoChobF40DufbwYPaCmpWfzcgx2EoJ7kzhrRL4wE2alReU3pc6m7lNzSpNowoNJCNAtyo1yRSAgASlAg49wXKpjCzu0QAzARzo4aweljZkoigY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566379294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=f8exgmt6g75a7oq7oDszaPVO2mV/U4D2iWBbM6BFmEo=; b=YZgBALuTzNC1L+r5aC95h0t2+Y6VNHgjSegZOorMyOfg31/MqJ3qUgy9UD+2u8+qJXlfiO3gyBCgG/WHLAdd0aEEoRs0e/Yn+iDlW1kqP4Arx8vrYVlt+asiv5xU96Uteig8kPe0eMKyF4ydmZ77AaYZN6r193IfOG+VwqJ89Is= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566379294676149.96305394656576; Wed, 21 Aug 2019 02:21:34 -0700 (PDT) Received: from localhost ([::1]:46288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Mo5-0003MP-P0 for importer@patchew.org; Wed, 21 Aug 2019 05:21:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Mn6-0002NO-Uq for qemu-devel@nongnu.org; Wed, 21 Aug 2019 05:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0Mn5-0007m5-TM for qemu-devel@nongnu.org; Wed, 21 Aug 2019 05:20:28 -0400 Received: from esa6.hc3370-68.iphmx.com ([216.71.155.175]:7419) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0Mn5-0007iC-LH; Wed, 21 Aug 2019 05:20:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1566379227; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BK2UfPfQnsAdpwWahhn9/K+61xT4PsE2aBOjJXllKHk=; b=dzNc5o+nTt70S3GIToqrIr1/+IfDW538isrj+W8exeKUu4H37ojD/a+O RlQZJHqmj43SyKiZROKOWnZYllgsvQKzDT2b2UOeGu4b9aBGVYGNbzhWa 84ijbGOMRXWIYHd2KF83rb40zQpZetY7V+F+X+ercbIEkJvJrdrntk90g c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Dre/avdhM7+LkeeYNgXPxCnkXilAmFPsNzT4qdmjCyNlv3RbAuMOhVn8Hnt589TC2ULQAyStmJ wztSwrqA0slgsaYkaxu90dU3UyfmxOHqd0ywcZ+98kK+RjFO9FYLuJIE8r0tRR/Gn7YVBB4lqB b6iSUVXUkjPwrJUtVz621eni4MLaOxm7efr/gQJaNhCkecfQ5HGEJ5VuHoNh6x87n95f+58EuQ 1tNsyO2VabwmwuQl/amP+KFPELiUvI3GQAooAUS887cQnyBt9uPiTpot6St8gekcuXoRKO+e2D PLI= X-SBRS: 2.7 X-MesageID: 4731850 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,412,1559534400"; d="scan'208";a="4731850" From: Anthony PERARD To: Date: Wed, 21 Aug 2019 10:20:19 +0100 Message-ID: <20190821092020.17952-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190821092020.17952-1-anthony.perard@citrix.com> References: <20190821092020.17952-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 216.71.155.175 Subject: [Qemu-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-stable@nongnu.org, Paul Durrant Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When a frontend want to reset its state and the backend one, it start with setting "Closing", then wait for the backend (QEMU) to do the same. But when QEMU is setting "Closing" to its state, it trigger an event (xenstore watch) that re-execute xen_device_backend_changed() and set the backend state to "Closed". QEMU should wait for the frontend to set "Closed" before doing the same. Before setting "Closed" to the backend_state, we are also going to check if the frontend was responsible for the transition to "Closing". Fixes: b6af8926fb858c4f1426e5acb2cfc1f0580ec98a Signed-off-by: Anthony PERARD --- Cc: qemu-stable@nongnu.org --- hw/xen/xen-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index e40500242d..982eca4533 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -540,9 +540,11 @@ static void xen_device_backend_changed(void *opaque) /* * If the toolstack (or unplug request callback) has set the backend * state to Closing, but there is no active frontend (i.e. the - * state is not Connected) then set the backend state to Closed. + * state is not Connected or Closing) then set the backend state + * to Closed. */ if (xendev->backend_state =3D=3D XenbusStateClosing && + xendev->frontend_state !=3D XenbusStateClosing && xendev->frontend_state !=3D XenbusStateConnected) { xen_device_backend_set_state(xendev, XenbusStateClosed); } --=20 Anthony PERARD From nobody Fri May 3 14:14:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1566379292; cv=none; d=zoho.com; s=zohoarc; b=jqU3X9KoC9SwmuL7zx8v73tcjFIQUqXx3K0R6ZHem5+XDQWUITPcXKpFw817DHoxVZetkjbTLTfjjqw6YaxcSfcBW7TNz1oC3LxDKM4m2CNdO/+CjzK8x6lVN8++PfiFzseZVafid1PEft1xsT60PBlRvKznnS35Ke+Qc2k8xD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566379292; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VkKbey+8vHX6Tb2ojw4/hsUY+j5oTe+j667ZHgVJrTw=; b=LHU5c9Dp2wdvpaJr6LiB0vSLFfeRDqVa6laIWEoaVC71bJGFS2vWQSp1xS4a92KOSYwWdEjPaEVk1tnDeGZ31EtfGLPuPGYLQJ+QYdnHbmpwxHHNBxYqgc7KXWG9ZC0JqmAbnOQu0ctzbnUUgpNP7Z67ylcCs1wOlCkszRsFYVc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1566379292487618.2472272159765; Wed, 21 Aug 2019 02:21:32 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i0Mn9-0002Bl-0N; Wed, 21 Aug 2019 09:20:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i0Mn7-0002BR-51 for xen-devel@lists.xenproject.org; Wed, 21 Aug 2019 09:20:29 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7d46f26-c3f4-11e9-8980-bc764e2007e4; Wed, 21 Aug 2019 09:20:24 +0000 (UTC) X-Inumbo-ID: e7d46f26-c3f4-11e9-8980-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1566379223; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LKkFWbEHVRRLGoXttk3iW00wagoE0ctWHxQjhYL3ir4=; b=CIYeLwWrLPLTYKDkUjlfLFwmeUjJcnDDBTCmLR/FChkugp8QDzNKnCD7 3w/vzhn8rYvQrwcQcwrDgEcZuZQTh1XgZTStnwVPgIkAxFOCWD/nrrKVW DfgysVTyYfMrfXxIlZgg/afE7eFLLHi8xmSIX76U4pymYReyo2M7cpx/7 E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: WfjGDj2DQFiJy54qdsaOgrVkQw3aWiHlsoBLNpBt2U248THIHc0Y8riEu/v4C7ZiixdnbUtqVz P7C55PalBoVq1dTW8NTiC5YMfvoghAdjR2vZ6Yh5i85o7QDyyJwMdXJ6dadkZnMRRbvp3Su9Tm vpSAc+zamMqDQnOWIQP8lN9v9z673ja0WxAsyn+0WrJLMuVRwWD5q38ilHA7g+zWEkWxsH8aIi Z3hE7/sV4H3dBg/eeYjP6eNDuE4NkHWj3Ojfia/zOWkQmdPryzHwrzvyCQ0FvIISAUydX0ytaB ZFM= X-SBRS: 2.7 X-MesageID: 4731852 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,412,1559534400"; d="scan'208";a="4731852" From: Anthony PERARD To: Date: Wed, 21 Aug 2019 10:20:20 +0100 Message-ID: <20190821092020.17952-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190821092020.17952-1-anthony.perard@citrix.com> References: <20190821092020.17952-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) When QEMU receive a xenstore watch event suggesting that the "state" or "online" status of the frontend or the backend changed, it record this in its own state but it also re-write the value back into xenstore even so there were no changed. This trigger an unnecessary xenstore watch event which QEMU will process again (and maybe the frontend as well). Signed-off-by: Anthony PERARD --- hw/xen/xen-bus.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index 982eca4533..c83f07424a 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -481,20 +481,27 @@ static int xen_device_backend_scanf(XenDevice *xendev= , const char *key, return rc; } =20 -void xen_device_backend_set_state(XenDevice *xendev, - enum xenbus_state state) +static bool xen_device_backend_record_state(XenDevice *xendev, + enum xenbus_state state) { const char *type =3D object_get_typename(OBJECT(xendev)); =20 if (xendev->backend_state =3D=3D state) { - return; + return false; } =20 trace_xen_device_backend_state(type, xendev->name, xs_strstate(state)); =20 xendev->backend_state =3D state; - xen_device_backend_printf(xendev, "state", "%u", state); + return true; +} + +void xen_device_backend_set_state(XenDevice *xendev, + enum xenbus_state state) +{ + if (xen_device_backend_record_state(xendev, state)) + xen_device_backend_printf(xendev, "state", "%u", state); } =20 enum xenbus_state xen_device_backend_get_state(XenDevice *xendev) @@ -502,7 +509,8 @@ enum xenbus_state xen_device_backend_get_state(XenDevic= e *xendev) return xendev->backend_state; } =20 -static void xen_device_backend_set_online(XenDevice *xendev, bool online) +static void xen_device_backend_set_online(XenDevice *xendev, bool online, + bool export) { const char *type =3D object_get_typename(OBJECT(xendev)); =20 @@ -513,7 +521,8 @@ static void xen_device_backend_set_online(XenDevice *xe= ndev, bool online) trace_xen_device_backend_online(type, xendev->name, online); =20 xendev->backend_online =3D online; - xen_device_backend_printf(xendev, "online", "%u", online); + if (export) + xen_device_backend_printf(xendev, "online", "%u", online); } =20 static void xen_device_backend_changed(void *opaque) @@ -529,13 +538,13 @@ static void xen_device_backend_changed(void *opaque) state =3D XenbusStateUnknown; } =20 - xen_device_backend_set_state(xendev, state); + xen_device_backend_record_state(xendev, state); =20 if (xen_device_backend_scanf(xendev, "online", "%u", &online) !=3D 1) { online =3D 0; } =20 - xen_device_backend_set_online(xendev, !!online); + xen_device_backend_set_online(xendev, !!online, false); =20 /* * If the toolstack (or unplug request callback) has set the backend @@ -683,7 +692,8 @@ int xen_device_frontend_scanf(XenDevice *xendev, const = char *key, } =20 static void xen_device_frontend_set_state(XenDevice *xendev, - enum xenbus_state state) + enum xenbus_state state, + bool export) { const char *type =3D object_get_typename(OBJECT(xendev)); =20 @@ -695,7 +705,8 @@ static void xen_device_frontend_set_state(XenDevice *xe= ndev, xs_strstate(state)); =20 xendev->frontend_state =3D state; - xen_device_frontend_printf(xendev, "state", "%u", state); + if (export) + xen_device_frontend_printf(xendev, "state", "%u", state); } =20 static void xen_device_frontend_changed(void *opaque) @@ -711,7 +722,7 @@ static void xen_device_frontend_changed(void *opaque) state =3D XenbusStateUnknown; } =20 - xen_device_frontend_set_state(xendev, state); + xen_device_frontend_set_state(xendev, state, false); =20 if (state =3D=3D XenbusStateInitialising && xendev->backend_state =3D=3D XenbusStateClosed && @@ -1146,7 +1157,7 @@ static void xen_device_realize(DeviceState *dev, Erro= r **errp) xendev->frontend_id); xen_device_backend_printf(xendev, "hotplug-status", "connected"); =20 - xen_device_backend_set_online(xendev, true); + xen_device_backend_set_online(xendev, true, true); xen_device_backend_set_state(xendev, XenbusStateInitWait); =20 xen_device_frontend_printf(xendev, "backend", "%s", @@ -1154,7 +1165,7 @@ static void xen_device_realize(DeviceState *dev, Erro= r **errp) xen_device_frontend_printf(xendev, "backend-id", "%u", xenbus->backend_id); =20 - xen_device_frontend_set_state(xendev, XenbusStateInitialising); + xen_device_frontend_set_state(xendev, XenbusStateInitialising, true); =20 xendev->exit.notify =3D xen_device_exit; qemu_add_exit_notifier(&xendev->exit); --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel