From nobody Sun May 19 23:34:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566377667; cv=none; d=zoho.com; s=zohoarc; b=Pc58Kjv5gu0NMmyVbUGJgN+I6wK3HR+OBTRVKF+b/ULviq4xFf9nfKNNpnrkNgEKIpA3iwYF/45iop6fNvAiP+YvpcA1XBWQshM4OY/SQgZajrsHaJeUayYKEaqJKj5c6Y+VAwgNkE+3fXipXz6aJ410loh9XovIgmqB85Pps5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566377667; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=LpKVVCk6rf4W6rMIiSPcj1fj08CPj5hY/h5O+H6Cwj4=; b=BCuDUrlYUbmRLnFjGeJzaWRD70XTzEVR/lLWEZtAJ1I1iZ1m/A3u2uCv318gUzv+mlJtOuJBHW2wgDh4H7JtjfLphub2PCKZ/GH3K6xhsBHmQbuginOxqOpscSB8L+5wSUhNZEYtapzNp1b3giKlkr//0O1z19xJGBT/IACcVC0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566377667123979.5553810055242; Wed, 21 Aug 2019 01:54:27 -0700 (PDT) Received: from localhost ([::1]:45556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0MNt-0003rT-MZ for importer@patchew.org; Wed, 21 Aug 2019 04:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57550) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0MMv-0002NX-0v for qemu-devel@nongnu.org; Wed, 21 Aug 2019 04:53:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0MMt-0002ag-Un for qemu-devel@nongnu.org; Wed, 21 Aug 2019 04:53:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0MMt-0002aK-QG for qemu-devel@nongnu.org; Wed, 21 Aug 2019 04:53:23 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F26DA10F23E1 for ; Wed, 21 Aug 2019 08:53:22 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52D495D9E1; Wed, 21 Aug 2019 08:53:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6D4D916E1A; Wed, 21 Aug 2019 10:53:19 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 21 Aug 2019 10:53:19 +0200 Message-Id: <20190821085319.13711-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 21 Aug 2019 08:53:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] ehci: fix queue->dev null ptr dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In case we don't have a device for an active queue, just skip processing the queue (same we do for inactive queues) and log a guest bug. Reported-by: Guenter Roeck Signed-off-by: Gerd Hoffmann Tested-by: Guenter Roeck --- hw/usb/hcd-ehci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 62dab0592fa2..5f089f30054b 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1834,6 +1834,9 @@ static int ehci_state_fetchqtd(EHCIQueue *q) ehci_set_state(q->ehci, q->async, EST_EXECUTING); break; } + } else if (q->dev =3D=3D NULL) { + ehci_trace_guest_bug(q->ehci, "no device attached to queue"); + ehci_set_state(q->ehci, q->async, EST_HORIZONTALQH); } else { p =3D ehci_alloc_packet(q); p->qtdaddr =3D q->qtdaddr; --=20 2.18.1