From nobody Mon Feb 9 23:40:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1566373391; cv=none; d=zoho.com; s=zohoarc; b=a4F/i9eX4OZQmASTxU9MM+L2LOSlqJ2hIkmpa41FBmGETJ0vbPaxhDRdRUS1/fmE/RYM2HsLZS+o8T09SB+OkNeWawPZVlUtCYJsZ9Y5soQFsY/foqg9hJ7xZDVbjrmNzFnb93pms1Mc0LEMVcjoSELamTIW4CdnSXTanZmjuTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566373391; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=STIgmMC+JdIsLa2xQZqpS/9C4InNAQorDvSrQPdz3Eg=; b=VjYD5+yqKJGK9rd3xr2+xVEiHJ5wuRxft4ntTu0s4iPgf1MQ1dYeoaAXXnhVzUF4n3GF/J5wWyNH5FrwOoRKlzDlzMlPxaRZWXL6AZhgEwWdjKcLamCVi3ivByP/j9jT5kdpMYeZ3/5pvjDlWXopECaZ/bPYto38ydZHjZrAqA8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566373391703866.9564709466761; Wed, 21 Aug 2019 00:43:11 -0700 (PDT) Received: from localhost ([::1]:44576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0LGw-00088H-5E for importer@patchew.org; Wed, 21 Aug 2019 03:43:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42222) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0L0R-0004Zw-NP for qemu-devel@nongnu.org; Wed, 21 Aug 2019 03:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0L0Q-00085q-DJ for qemu-devel@nongnu.org; Wed, 21 Aug 2019 03:26:07 -0400 Received: from ozlabs.org ([203.11.71.1]:38709) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0L0O-00080z-4o; Wed, 21 Aug 2019 03:26:06 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46CzjC0XKZz9sPX; Wed, 21 Aug 2019 17:25:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1566372351; bh=Earpzbotodmq+6AVBesUPaAt9w4yNd1a53n3eu+jomQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=plNQQtbs17e80F8ssoB9Qzr8Qg/OUJHBSA6yQXrgzetQRV7+Og8UfBy5exddsJ80S 6IXct0XwJa3QUyYKyPxvJ4IRTsU8UFRbzEC9tGgN5CyqrcHD7qmTscTR3bSlPI5AFJ fEwtgFqLkJZawUnE1RQroasNrAdWnI8zH/5Sszbk= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 21 Aug 2019 17:25:12 +1000 Message-Id: <20190821072542.23090-13-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190821072542.23090-1-david@gibson.dropbear.id.au> References: <20190821072542.23090-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 12/42] ppc: fix memory leak in spapr_caps_add_properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Shivaprasad G Bhat , aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Shivaprasad G Bhat Free the capability name string after setting the capability. Signed-off-by: Shivaprasad G Bhat Message-Id: <156335156198.82682.8756968724044750843.stgit@lep8c.aus.stglabs= .ibm.com> Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_caps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index a61bf329bf..481dfd2a27 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -793,7 +793,7 @@ void spapr_caps_add_properties(SpaprMachineClass *smc, = Error **errp) =20 for (i =3D 0; i < ARRAY_SIZE(capability_table); i++) { SpaprCapabilityInfo *cap =3D &capability_table[i]; - const char *name =3D g_strdup_printf("cap-%s", cap->name); + char *name =3D g_strdup_printf("cap-%s", cap->name); char *desc; =20 object_class_property_add(klass, name, cap->type, @@ -801,11 +801,13 @@ void spapr_caps_add_properties(SpaprMachineClass *smc= , Error **errp) NULL, cap, &local_err); if (local_err) { error_propagate(errp, local_err); + g_free(name); return; } =20 desc =3D g_strdup_printf("%s", cap->description); object_class_property_set_description(klass, name, desc, &local_er= r); + g_free(name); g_free(desc); if (local_err) { error_propagate(errp, local_err); --=20 2.21.0