From nobody Tue Nov 11 22:50:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566241622; cv=none; d=zoho.com; s=zohoarc; b=YU8chuDt3g3P+0b3IlBWAxuBpdeG4bcfIDZrGYoLYD+qRobmM9y0n7xZ+YXPcw3BIGgfhJX8WJbW1I/psNr0ojmKeCFcnOn4T+xcRLkPp3x48lHYNMomjSa3weLsVaf2c8ZtJ+zh9Zs6jAbJQqfJOTcPVCsYdISVBjIG3G8p3P4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566241622; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=k1PkC039RJhIBGbMDgtO8fZn2DiZpVEgZEV1TsOoiqQ=; b=aja4pvrhRcTdVXrQ/962bAiLzOHpxwc/JudbxdKmKBlft6oiMRXBoCjNMwSLVGK/IaJ95JcoRpO4bbMaYE2Sbr8/CrokRAJaGemNIG12zC1CqHT3HlhWCJ+LABpklvWxe5usDbtsIgZA0omIeyTB9hGCxWIlxtzsouehwv6bqmQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156624162217191.88037038208438; Mon, 19 Aug 2019 12:07:02 -0700 (PDT) Received: from localhost ([::1]:56684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzmzc-0006V9-Sz for importer@patchew.org; Mon, 19 Aug 2019 15:07:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32886) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzmpk-0002Rn-TT for qemu-devel@nongnu.org; Mon, 19 Aug 2019 14:56:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzmpj-0002EL-RV for qemu-devel@nongnu.org; Mon, 19 Aug 2019 14:56:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51430) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzmph-0002Ch-OB; Mon, 19 Aug 2019 14:56:45 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 121D13018ED8; Mon, 19 Aug 2019 18:56:45 +0000 (UTC) Received: from localhost (ovpn-204-64.brq.redhat.com [10.40.204.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C6A310013A1; Mon, 19 Aug 2019 18:56:44 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Mon, 19 Aug 2019 20:55:59 +0200 Message-Id: <20190819185602.4267-14-mreitz@redhat.com> In-Reply-To: <20190819185602.4267-1-mreitz@redhat.com> References: <20190819185602.4267-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 19 Aug 2019 18:56:45 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 13/16] qcow2: Repair snapshot table with too many entries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-snapshot.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 366d9f574c..dac8a778e4 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -444,6 +444,14 @@ int coroutine_fn qcow2_check_read_snapshot_table(Block= DriverState *bs, s->snapshots_offset =3D be64_to_cpu(snapshot_table_pointer.snapshots_o= ffset); s->nb_snapshots =3D be32_to_cpu(snapshot_table_pointer.nb_snapshots); =20 + if (s->nb_snapshots > QCOW_MAX_SNAPSHOTS && (fix & BDRV_FIX_ERRORS)) { + fprintf(stderr, "Discarding %u overhanging snapshots\n", + s->nb_snapshots - QCOW_MAX_SNAPSHOTS); + + nb_clusters_reduced +=3D s->nb_snapshots - QCOW_MAX_SNAPSHOTS; + s->nb_snapshots =3D QCOW_MAX_SNAPSHOTS; + } + ret =3D qcow2_validate_table(bs, s->snapshots_offset, s->nb_snapshots, sizeof(QCowSnapshotHeader), sizeof(QCowSnapshotHeader) * QCOW_MAX_SNAPS= HOTS, @@ -452,6 +460,12 @@ int coroutine_fn qcow2_check_read_snapshot_table(Block= DriverState *bs, result->check_errors++; error_reportf_err(local_err, "ERROR "); =20 + if (s->nb_snapshots > QCOW_MAX_SNAPSHOTS) { + fprintf(stderr, "You can force-remove all %u overhanging snaps= hots " + "with qemu-img check -r all\n", + s->nb_snapshots - QCOW_MAX_SNAPSHOTS); + } + /* We did not read the snapshot table, so invalidate this informat= ion */ s->snapshots_offset =3D 0; s->nb_snapshots =3D 0; --=20 2.21.0