From nobody Tue Nov 11 20:50:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1566133600; cv=none; d=zoho.com; s=zohoarc; b=bGej8xnoEqXaEuDT+rD6pclfogVBfu1HhF+L8+YvrNd6F0dD3ufPnvEmi//B8JFkpF3qS73B8Fk9mUSbiQMNdM6PXb+ZlE0Jv/HM1z77zOKYKETsy2SQ19c4XLnk6Mz52NOydr3ZMPwXFTeU3e2NuqxIgB72M2x79Luh0smkUjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566133600; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=pJi31yXfLZ+Jcn/9PJPEPc3Uab17pqS3b4ToSg6B+z0=; b=OuVwlVqz5OY1My/WCEfJVwGR5JoeQfDy0IMIKvvPV1agyJr54qmXeHu5utADv/jwQ77azu+RNP2+uleC+hPUHKStuPiTK/YsyrnSTBxq9RO1khkrCxIr9uxyLsEVpAGHPeSRQSC+bmw2dSJ0zJk5KFVyOazcZ/28UdfTVvU4/1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156613360029338.25190102692261; Sun, 18 Aug 2019 06:06:40 -0700 (PDT) Received: from localhost ([::1]:41124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzKtE-0004Ha-9G for importer@patchew.org; Sun, 18 Aug 2019 09:06:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzInJ-0001Lt-2K for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzImA-0007D4-CJ for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:51:07 -0400 Received: from haasn.xyz ([78.46.187.166]:43508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzImA-0007A3-48 for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:51:06 -0400 Received: from haasn.xyz (unknown [10.30.0.2]) by haasn.xyz (Postfix) with ESMTP id C38AA401EE; Sun, 18 Aug 2019 12:50:59 +0200 (CEST) From: Niklas Haas To: qemu-devel@nongnu.org Date: Sun, 18 Aug 2019 12:50:38 +0200 Message-Id: <20190818105038.19520-1-qemu@haasn.xyz> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.46.187.166 X-Mailman-Approved-At: Sun, 18 Aug 2019 09:05:30 -0400 Subject: [Qemu-devel] [PATCH] input-linux: add shift+shift as a grab toggle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niklas Haas Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Niklas Haas We have ctrl-ctrl and alt-alt; why not shift-shift? That's my preferred grab binding, personally. Signed-off-by: Niklas Haas --- qapi/ui.json | 3 ++- ui/input-linux.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/qapi/ui.json b/qapi/ui.json index 59e412139a..e04525d8b4 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1025,7 +1025,8 @@ # ## { 'enum': 'GrabToggleKeys', - 'data': [ 'ctrl-ctrl', 'alt-alt', 'meta-meta', 'scrolllock', 'ctrl-scrol= llock' ] } + 'data': [ 'ctrl-ctrl', 'alt-alt', 'shift-shift','meta-meta', 'scrolllock= ', + 'ctrl-scrolllock' ] } =20 ## # @DisplayGTK: diff --git a/ui/input-linux.c b/ui/input-linux.c index 59456fe765..a7b280b25b 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -113,6 +113,10 @@ static bool input_linux_check_toggle(InputLinux *il) return il->keydown[KEY_LEFTALT] && il->keydown[KEY_RIGHTALT]; =20 + case GRAB_TOGGLE_KEYS_SHIFT_SHIFT: + return il->keydown[KEY_LEFTSHIFT] && + il->keydown[KEY_RIGHTSHIFT]; + case GRAB_TOGGLE_KEYS_META_META: return il->keydown[KEY_LEFTMETA] && il->keydown[KEY_RIGHTMETA]; --=20 2.21.0