From nobody Fri Dec 19 14:32:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1565962685; cv=none; d=zoho.com; s=zohoarc; b=num7OQBWrAOZS/7q+92BspzyNTV3yLNUCvQhHZ7UyPYYml3u4WYZftAtOZeIEC//xP74xawsln/nX13hoXuAx30Mc+W3gF1v2P0eInf4W8+DJZKYv0wXjxevzpGc/Bh5XcQnnFLwY990s0I1jaTWuiLpX1Qi+RT1KjZsKJprQLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565962685; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=iXcER1QiX/gthDXehyMfmgB8egDz7zaG/jAt+aS6K7o=; b=LXOI+LCxVU2tEryv+NN7tR2nlZG7bk7zcHKBpKfWGCwcO18b0dSOp+YNbAJekG14W2+VX6RqUEYKJe5qSD0ZNXjnuPh8Su2xcYtr5sbFPsaDBBc9RC9SJJfmFLkyEjR0aOfBLyyw4BtHexXqnz4Z5kaDL1It9ao7hwz7DspZz3Y= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565962685076219.82005911262024; Fri, 16 Aug 2019 06:38:05 -0700 (PDT) Received: from localhost ([::1]:56254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hycQd-0001UT-Hy for importer@patchew.org; Fri, 16 Aug 2019 09:38:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35463) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyc76-0003b2-5T for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyc74-0005oB-Ry for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:51 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:38473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyc74-0005nP-Li for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:50 -0400 Received: by mail-wm1-x344.google.com with SMTP id m125so4047500wmm.3 for ; Fri, 16 Aug 2019 06:17:50 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id 4sm8705796wro.78.2019.08.16.06.17.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 06:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=iXcER1QiX/gthDXehyMfmgB8egDz7zaG/jAt+aS6K7o=; b=uk7bgu0rYAEQIy4sYZAD1TRsD/NdEmm5gTIMpBV3JGHCKi/BDybAHO07rASq1aDoW2 hov769BM/YIOQ0J4av11ViS+6L04CtFZXJ6LaHL7ul8dMhrkfTXBXtBvENUrBzSfpLzH dG3sAQMvFC2l6hkCc4I0f6yvBruJl+lMpQZARZNO2A/14UzeuKOwr7EgYvTJDfzxHGn9 fVObpd2HBuAW8dNP4+6BxtNpMGPc4YLzfqh33TwXqsdACGTJZHAzznecYSsNpWatmi30 KFY6IMkveet8gfbK2siVkh73vnLvx2XRmrbgMUey0hzFOMkrcMXZy6Gk9l/O3pZKsD02 jbWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iXcER1QiX/gthDXehyMfmgB8egDz7zaG/jAt+aS6K7o=; b=lLf8d1shMhk3k1zUFKANPMNtW4FkPrZgrw0iPAWSPed2LE5NM2/KIb9/kSYVj12Kua lLIBn3/RGKXHKKofdfTnCoLLiERMec7qqxpeaCrqrEJCeZzQqV9ZcvskiSbWycHy/LGD Y09gxHSwws6Y88MlvqW6I++ZASOBLtKDJOKulcCCc3pabOBOVlvPfvizUzU3sOLW8MpX yIDI1OfF8aa8hPq2kz0TycVSp2p0rjfii17vrSQM19jdRFusL4id1BDum978VL6IyPyM 5sFkVvINfyFkWmdpOYfHLYfTSgMhr0qpS3JZqytBdbywvQOeTwctvGcBzqWgg4iN/d3b MgUw== X-Gm-Message-State: APjAAAWt/5oEr++H8HR6KSYyE32Uw7Kx7Vv3rik8UAh3876v2Ky+CXM3 xFqgW64NCDfxIMSIPDu5iJfgScVQYVJe+w== X-Google-Smtp-Source: APXvYqz5XQeNIMKbwIr44vq58RZ99TEO1t414G77y4Ftp5VFM+WDdaTXpU+r+4PQQF6wD9AacDMpBA== X-Received: by 2002:a05:600c:144:: with SMTP id w4mr7825583wmm.94.1565961469493; Fri, 16 Aug 2019 06:17:49 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 16 Aug 2019 14:17:15 +0100 Message-Id: <20190816131719.28244-26-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190816131719.28244-1-peter.maydell@linaro.org> References: <20190816131719.28244-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PULL 25/29] target/arm: Remove redundant shift tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Richard Henderson The immediate shift generator functions already test for, and eliminate, the case of a shift by zero. Signed-off-by: Richard Henderson Message-id: 20190808202616.13782-4-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9c3323509e1..ebc7c67f025 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8811,8 +8811,7 @@ static void disas_arm_insn(DisasContext *s, unsigned = int insn) shift =3D (insn >> 10) & 3; /* ??? In many cases it's not necessary to do a rotate, a shift is sufficient. */ - if (shift !=3D 0) - tcg_gen_rotri_i32(tmp, tmp, shift * 8); + tcg_gen_rotri_i32(tmp, tmp, shift * 8); op1 =3D (insn >> 20) & 7; switch (op1) { case 0: gen_sxtb16(tmp); break; @@ -9889,8 +9888,7 @@ static void disas_thumb2_insn(DisasContext *s, uint32= _t insn) shift =3D (insn >> 4) & 3; /* ??? In many cases it's not necessary to do a rotate, a shift is sufficient. */ - if (shift !=3D 0) - tcg_gen_rotri_i32(tmp, tmp, shift * 8); + tcg_gen_rotri_i32(tmp, tmp, shift * 8); op =3D (insn >> 20) & 7; switch (op) { case 0: gen_sxth(tmp); break; @@ -10617,11 +10615,10 @@ static void disas_thumb2_insn(DisasContext *s, ui= nt32_t insn) case 7: goto illegal_op; default: /* Saturate. */ - if (shift) { - if (op & 1) - tcg_gen_sari_i32(tmp, tmp, shift); - else - tcg_gen_shli_i32(tmp, tmp, shift); + if (op & 1) { + tcg_gen_sari_i32(tmp, tmp, shift); + } else { + tcg_gen_shli_i32(tmp, tmp, shift); } tmp2 =3D tcg_const_i32(imm); if (op & 4) { @@ -10812,9 +10809,7 @@ static void disas_thumb2_insn(DisasContext *s, uint= 32_t insn) goto illegal_op; } tmp =3D load_reg(s, rm); - if (shift) { - tcg_gen_shli_i32(tmp, tmp, shift); - } + tcg_gen_shli_i32(tmp, tmp, shift); tcg_gen_add_i32(addr, addr, tmp); tcg_temp_free_i32(tmp); break; --=20 2.20.1