From nobody Fri Dec 19 15:55:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1565961885; cv=none; d=zoho.com; s=zohoarc; b=Tos3CNvWJAjV4nWgm5/rk9GxtkP0r6rUGp5U7/WeVCELG2BDZm8HWpWgtph+KD5bzWujyxBlnLLFVp6FjQr5BF/LSxoNLEbNkU9NJ37/ErwKjI3cd+ZUy0dYrMERZXZuNaJWoMbWwvlnusukqZtlJnQFQXNbujiX/a4Qi7fSGUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565961885; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=a4P1+EnRZyW9kd5p9YYGOpI9oI6W9VDq86e7pkr27ak=; b=c6HpVcElvoBO3WPX/GFpTmnqeD+HTZ9GYvXYsDEBQJC3hLtXyvMI+KG/hsC+lYUcAQWGrWs6xr8xVG2nqo9NiMpGYMt5w1/RkYAClsBcH8cMqVTHe/mks/mpyA1i1Q+1DDqQKwZyboDZpaaduCXAK6jhKWw0t56kmZcI/p/+5KM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565961885731950.0811723368217; Fri, 16 Aug 2019 06:24:45 -0700 (PDT) Received: from localhost ([::1]:56022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hycDk-0003mA-90 for importer@patchew.org; Fri, 16 Aug 2019 09:24:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35371) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyc6z-0003T1-CO for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyc6y-0005gB-CQ for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:45 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:36957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyc6x-0005cp-55 for qemu-devel@nongnu.org; Fri, 16 Aug 2019 09:17:43 -0400 Received: by mail-wm1-x329.google.com with SMTP id z23so4058154wmf.2 for ; Fri, 16 Aug 2019 06:17:42 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id 4sm8705796wro.78.2019.08.16.06.17.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 06:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=a4P1+EnRZyW9kd5p9YYGOpI9oI6W9VDq86e7pkr27ak=; b=G2Nw5zeFoIzsnJttWJHaYUHYl1tpxAzkyML5SeLEL/OwkAqpBcSnTXSA/+Urpx9Lo9 0mrHt1hbvXP4VKYITFqZzX2Y2XKndJLKNwGssGBq65ls4by+gcW2nNTAjn/4pP4Ou2kM iwuIhNgwQDiz33DaqTdKlItkJ0HBd/nro1p7VzTj25xWpdcIKYMj6CD6T1vtfYxub1Gb axn7NZlTNa7RNSqP3wtxkZCuOyvDqQ2j0fBP0Uq+gVRJxMy5Y15VRcoIyR28TO+OXpTV kuGCybIUK0pElDyUkj+03NaqHu6YPNyFUd8LYKJklV+iXZlXwQymltQPAvSzaZv4NA3D I5KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a4P1+EnRZyW9kd5p9YYGOpI9oI6W9VDq86e7pkr27ak=; b=J7x/rE97Dl/9jow2/ShAQ/0ECZ1FnCg3JIyMF46QWo8aEdQhvK13MiiSR9CQ+NKUL/ oAPipw3M0jC9UCkd4MqdB6tOqWKQ0WNzDSgvHMrC5TQSiPI7umoMNOKaO+nTG0Eduz5/ FgrV3Es0bZMVr55sV2Al4HfzZBMARjhRNKK1ZOXqFrWphBy2GvOPhDKtUPo6vYrO86kO uMv7A9zqeZ+5jy+Auc7ilmgcLoZ/y05z3VCllGCRc7LsaaCY05y/YqxXScXI5BUTt1cC KRCbYBrbx/mfToizDH1cdSz8tSRrVNN2qcz/CCYYM35q/urYQxszfew74JH47P4lb4/U hj9w== X-Gm-Message-State: APjAAAViJG7PPfvfDyN3AN9kxjqWNnj7ZllzD9WzG2rznpy/WrHoJuUq 3vTT76CowUXngX12IgmXT9H+tfi4kTznvw== X-Google-Smtp-Source: APXvYqwyW2syss7CoBhVEv+TTcp+Qn/DScUgr2npA+VnVnvKdc7VrhxJV9wucUWrxYA2gpOurjjXvQ== X-Received: by 2002:a1c:a446:: with SMTP id n67mr7171016wme.56.1565961461599; Fri, 16 Aug 2019 06:17:41 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 16 Aug 2019 14:17:09 +0100 Message-Id: <20190816131719.28244-20-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190816131719.28244-1-peter.maydell@linaro.org> References: <20190816131719.28244-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 Subject: [Qemu-devel] [PULL 19/29] target/arm/helper: zcr: Add build bug next to value range assumption X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Andrew Jones The current implementation of ZCR_ELx matches the architecture, only implementing the lower four bits, with the rest RAZ/WI. This puts a strict limit on ARM_MAX_VQ of 16. Make sure we don't let ARM_MAX_VQ grow without a corresponding update here. Suggested-by: Dave Martin Signed-off-by: Andrew Jones Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Signed-off-by: Peter Maydell --- target/arm/helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 24806c16ca2..2fd504ea7a1 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -5300,6 +5300,7 @@ static void zcr_write(CPUARMState *env, const ARMCPRe= gInfo *ri, int new_len; =20 /* Bits other than [3:0] are RAZ/WI. */ + QEMU_BUILD_BUG_ON(ARM_MAX_VQ > 16); raw_write(env, ri, value & 0xf); =20 /* --=20 2.20.1