From nobody Sun Feb 8 23:18:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565949414; cv=none; d=zoho.com; s=zohoarc; b=Q7FqzH9cWy/uZBab4aaQIinSBV4U5jZaD5zNeTUlaOx65Lao0oJPsb5R+RFddCCcGeVu2RoBhkKhkjY61TPOstVHBnDnBmieMjPKUm4CddQUU3I9613ynOYU2md8G8lQLKQtKAde0TbPEaAe/HL+rPWCTiBh6YKDt0vhEqb88Hc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565949414; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=b1JRNzX9/z8YhsvOxDw+/hM5rhW1R/nRLWz4VKmZe7U=; b=MJHfA1RbCmi2NKY7aMuCn6J5Ro+N0gOyxStdtTdh5CxHhBx5oyaZg8+yG8cQ28YIm8jLyxdV6z45xwowXL1QcyiN7o+wGs3KkRlWdsg8/1l83Qi/v1HWUdErVX1aTb8u0bAM7vSYRFDPDqHuAlq7vyGKBcJtOpegYlO5cy2btsc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565949414826237.40648876247565; Fri, 16 Aug 2019 02:56:54 -0700 (PDT) Received: from localhost ([::1]:52670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyYyT-0001dc-U3 for importer@patchew.org; Fri, 16 Aug 2019 05:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33980) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyYxY-00015Y-NO for qemu-devel@nongnu.org; Fri, 16 Aug 2019 05:55:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyYxX-00052F-RA for qemu-devel@nongnu.org; Fri, 16 Aug 2019 05:55:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44916) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyYxV-000514-DI; Fri, 16 Aug 2019 05:55:45 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D1714ACA7; Fri, 16 Aug 2019 09:55:44 +0000 (UTC) Received: from localhost.localdomain.com (dhcp-200-226.str.redhat.com [10.33.200.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D14860CD0; Fri, 16 Aug 2019 09:55:43 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Fri, 16 Aug 2019 11:55:28 +0200 Message-Id: <20190816095528.16224-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 16 Aug 2019 09:55:44 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] file-posix: Fix has_write_zeroes after NO_FALLBACK X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If QEMU_AIO_NO_FALLBACK is given, we always return failure and don't even try to use the BLKZEROOUT ioctl. In this failure case, we shouldn't disable has_write_zeroes because we didn't learn anything about the ioctl. The next request might not set QEMU_AIO_NO_FALLBACK and we can still use the ioctl then. Reported-by: Eric Blake Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/file-posix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index b8b4dad553..e927f9d3c3 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1555,12 +1555,12 @@ static ssize_t handle_aiocb_write_zeroes_block(RawP= osixAIOData *aiocb) } while (errno =3D=3D EINTR); =20 ret =3D translate_err(-errno); + if (ret =3D=3D -ENOTSUP) { + s->has_write_zeroes =3D false; + } } #endif =20 - if (ret =3D=3D -ENOTSUP) { - s->has_write_zeroes =3D false; - } return ret; } =20 --=20 2.20.1