From nobody Tue Nov 11 21:18:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565894710; cv=none; d=zoho.com; s=zohoarc; b=ba3oXf0ZboTqlHQzAdQBVrdPncVdp1rQGsHQISO7weIZ+MU0oGk9UWGPLsusfip8CtRvjWQDMsRxic7xK9B2i54GOkxtrqbcKBVgqfkv4MbaW5zDCktWc2tIeLT+06brNCvE/zRRtiwx6JLtEosVja+mh7GBzVxMCuYAiH1/FYk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565894710; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=IlmCiYf0kSCQFFcgFJs3EoUsvL2JFa1WyMJLyinvpj8=; b=jf3ZjMSVmVpiLqXqCILOsjDwj/w1PIOujKPLdtIzEU6WJcv8JgY8/5qKpoAGS4JpfM9A/HVTkP3Kad1e41ZFTLolt5idL0m87estAWkNsIcoBas848oYyC6TWiu7EkXZIETpywtLk8g8NlCsjfvVNsYMSdzeNk1sdr1qnjxiQzQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156589471092558.11394523840829; Thu, 15 Aug 2019 11:45:10 -0700 (PDT) Received: from localhost ([::1]:46224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyKkH-0008D8-KK for importer@patchew.org; Thu, 15 Aug 2019 14:45:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38426) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyKde-0000p5-03 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyKdb-0000gY-L5 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57070) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyKdb-0000g0-G9 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C935A8535C; Thu, 15 Aug 2019 18:38:14 +0000 (UTC) Received: from localhost (ovpn-116-32.gru2.redhat.com [10.97.116.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45CEB600CD; Thu, 15 Aug 2019 18:38:14 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 15:38:02 -0300 Message-Id: <20190815183803.13346-3-ehabkost@redhat.com> In-Reply-To: <20190815183803.13346-1-ehabkost@redhat.com> References: <20190815183803.13346-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 15 Aug 2019 18:38:14 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Krempa , Eduardo Habkost , Like Xu , "Michael S. Tsirkin" , Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The error message when die-id is omitted doesn't make sense: $ qemu-system-x86_64 -smp 1,sockets=3D6,maxcpus=3D6 \ -device qemu64-x86_64-cpu,socket-id=3D1,core-id=3D0,thread-id=3D0 qemu-system-x86_64: -device qemu64-x86_64-cpu,socket-id=3D1,core-id=3D0,t= hread-id=3D0: \ Invalid CPU die-id: 4294967295 must be in range 0:0 Fix it, so it will now read: qemu-system-x86_64: -device qemu64-x86_64-cpu,socket-id=3D1,core-id=3D0,t= hread-id=3D0: \ CPU die-id is not set Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Reviewed-by: Vanderson M. do Rosario --- hw/i386/pc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 24b03bb49c..fb4ac5ca90 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -2410,6 +2410,10 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_= dev, error_setg(errp, "Invalid CPU socket-id: %u must be in range 0= :%u", cpu->socket_id, max_socket); return; + } + if (cpu->die_id < 0) { + error_setg(errp, "CPU die-id is not set"); + return; } else if (cpu->die_id > pcms->smp_dies - 1) { error_setg(errp, "Invalid CPU die-id: %u must be in range 0:%u= ", cpu->die_id, pcms->smp_dies - 1); --=20 2.21.0