From nobody Tue Nov 11 21:15:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565894896; cv=none; d=zoho.com; s=zohoarc; b=MhmQub00BX73j4Y7mD+0g+ppN9RPbS4WZ/1e52qQUB+ZSeewIM++1IgmeUmVGNWEMiXxd4NI1XHZji8P5T4BnwtBcoj3Uk8/2GpOK1HDHUjjbN68eoMJZB6si0JDk87FHp2KGHuK24U87Jnuho9V6HPC4NbkReyte0hLZUg7Fn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565894896; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=AvYuNv3HrsOKGT6WYTxjNHT3OQNscpNcdwxXZIIlmnY=; b=YLlUjG0GGgmPesFEX/aAaJ4K+rnNutuxwzuJZu6d4ovdmER9jiiceeNip48G44WuNM48q36vOir/wA79OE4CXCxlZQffG4LaTPSyow+8jGtYwGCd27yp3RONpVY0O4HHK0XNK/HxKLhi0Fct5Le0jAAHBD8VrQXnzaV1cgt6TdA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565894896521796.7805563101147; Thu, 15 Aug 2019 11:48:16 -0700 (PDT) Received: from localhost ([::1]:46270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyKnH-0003EG-Fa for importer@patchew.org; Thu, 15 Aug 2019 14:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38409) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyKdb-0000lQ-Lb for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyKdZ-0000ei-C3 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41630) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyKdZ-0000eF-6t for qemu-devel@nongnu.org; Thu, 15 Aug 2019 14:38:13 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73EED315C013; Thu, 15 Aug 2019 18:38:12 +0000 (UTC) Received: from localhost (ovpn-116-32.gru2.redhat.com [10.97.116.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91EE0600CD; Thu, 15 Aug 2019 18:38:09 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 15:38:01 -0300 Message-Id: <20190815183803.13346-2-ehabkost@redhat.com> In-Reply-To: <20190815183803.13346-1-ehabkost@redhat.com> References: <20190815183803.13346-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 15 Aug 2019 18:38:12 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Krempa , Eduardo Habkost , Like Xu , "Michael S. Tsirkin" , Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The error message for die-id range validation is incorrect. Example: $ qemu-system-x86_64 -smp 1,sockets=3D6,maxcpus=3D6 \ -device qemu64-x86_64-cpu,socket-id=3D1,die-id=3D1,core-id=3D0,thread-i= d=3D0 qemu-system-x86_64: -device qemu64-x86_64-cpu,socket-id=3D1,die-id=3D1,co= re-id=3D0,thread-id=3D0: \ Invalid CPU die-id: 1 must be in range 0:5 The actual range for die-id in this example is 0:0. Fix the error message to use smp_dies and print the correct range. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Reviewed-by: Vanderson M. do Rosario --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 549c437050..24b03bb49c 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -2412,7 +2412,7 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_d= ev, return; } else if (cpu->die_id > pcms->smp_dies - 1) { error_setg(errp, "Invalid CPU die-id: %u must be in range 0:%u= ", - cpu->die_id, max_socket); + cpu->die_id, pcms->smp_dies - 1); return; } if (cpu->core_id < 0) { --=20 2.21.0