From nobody Mon Feb 9 08:29:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565892333; cv=none; d=zoho.com; s=zohoarc; b=RpOE92gfVlYiObTpR32kQTORLkrIIbRjHSIqC35OCiKcAslToCD0sn6Hi+rcF4auAHHoKJ/4BheBj+t4VuzvBezjrMZA0Ht/5SIZV4KFXgQnYMEkPa1GWqG/X1FcoL2JbFGYyF3ncrdvFes7vuxi24qEwtAzM0Em81agg/x9pqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565892333; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=/05z9LXJxSiFl2Wkh/G6SGKJ7hVGJivilvpTiM1VZqE=; b=jtaeQAHeGOexyH7f38LsqEL88HCpdn/MKj28wKHk8o+g7psgVAKx/rGrujZimhwcLWWknoQapVZllO774lnR0VLVe9TkmOJg47D2RgkcYFNhOHSODoZ8U8CuPVDie64Hen7fRr0Ri0dv12qiTJDuNpHyj2Y+UB2rbaXNAFTXV4g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565892333369689.4917983616031; Thu, 15 Aug 2019 11:05:33 -0700 (PDT) Received: from localhost ([::1]:45762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyK7w-0004B8-6P for importer@patchew.org; Thu, 15 Aug 2019 14:05:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32818) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyK2R-00008w-8O for qemu-devel@nongnu.org; Thu, 15 Aug 2019 13:59:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyK2P-0001uj-1h for qemu-devel@nongnu.org; Thu, 15 Aug 2019 13:59:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyK2N-0001ov-He for qemu-devel@nongnu.org; Thu, 15 Aug 2019 13:59:48 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA2F3300BCE9; Thu, 15 Aug 2019 17:59:46 +0000 (UTC) Received: from thuth.com (ovpn-116-65.ams2.redhat.com [10.36.116.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 038D417CDF; Thu, 15 Aug 2019 17:59:44 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 19:59:20 +0200 Message-Id: <20190815175922.3475-8-thuth@redhat.com> In-Reply-To: <20190815175922.3475-1-thuth@redhat.com> References: <20190815175922.3475-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 15 Aug 2019 17:59:46 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 7/9] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The generic libqtest library functions should not use functions that require the global_qtest variable. Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Message-Id: <20190813093047.27948-5-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/libqtest.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3e9245d4c9..d1aead30ed 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1189,9 +1189,10 @@ void qtest_cb_for_every_machine(void (*cb)(const cha= r *machine), QObject *qobj; QString *qstr; const char *mname; + QTestState *qts; =20 - qtest_start("-machine none"); - response =3D qmp("{ 'execute': 'query-machines' }"); + qts =3D qtest_init("-machine none"); + response =3D qtest_qmp(qts, "{ 'execute': 'query-machines' }"); g_assert(response); list =3D qdict_get_qlist(response, "return"); g_assert(list); @@ -1209,7 +1210,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char= *machine), } } =20 - qtest_end(); + qtest_quit(qts); qobject_unref(response); } =20 --=20 2.18.1