From nobody Tue Nov 11 21:04:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565887459; cv=none; d=zoho.com; s=zohoarc; b=O6LQREivrwf7XpzdSmjjQrtNYhe9KsxeamYJYC1zizKKj59T54N0iaoOpJqaAIS+YaPVXkqYFmZIgfNA6shvtJdIgzwlLhwEvtg4bZDX4dsljdgb3xuT3vXHtkAQGq8YvnEeDXmRAb25Bbnuu13bgqXM6FPB8i6L8X55SIZFBKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565887459; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=bom9XXBm+czF7aBj8ZiF8JTA4XRFOr08QSsRFUfJtCs=; b=V7qPfqN524yoyqnaHXki+/Fsn7OlU1KfktWvZo9BX2OEX8pT5e3v093wBT46LV4Rgzi9bkEX2CY8uZD8G+Hk8i/wrXwpikzy851PgOIL+qwmV5BN0u/GcXD2EWK4FT6xNHZPhNzFfQBnNYstv9NCLr5sLYmC266y/6heN5ayTwk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565887459354402.88523852465255; Thu, 15 Aug 2019 09:44:19 -0700 (PDT) Received: from localhost ([::1]:44366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyIrJ-0002vQ-GH for importer@patchew.org; Thu, 15 Aug 2019 12:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47220) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyIit-0001aO-Td for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyIip-0002GF-8l for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51096) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyIip-0002Fy-3Q for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:31 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F9C58666C; Thu, 15 Aug 2019 16:35:30 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-19.ams2.redhat.com [10.36.117.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id E868160F8C; Thu, 15 Aug 2019 16:35:28 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 17:34:39 +0100 Message-Id: <20190815163504.18937-9-dgilbert@redhat.com> In-Reply-To: <20190815163504.18937-1-dgilbert@redhat.com> References: <20190815163504.18937-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 15 Aug 2019 16:35:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 08/33] migration/postcopy: do_fixup is true when host_offset is non-zero X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, yury-kotov@yandex-team.ru, richardw.yang@linux.intel.com, marcandre.lureau@redhat.com, ivanren@tencent.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wei Yang This means it is not necessary to spare an extra variable to hold this condition. Use host_offset directly is fine. Signed-off-by: Wei Yang Message-Id: <20190710050814.31344-3-richardw.yang@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index da399f2c8a..255f289bbb 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2962,7 +2962,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, } =20 while (run_start < pages) { - bool do_fixup =3D false; unsigned long fixup_start_addr; unsigned long host_offset; =20 @@ -2972,7 +2971,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, */ host_offset =3D run_start % host_ratio; if (host_offset) { - do_fixup =3D true; fixup_start_addr =3D run_start - host_offset; /* * This host page has gone, the next loop iteration starts @@ -2994,7 +2992,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, */ host_offset =3D run_end % host_ratio; if (host_offset) { - do_fixup =3D true; fixup_start_addr =3D run_end - host_offset; /* * This host page has gone, the next loop iteration starts @@ -3010,7 +3007,7 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, } } =20 - if (do_fixup) { + if (host_offset) { unsigned long page; =20 /* Tell the destination to discard this page */ --=20 2.21.0