From nobody Tue Nov 11 21:05:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565887391; cv=none; d=zoho.com; s=zohoarc; b=V/8ZXsudPWt8v9BwyWLA0cbLUP2mRl6+oYQ07kZNRAkReAs3YR1eF6fikkyVDQj7X8EKNZzwrtftwIB6H3vsgRu5o8sFVbv1AvBikBCKREYVzm1uyq0XKxwuODeGA7t6BU9W/nBvpiT4gUj7OzH5yvK4G4KF8aoGZCihHj5b8Ho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565887391; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=HRSnGZm0jT0o18ihaYjqNhygbX6Vw20SQJr8vvaSRNw=; b=JhInWXo2bXLho1qCCa9bu7zqKqWcNQoUndo7RTN66dYnvBTW16ekEGKvmfcq8W/dRKEwOnM84FRJ4HRyO9E9Rzdb1g6PwisyZiHvyrNuIWFrPMG2xUeuazF6zeC7IjPeNtO1zEObFS7/FLmvgq1sE4UEc+IigGb1knzEeOmrE4c= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156588739155814.259818980505656; Thu, 15 Aug 2019 09:43:11 -0700 (PDT) Received: from localhost ([::1]:44362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyIq9-0001j5-TE for importer@patchew.org; Thu, 15 Aug 2019 12:43:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47169) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyIim-0001PL-TG for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyIij-0002CL-2X for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45580) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyIii-0002AS-Tc for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CC547FDCA; Thu, 15 Aug 2019 16:35:24 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-19.ams2.redhat.com [10.36.117.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id B61013737; Thu, 15 Aug 2019 16:35:22 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 17:34:37 +0100 Message-Id: <20190815163504.18937-7-dgilbert@redhat.com> In-Reply-To: <20190815163504.18937-1-dgilbert@redhat.com> References: <20190815163504.18937-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 15 Aug 2019 16:35:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 06/33] migration/postcopy: discard_length must not be 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, yury-kotov@yandex-team.ru, richardw.yang@linux.intel.com, marcandre.lureau@redhat.com, ivanren@tencent.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wei Yang Since we break the loop when there is no more page to discard, we are sure the following process would find some page to discard. It is not necessary to check it again. Signed-off-by: Wei Yang Message-Id: <20190627020822.15485-4-richardw.yang@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 8a97dadec4..4bb5e24459 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2877,9 +2877,7 @@ static int postcopy_send_discard_bm_ram(MigrationStat= e *ms, } else { discard_length =3D zero - one; } - if (discard_length) { - postcopy_discard_send_range(ms, pds, one, discard_length); - } + postcopy_discard_send_range(ms, pds, one, discard_length); current =3D one + discard_length; } =20 --=20 2.21.0