From nobody Tue Nov 11 21:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565887179; cv=none; d=zoho.com; s=zohoarc; b=ag2FdzSNRIz8tDW/DWaMvMYUgH91tJNFkgarkHUQv4fHVqiEC9nFPg9fWQjYw7rkztV7J8FG9sOkA+ELuJiOuD7Kmit6ixXGyNIgZaWZYwBw7rXvvddCKHRelkuE7V7PK9hw+hnSqHQzhok5wKv35LjNoIkTdqwYoclPJSb411E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565887179; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wkR3dpBN3LmDQQQh69XAQA6xOwiAoBxWqftsZW3+LSU=; b=Yuv3imIZnYoM8OgjsAGweQdJmgCEenuez76xMNwZfou1hbDSnkwwuNKHbQVt8mvTmKdQsJyRTzxMx055sVsPwl8kZokdgUHA0m98uqVdhW95nrpK+CwgkU0pPXrglM5eR8KRIHsBTovPV/QTO9TCR0TF9qRRS+Aj4x9WeGVHuxo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565887179474876.1029362379685; Thu, 15 Aug 2019 09:39:39 -0700 (PDT) Received: from localhost ([::1]:44330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyImn-0006b4-U5 for importer@patchew.org; Thu, 15 Aug 2019 12:39:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyIik-0001Mq-G5 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyIif-00027V-Fd for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47944) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyIif-00027C-AA for qemu-devel@nongnu.org; Thu, 15 Aug 2019 12:35:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D4D03084242; Thu, 15 Aug 2019 16:35:20 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-19.ams2.redhat.com [10.36.117.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E3883737; Thu, 15 Aug 2019 16:35:18 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org Date: Thu, 15 Aug 2019 17:34:35 +0100 Message-Id: <20190815163504.18937-5-dgilbert@redhat.com> In-Reply-To: <20190815163504.18937-1-dgilbert@redhat.com> References: <20190815163504.18937-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 15 Aug 2019 16:35:20 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 04/33] migration/postcopy: the valid condition is one less then end X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, yury-kotov@yandex-team.ru, richardw.yang@linux.intel.com, marcandre.lureau@redhat.com, ivanren@tencent.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wei Yang If one equals end, it means we have gone through the whole bitmap. Use a more restrict check to skip a unnecessary condition. Signed-off-by: Wei Yang Message-Id: <20190627020822.15485-2-richardw.yang@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 889148dd84..68bc11c9e7 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2865,7 +2865,7 @@ static int postcopy_send_discard_bm_ram(MigrationStat= e *ms, for (current =3D 0; current < end; ) { unsigned long one =3D find_next_bit(unsentmap, end, current); =20 - if (one <=3D end) { + if (one < end) { unsigned long zero =3D find_next_zero_bit(unsentmap, end, one = + 1); unsigned long discard_length; =20 --=20 2.21.0