From nobody Wed Dec 17 05:58:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1565835480; cv=none; d=zoho.com; s=zohoarc; b=oLSVPYo/G3SGkc3KAIH5ppPxCy5NKrAa0f5j6vtQ7ZEs3a7RPP8wN9H7RnZIzfOq1afOGT0orl89EboFszmDSrdurqCmSqV9Ss0j3LUZvG4wgGtBQuBmScY71gsnhM4BvAnLllIuRl/eXjEB/jbQsCh0Hj4BQDdCKV+9dqCYQ2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565835480; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aji6f42Pqo1laNwakKXwsr+VmwLnCcurcKsMvdCVjcw=; b=P3STuCHYEsvr5V1F/7Yl4reMENs90XiQDzq+FT2cigehxrtwiYlp4WcrIH93TH6rtU06Y4d4sxbvPjcmWHQcoXdUyWDwmbeak2ofoJKLZkabvihf2EJIMISuRv+NrHFpLtUzuBBs454WfXe6uFQMEsoMr9FzzE56ctMiyouSe7I= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565835480254580.9771112129665; Wed, 14 Aug 2019 19:18:00 -0700 (PDT) Received: from localhost ([::1]:37414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy5Kr-0006gY-ON for importer@patchew.org; Wed, 14 Aug 2019 22:17:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46865) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy5DX-0006Ba-Aj for qemu-devel@nongnu.org; Wed, 14 Aug 2019 22:10:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hy5DV-0008Vg-8U for qemu-devel@nongnu.org; Wed, 14 Aug 2019 22:10:19 -0400 Received: from mail-yb1-xb42.google.com ([2607:f8b0:4864:20::b42]:45961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hy5DV-0008S5-4F for qemu-devel@nongnu.org; Wed, 14 Aug 2019 22:10:17 -0400 Received: by mail-yb1-xb42.google.com with SMTP id u32so388382ybi.12 for ; Wed, 14 Aug 2019 19:10:15 -0700 (PDT) Received: from dionysus.attlocal.net ([2601:c0:c67f:e390:8a9a:e33f:caf8:f018]) by smtp.gmail.com with ESMTPSA id j3sm374882ywk.21.2019.08.14.19.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 19:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aji6f42Pqo1laNwakKXwsr+VmwLnCcurcKsMvdCVjcw=; b=ZkuDXAAqe9iGdX+lqbUGSqoU6JpHSBfNxV8J8llQJHt7/UD9CduwzV4ITo9iCImT7M gdwnL7mHSag65jlGZ5rLSj3l5MGeXQv6yatdK7Bth/kkXZ93HBT1p72lXYsRE/h3SmRp hI93KcOHzxvFA4l9GgeTywWRUz6jjr6RGuQXgRytodmbrtrgv7ZndFc24VgWmy4kZQbw NoEidRUyXFRP84/uEEEL7QaiKOIyGsHDgWgBGeSQfVa4fFZRKqiResNrzdA1OcoZnIj3 87mQaI0LRMfY/Wx7/4gmiJiTdY9RWIwGP6h8BrJ+7FUIQrX3GbBqbMIx9d5lYL89Gn1k 3c9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aji6f42Pqo1laNwakKXwsr+VmwLnCcurcKsMvdCVjcw=; b=IzQc6AS30Tw0LkjPBCzeXYk4ezNG7KhNdF1gW9OZkMUQUOCT7nsNoTrPsxRLP8ux6X +8m7eXEcO0x0jdI40+DKvvqwpOW6/cXuNDi021RKi61cWSY31U+Azpq3FgIO+mTxxs66 RKYnbRVT3GaD/VyTZJ4IqzMqZOHeEjN0itr833JcqPrRysch+Sc4HInJZpBHoALLBKtk LhwiBMNYVjeuBe1+ASy6GrCrlySPmaU+rQ44IfujDTrLQ8hyl0tT3EE2uxdVQ2TPKdpI krLPafZ/DiysvQ6qIvU9ez95ABGtd70Dhi1ML+CYY2pawdWAJeLAQAvuI5RYDIkIfSwy nfFw== X-Gm-Message-State: APjAAAXK6WkhAN8Ztd6NWevgeX4EQZXiUyuOfojxPZ48oANt4JgVLBYB NRduXC3U31teVCGJQAs7iJ9eoDW4 X-Google-Smtp-Source: APXvYqzBy5nDIj0GpEbjrj9z6rx6ql0Xew8ZwlXsw3Rn3HBj/1nQzgoas+xDtK/vF6c6c9iGnUDCLQ== X-Received: by 2002:a5b:e87:: with SMTP id z7mr1918014ybr.5.1565835015043; Wed, 14 Aug 2019 19:10:15 -0700 (PDT) From: Jan Bobek To: qemu-devel@nongnu.org Date: Wed, 14 Aug 2019 22:09:04 -0400 Message-Id: <20190815020928.9679-23-jan.bobek@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190815020928.9679-1-jan.bobek@gmail.com> References: <20190815020928.9679-1-jan.bobek@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b42 Subject: [Qemu-devel] [RFC PATCH v3 22/46] target/i386: introduce operands for decoding modrm fields X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Bobek , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The old code uses bitshifts and bitwise-and all over the place for decoding ModR/M fields. Avoid doing that by introducing proper decoding operands. Signed-off-by: Jan Bobek --- target/i386/translate.c | 62 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/target/i386/translate.c b/target/i386/translate.c index 25c25a30fb..e4515e81df 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -4760,6 +4760,68 @@ INSNOP_FINALIZE(modrm) { } =20 +/* + * modrm_mod + * + * Operand whose value is the MOD field of the ModR/M byte. + */ +typedef int insnop_arg_t(modrm_mod); +typedef struct {} insnop_ctxt_t(modrm_mod); + +INSNOP_INIT(modrm_mod) +{ + return 0; +} +INSNOP_PREPARE(modrm_mod) +{ + return (modrm >> 6) & 3; +} +INSNOP_FINALIZE(modrm_mod) +{ +} + +/* + * modrm_reg + * + * Operand whose value is the REG field of the ModR/M byte, extended + * with the REX.R bit if REX prefix is present. + */ +typedef int insnop_arg_t(modrm_reg); +typedef struct {} insnop_ctxt_t(modrm_reg); + +INSNOP_INIT(modrm_reg) +{ + return 0; +} +INSNOP_PREPARE(modrm_reg) +{ + return ((modrm >> 3) & 7) | REX_R(s); +} +INSNOP_FINALIZE(modrm_reg) +{ +} + +/* + * modrm_rm + * + * Operand whose value is the RM field of the ModR/M byte, extended + * with the REX.B bit if REX prefix is present. + */ +typedef int insnop_arg_t(modrm_rm); +typedef struct {} insnop_ctxt_t(modrm_rm); + +INSNOP_INIT(modrm_rm) +{ + return 0; +} +INSNOP_PREPARE(modrm_rm) +{ + return (modrm & 7) | REX_B(s); +} +INSNOP_FINALIZE(modrm_rm) +{ +} + static void gen_sse_ng(CPUX86State *env, DisasContext *s, int b) { enum { --=20 2.20.1