[Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

Rashmica Gupta posted 3 patches 1 week ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test asan passed
Test docker-clang@ubuntu failed
Test checkpatch passed
Test s390x failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190814071433.22243-1-rashmica.g@gmail.com
Maintainers: Joel Stanley <joel@jms.id.au>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@aj.id.au>, "Cédric Le Goater" <clg@kaod.org>
hw/arm/aspeed_soc.c           |   17 +
hw/gpio/Makefile.objs         |    1 +
hw/gpio/aspeed_gpio.c         | 1054 +++++++++++++++++++++++++++++++++
include/hw/arm/aspeed_soc.h   |    3 +
include/hw/gpio/aspeed_gpio.h |  107 ++++
slirp                         |    2 +-
6 files changed, 1183 insertions(+), 1 deletion(-)
create mode 100644 hw/gpio/aspeed_gpio.c
create mode 100644 include/hw/gpio/aspeed_gpio.h

[Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

Posted by Rashmica Gupta 1 week ago
v4:
- proper interupt handling thanks to Andrew
- switch statements for reading and writing suggested by Peter
- some small cleanups suggested by Alexey

v3:
- didn't have each gpio set up as an irq 
- now can't access set AC on ast2400 (only exists on ast2500)
- added ast2600 implementation (patch 3)
- renamed a couple of variables for clarity

v2: Addressed Andrew's feedback, added debounce regs, renamed get/set to
read/write to minimise confusion with a 'set' of registers.

Rashmica Gupta (3):
  hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500
  aspeed: add a GPIO controller to the SoC
  hw/gpio: Add in AST2600 specific implementation

 hw/arm/aspeed_soc.c           |   17 +
 hw/gpio/Makefile.objs         |    1 +
 hw/gpio/aspeed_gpio.c         | 1054 +++++++++++++++++++++++++++++++++
 include/hw/arm/aspeed_soc.h   |    3 +
 include/hw/gpio/aspeed_gpio.h |  107 ++++
 slirp                         |    2 +-
 6 files changed, 1183 insertions(+), 1 deletion(-)
 create mode 100644 hw/gpio/aspeed_gpio.c
 create mode 100644 include/hw/gpio/aspeed_gpio.h

-- 
2.20.1


Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

Posted by no-reply@patchew.org 1 week ago
Patchew URL: https://patchew.org/QEMU/20190814071433.22243-1-rashmica.g@gmail.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

  CC      arm-softmmu/hw/gpio/aspeed_gpio.o
  CC      alpha-softmmu/hw/virtio/vhost-user-blk-pci.o
  CC      aarch64-softmmu/tcg/tcg-op-vec.o
/var/tmp/patchew-tester-tmp-by4iq4ex/src/hw/gpio/aspeed_gpio.c:837:6: error: ‘AspeedGPIOController’ {aka ‘const struct AspeedGPIOController’} has no member named ‘mem_size’
  837 |     .mem_size       = GPIO_3_6V_MEM_SIZE,
      |      ^~~~~~~~
/var/tmp/patchew-tester-tmp-by4iq4ex/src/hw/gpio/aspeed_gpio.c:844:6: error: ‘AspeedGPIOController’ {aka ‘const struct AspeedGPIOController’} has no member named ‘mem_size’
  844 |     .mem_size       = GPIO_1_8V_MEM_SIZE,
      |      ^~~~~~~~
make[1]: *** [/var/tmp/patchew-tester-tmp-by4iq4ex/src/rules.mak:69: hw/gpio/aspeed_gpio.o] Error 1
---
  CC      aarch64-softmmu/hw/gpio/bcm2835_gpio.o
  CC      aarch64-softmmu/hw/gpio/nrf51_gpio.o
  CC      aarch64-softmmu/hw/gpio/aspeed_gpio.o
/var/tmp/patchew-tester-tmp-by4iq4ex/src/hw/gpio/aspeed_gpio.c:837:6: error: ‘AspeedGPIOController’ {aka ‘const struct AspeedGPIOController’} has no member named ‘mem_size’
  837 |     .mem_size       = GPIO_3_6V_MEM_SIZE,
      |      ^~~~~~~~
/var/tmp/patchew-tester-tmp-by4iq4ex/src/hw/gpio/aspeed_gpio.c:844:6: error: ‘AspeedGPIOController’ {aka ‘const struct AspeedGPIOController’} has no member named ‘mem_size’
  844 |     .mem_size       = GPIO_1_8V_MEM_SIZE,
      |      ^~~~~~~~
make[1]: *** [/var/tmp/patchew-tester-tmp-by4iq4ex/src/rules.mak:69: hw/gpio/aspeed_gpio.o] Error 1


The full log is available at
http://patchew.org/logs/20190814071433.22243-1-rashmica.g@gmail.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com