From nobody Thu Apr 18 19:13:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1565714712; cv=none; d=zoho.com; s=zohoarc; b=QAE0TqgdFP4kTe6gsB7zdAx9wbPyr7RNeJsvo3goDS03XCXdLWyGlYFvtXob+cepviw3jyrvm5S0AkZWzcNZF8IXZpRyCFw2C7BnwGEomafI4m6GRYoxwB0EYQHoi0TUh8KrkEfAJr4oi+LNG0fK7XPrVOxof92grJr/y5r77B0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565714712; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=AZmWj9sePiqz1ZQvVaLbCihogTCZWiSJn15KFG9glvI=; b=H7utKk0yOZjVUPCAkNzyUhup3KIgH/WHx2kdwef3Gm3wZQP9ucdA0G66fZevdJLv+Vxx/dv34yO1JqlR358yQ8vois/hJ0TRONrTxideQhbPAh0dS2xfEccWJXbJlnm0u78TGeS8YxmBRiUMjjeBxQWkZJwvOeh2WclNbxDPoQs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156571471283420.93118529930541; Tue, 13 Aug 2019 09:45:12 -0700 (PDT) Received: from localhost ([::1]:54302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxZv6-0006un-0R for importer@patchew.org; Tue, 13 Aug 2019 12:45:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59893) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxZuY-0006Ns-4H for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxZuX-00066I-7O for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:44:38 -0400 Received: from 15.mo5.mail-out.ovh.net ([178.33.107.29]:49559) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxZuX-00065L-1U for qemu-devel@nongnu.org; Tue, 13 Aug 2019 12:44:37 -0400 Received: from player168.ha.ovh.net (unknown [10.108.35.131]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id E87B524851C for ; Tue, 13 Aug 2019 18:44:34 +0200 (CEST) Received: from kaod.org (lfbn-1-2240-157.w90-76.abo.wanadoo.fr [90.76.60.157]) (Authenticated sender: clg@kaod.org) by player168.ha.ovh.net (Postfix) with ESMTPSA id 99A8E8BC0535; Tue, 13 Aug 2019 16:44:27 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: David Gibson Date: Tue, 13 Aug 2019 18:44:20 +0200 Message-Id: <20190813164420.9829-1-clg@kaod.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Ovh-Tracer-Id: 16785478764424498150 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddviedgleelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 178.33.107.29 Subject: [Qemu-devel] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Satheesh Rajendran , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If an IRQ is allocated and not configured, such as a MSI requested by a PCI driver, it can be saved in its default state and possibly later on restored using the same state. If not initially MASKED, KVM will try to find a matching priority/target tuple for the interrupt and fail to restore the VM because 0/0 is not a valid target. When allocating a IRQ number, the EAS should be set to a sane default : VALID and MASKED. Reported-by: Satheesh Rajendran Signed-off-by: C=C3=A9dric Le Goater --- David, this fixes a "virsh save/restore" issue in certain configurations of CPU topology which never showed up before :/ Peter, I was busy on a KVM/passthru issue and lacked the time to investigate all ... you decide. hw/intc/spapr_xive.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c index 3ae311d9ff7f..1f9c624df13d 100644 --- a/hw/intc/spapr_xive.c +++ b/hw/intc/spapr_xive.c @@ -534,7 +534,10 @@ bool spapr_xive_irq_claim(SpaprXive *xive, uint32_t li= sn, bool lsi) return false; } =20 - xive->eat[lisn].w |=3D cpu_to_be64(EAS_VALID); + /* + * Set default values when allocating an IRQ number + */ + xive->eat[lisn].w |=3D cpu_to_be64(EAS_VALID | EAS_MASKED); if (lsi) { xive_source_irq_set_lsi(xsrc, lisn); } --=20 2.21.0