From nobody Sun Feb 8 05:35:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565688765; cv=none; d=zoho.com; s=zohoarc; b=WJS4XYsllnWgTGKU3OYxjAAntOGmw8CWfpUtNgOGZWNgJH9tNnqNMod6zpGksxRw+ouosNgWl9Lj9wgYqJJYeOweRis+MGtwS4EzuvgGt9qlbx80nYecmmAP9v/LviH4jPs1utbYhyK8EwZkf7wT6WSm6NOc3a+yavPIo5e6tyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565688765; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RebD94j2T3G1PTx83p+5a/fbBPDwU+iM+J6XChqi6e0=; b=eKEoIedtgg58bEHdYVjejk70lVWph9NUhNvrHvuNBbRoRTCkwtsDS9RT0GUzzcP0WY+t3tEdbervP3sBrPRqXJfEjvqjfs7qG3Z7qe/NcipfC3VxRctoIhBsyb1rjbVbBVjbq9fF24eM22syDRNZDYv4BKmWfagx3zQ3dbQ8UWw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156568876518021.793879553586294; Tue, 13 Aug 2019 02:32:45 -0700 (PDT) Received: from localhost ([::1]:50572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxTAa-0008UE-2N for importer@patchew.org; Tue, 13 Aug 2019 05:32:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53513) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxT9O-0006kJ-59 for qemu-devel@nongnu.org; Tue, 13 Aug 2019 05:31:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxT9M-0005Ha-3N for qemu-devel@nongnu.org; Tue, 13 Aug 2019 05:31:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44152) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxT9I-0005Di-Ln; Tue, 13 Aug 2019 05:31:24 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC420316D76D; Tue, 13 Aug 2019 09:31:23 +0000 (UTC) Received: from thuth.com (ovpn-116-154.ams2.redhat.com [10.36.116.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B3BB2AF4D; Tue, 13 Aug 2019 09:31:10 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Date: Tue, 13 Aug 2019 11:30:44 +0200 Message-Id: <20190813093047.27948-4-thuth@redhat.com> In-Reply-To: <20190813093047.27948-1-thuth@redhat.com> References: <20190813093047.27948-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 13 Aug 2019 09:31:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Thomas Huth , qemu-block@nongnu.org, Amit Shah , John Snow , Jason Wang , "Dr. David Alan Gilbert" , Markus Armbruster , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" No test is using hmp() anymore, and since this function uses the disliked global_qtest variable, we should also make sure that nobody adds new code with this function again. qtest_hmp() should be used instead. Signed-off-by: Thomas Huth Reviewed-by: Eric Blake --- tests/libqtest.c | 11 ----------- tests/libqtest.h | 10 ---------- 2 files changed, 21 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3c5c3f49d8..3e9245d4c9 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1130,17 +1130,6 @@ void qmp_assert_success(const char *fmt, ...) qobject_unref(response); } =20 -char *hmp(const char *fmt, ...) -{ - va_list ap; - char *ret; - - va_start(ap, fmt); - ret =3D qtest_vhmp(global_qtest, fmt, ap); - va_end(ap); - return ret; -} - bool qtest_big_endian(QTestState *s) { return s->big_endian; diff --git a/tests/libqtest.h b/tests/libqtest.h index cadf1d4a03..0009b65791 100644 --- a/tests/libqtest.h +++ b/tests/libqtest.h @@ -687,16 +687,6 @@ static inline void qmp_eventwait(const char *event) return qtest_qmp_eventwait(global_qtest, event); } =20 -/** - * hmp: - * @fmt...: HMP command to send to QEMU, formats arguments like sprintf(). - * - * Send HMP command to QEMU via QMP's human-monitor-command. - * - * Returns: the command's output. The caller should g_free() it. - */ -char *hmp(const char *fmt, ...) GCC_FMT_ATTR(1, 2); - /** * get_irq: * @num: Interrupt to observe. --=20 2.18.1