From nobody Mon Feb 9 04:44:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1565633592; cv=none; d=zoho.com; s=zohoarc; b=TJox/zOjG453st6IdV+pg+47FwlO4rEIFCOgVHv5idTFgFA+GzqjOg+5090bD7WmhcOjCMSTtpQWvcQ91rASJkVwdlK59C8T7BJHbB5siXeX6aMiRZPqXeIYnJ6vFBCYVI5nJ1ItvKI+aNlVqYaBOz7OHol5LyL48oQl7H+MgQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565633592; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+ipsTgBA1+d4Fv3k+gfmCMivqEeEet4M7S87hXTYjwU=; b=WGffspIOYjwfabMgoauKLnqgVIAr5CELq/kQEf9P7VABU4rH5NrHbO2kjfJhvZJVPOgJOH6PtisLpKlPwGwMUhXjAdgjR6isdqBn44w8maPjCnxzyAiXHp7dCKh5/aBfkUYGee2xHGWw5yRblNb5bhz51SidHqBvCvaICkWQvQ0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565633592574521.6228553284873; Mon, 12 Aug 2019 11:13:12 -0700 (PDT) Received: from localhost ([::1]:47604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxEoh-00011J-Oc for importer@patchew.org; Mon, 12 Aug 2019 14:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40986) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxEnT-0007sG-6C for qemu-devel@nongnu.org; Mon, 12 Aug 2019 14:11:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxEnS-0004e7-AI for qemu-devel@nongnu.org; Mon, 12 Aug 2019 14:11:55 -0400 Received: from relay.sw.ru ([185.231.240.75]:50634) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxEnQ-0004cK-94; Mon, 12 Aug 2019 14:11:52 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1hxEnM-0001oT-O7; Mon, 12 Aug 2019 21:11:48 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Date: Mon, 12 Aug 2019 21:11:45 +0300 Message-Id: <20190812181146.26121-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190812181146.26121-1-vsementsov@virtuozzo.com> References: <20190812181146.26121-1-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to returned file. But is it correct behavior at all? If returned file itself has a backing file, we may report as totally unallocated and area which actually has data in bottom backing file. So, mirroring of qcow2 under raw-format is broken. Which is illustrated by following commit with a test. Let's make raw-format behave more correctly returning BDRV_BLOCK_DATA. Suggested-by: Max Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/raw-format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/raw-format.c b/block/raw-format.c index bffd424dd0..a273ee2387 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -275,7 +275,7 @@ static int coroutine_fn raw_co_block_status(BlockDriver= State *bs, *pnum =3D bytes; *file =3D bs->file->bs; *map =3D offset + s->offset; - return BDRV_BLOCK_RAW | BDRV_BLOCK_OFFSET_VALID; + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | BDRV_BLOCK_RECURSE; } =20 static int coroutine_fn raw_co_pwrite_zeroes(BlockDriverState *bs, --=20 2.18.0