From nobody Tue Nov 11 19:17:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1565296044; cv=none; d=zoho.com; s=zohoarc; b=mt9POiosFLxJFVA/2HCVpw17fuCDm4UpBQldI790nk3FfiUkkzRQrIgEcCc/uTWR4vDqhGSMrgvzslKNnTl0tYk9C4deYUQ/lQsoSjMon8xHRBD+/pjae1nsALugZOfe0/8oAc0jL7AsN7BKKUdoV1s3+TqYVmapdf2UUAQR3DE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565296044; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=nqzQU642U0COih1CmgjWbkQy5lirJcAcLB93HWWBZtw=; b=cOiaaMvBP5O9JlBkt5qEoBtKp8p0mutabUg+NH95hg1kWPAbVmT7s6rXu+Sh/oeqRN21V3V3y/of4jizMtNWPGyet0PS8mkRf1c3pQ8fWaf4jRyPRiSbbo+oilm48HW6l61WuOveqcdCXBBtcwcI8nr5Il812cJZs8GPk7e5GOM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565296044036707.7007700069775; Thu, 8 Aug 2019 13:27:24 -0700 (PDT) Received: from localhost ([::1]:54954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvp0K-0000QA-NN for importer@patchew.org; Thu, 08 Aug 2019 16:27:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59852) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvozS-00075E-At for qemu-devel@nongnu.org; Thu, 08 Aug 2019 16:26:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvozR-0001Iv-BP for qemu-devel@nongnu.org; Thu, 08 Aug 2019 16:26:26 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:34206) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvozR-0001IE-6H for qemu-devel@nongnu.org; Thu, 08 Aug 2019 16:26:25 -0400 Received: by mail-pf1-x443.google.com with SMTP id b13so44724458pfo.1 for ; Thu, 08 Aug 2019 13:26:25 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id v12sm2850146pjk.13.2019.08.08.13.26.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 13:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nqzQU642U0COih1CmgjWbkQy5lirJcAcLB93HWWBZtw=; b=f4x3IifJ5NF4+rRGiMDD/6mffiSedpgiTboNBBfCNIUABOKv4uEyTedewTSTZGif2G OK3b6LiDTatS2yds7cbMJsul3xUL73d5M/A221BuTd/xCE+bP/c4q3rYpsCE9/s//biT y3byX0n20EyREj7D6Qp9/o0kFA1E8M/qHp1mvSQzn+ITbz8Bxx8rSqiQV2T/7oRqUtFg evltcs0K+vibzQ3Af5AO9WH23zdK1+TCgXzmBrvQFmQt/bMha1dgxJgCJD3//k0qgjN0 /9KvgZIFtlhXRpQfSOzIU+ZqpLVBqC/X1Hs/ZqgVnoJMnWF2LVTceAtBb5jCLyZpX976 InIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nqzQU642U0COih1CmgjWbkQy5lirJcAcLB93HWWBZtw=; b=ZCjm+lht42sn1y3f5hvrBU1wkCvYvjbvCPFTA8xwnPUC9TXXzlUH6d8t8Ef/cl6m0m hqfOw1XipMbSvnIfqx6nRoOJDMozf8MURAWyvPbQn5KS+iMNy37f8WfLau7VjFD7LEUG sdeRttFRS8JSnYw7xYJRd/isUOFxDj376h+HsbFs19AtBVXC8u17O9KPPpkawuSUW1Ck gkcpNz/1X5+w9rlnUgDxqvuzB/JH41F8g5us3G/VC9ei6qqX5b/64RLMLIIl/xmCvlvd S2uRx8Q3oWC1VYcLhXJF8jyR4V/h4MlnzjCNokyTOZ8eSF8Ergw9H3csgpig2Cd2rVZz oOeQ== X-Gm-Message-State: APjAAAW7z9ZT3NSoNmRlJQR1dWJun6QK7X4cXAKnsEcccD1dUPHF9aw3 2C0FZ5TK8TyUCRJBdPIIYcTdY/jD7eY= X-Google-Smtp-Source: APXvYqxBoha2CfxdKMixIZb3G2CsT6uFGiBuX1rzJKdj/9McrVOkHD9PY8588KeXAtZLb8f1sRXRlg== X-Received: by 2002:a17:90a:3aed:: with SMTP id b100mr5814407pjc.63.1565295983855; Thu, 08 Aug 2019 13:26:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 8 Aug 2019 13:26:13 -0700 Message-Id: <20190808202616.13782-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190808202616.13782-1-richard.henderson@linaro.org> References: <20190808202616.13782-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH 4/7] target/arm: Use ror32 instead of open-coding the operation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The helper function is more documentary, and also already handles the case of rotate by zero. Signed-off-by: Richard Henderson --- target/arm/translate.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 3ddc404b3b..b40f163bab 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7979,8 +7979,7 @@ static void disas_arm_insn(DisasContext *s, unsigned = int insn) /* CPSR =3D immediate */ val =3D insn & 0xff; shift =3D ((insn >> 8) & 0xf) * 2; - if (shift) - val =3D (val >> shift) | (val << (32 - shift)); + val =3D ror32(val, shift); i =3D ((insn & (1 << 22)) !=3D 0); if (gen_set_psr_im(s, msr_mask(s, (insn >> 16) & 0xf, i), i, val)) { @@ -8243,9 +8242,7 @@ static void disas_arm_insn(DisasContext *s, unsigned = int insn) /* immediate operand */ val =3D insn & 0xff; shift =3D ((insn >> 8) & 0xf) * 2; - if (shift) { - val =3D (val >> shift) | (val << (32 - shift)); - } + val =3D ror32(val, shift); tmp2 =3D tcg_temp_new_i32(); tcg_gen_movi_i32(tmp2, val); if (logic_cc && shift) { --=20 2.17.1