From nobody Mon Feb 9 17:37:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564758597; cv=none; d=zoho.com; s=zohoarc; b=MWbwEDhC2mVm5E4fczfxSnIf4kmTpx7l/11TMBykmO+j3Krfij/pDrGvQMxTpxdI3Fo2w4BKv/HrvxN5KYxtuGY2fFKogZuUIoagkLhhF4DYLQeJfx5HyFzBempL9bo/7kRrxqc6K8CWUzmDTdUbmrbrcNlEMBkd9rK2ziDfMNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564758597; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=4v/f44smzSERAFH8pzW/nj68KZ68AhLKPEt2Lu2MTGM=; b=boEfPZBIzFY12QTBycsTzjNKmmofahNgVLtQ/LaJhY54IPWkyrlZLpTQ/SQih398Y0e3DoFN9FlIdGkwFSkSPlnvNVgVwW/4maYuHzHbxyaEWq+jTdggaRUfykzeW+BX/nkk7tS11qcNdph4M1fOcmOHb9YLuzHuZ5gXU5/DVyk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564758597234472.1363144958665; Fri, 2 Aug 2019 08:09:57 -0700 (PDT) Received: from localhost ([::1]:35596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htZBs-0004WW-9a for importer@patchew.org; Fri, 02 Aug 2019 11:09:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47191) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htZ8h-0005gh-Js for qemu-devel@nongnu.org; Fri, 02 Aug 2019 11:06:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htZ8g-0005Pn-Gi for qemu-devel@nongnu.org; Fri, 02 Aug 2019 11:06:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53136) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1htZ8g-0005PX-BU for qemu-devel@nongnu.org; Fri, 02 Aug 2019 11:06:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6CEA882EA for ; Fri, 2 Aug 2019 15:06:37 +0000 (UTC) Received: from localhost (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F41DB60605; Fri, 2 Aug 2019 15:06:31 +0000 (UTC) From: Jens Freimann To: qemu-devel@nongnu.org Date: Fri, 2 Aug 2019 17:06:00 +0200 Message-Id: <20190802150605.5880-5-jfreimann@redhat.com> In-Reply-To: <20190802150605.5880-1-jfreimann@redhat.com> References: <20190802150605.5880-1-jfreimann@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 02 Aug 2019 15:06:37 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/9] migration: allow unplug during migration for failover devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com, mst@redhat.com, aadam@redhat.com, laine@redhat.com, ailan@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds a flag to DeviceState which is set to false for all devices and makes an exception for vfio-pci devices that are also primary devices in a failover pair. Signed-off-by: Jens Freimann --- hw/core/qdev.c | 1 + include/hw/qdev-core.h | 1 + qdev-monitor.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 31e90ebaa2..f43f744133 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -973,6 +973,7 @@ static void device_initfn(Object *obj) =20 dev->instance_id_alias =3D -1; dev->realized =3D false; + dev->allow_unplug_during_migration =3D false; =20 object_property_add_bool(obj, "realized", device_get_realized, device_set_realized, NUL= L); diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 6174538b01..af4857d391 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -147,6 +147,7 @@ struct DeviceState { bool pending_deleted_event; QemuOpts *opts; int hotplugged; + bool allow_unplug_during_migration; BusState *parent_bus; QLIST_HEAD(, NamedGPIOList) gpios; QLIST_HEAD(, BusState) child_bus; diff --git a/qdev-monitor.c b/qdev-monitor.c index c69e283419..e7ab5cacb3 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -845,7 +845,7 @@ void qdev_unplug(DeviceState *dev, Error **errp) return; } =20 - if (!migration_is_idle() && !migration_in_setup(migrate_get_current())= ) { + if (!migration_is_idle() && !dev->allow_unplug_during_migration) { error_setg(errp, "device_del not allowed while migrating"); return; } --=20 2.21.0