From nobody Fri May 3 03:15:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1564676993; cv=none; d=zoho.com; s=zohoarc; b=RzAUKZlygmFTnipmxQQAuWGc74DikM/LXIhlauHvZ8Q+A/KTm1KrY4x0lhv0dbRQv1yipQN+RZPKmug58vTaVDRsRkj0toxTv5IPoyD1mAhKNUGDuSrldQGMfspOP1UbwusEy7cZHf2CdlayT226zxDP5tVjO0J1OS3RHLaaUH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564676993; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=yaFV1OG1X4baN5vnmi5E7lB71iWmlxgmHSlRIYsVlXs=; b=eEiFhiKEyED04ZfctfT9nhhpyZ4WW0bDDjQ5QlAOBK5CZmiiRYA6Hu3PdEw7Bww49XpjnYWFNcXJXRMfOpiNrqrAURpNUzeNRnMT1eJsN5cgsBAX3uBdiTrXbwj9GzTAHtc16vkBeUh7s5bdCmEHiEViQygcFPy5jNB6zfvlAvw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564676993570160.31627539494843; Thu, 1 Aug 2019 09:29:53 -0700 (PDT) Received: from localhost ([::1]:57564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htDxa-00030j-Bg for importer@patchew.org; Thu, 01 Aug 2019 12:29:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54299) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htDwh-0002I2-JA for qemu-devel@nongnu.org; Thu, 01 Aug 2019 12:28:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htDwf-0002G0-KW for qemu-devel@nongnu.org; Thu, 01 Aug 2019 12:28:51 -0400 Received: from m12-14.163.com ([220.181.12.14]:38171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htDwc-0002D9-G8 for qemu-devel@nongnu.org; Thu, 01 Aug 2019 12:28:48 -0400 Received: from localhost.localdomain (unknown [36.22.237.80]) by smtp10 (Coremail) with SMTP id DsCowADXykgzE0Nddxj4Hg--.24960S2; Fri, 02 Aug 2019 00:28:36 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=yaFV1OG1X4baN5vnmi 5E7lB71iWmlxgmHSlRIYsVlXs=; b=V8M9RAP7tFAPwroUuYibBMACQyXkH0FWP0 GnpKM4jiVNezPgW+oSS3g+wgWz3N3O9GidOxfwck5swwDl/uvqfrfGVmsOF/7rla BSfpKa9Mz1EHZpe1a26rw3JLsO3RhKEESuXK79SU8PUY7euDA6Mu9Izn9iiAawRH NG72GVTto= From: Li Qiang To: mst@redhat.com, pbonzini@redhat.com Date: Thu, 1 Aug 2019 09:28:20 -0700 Message-Id: <20190801162820.11238-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: DsCowADXykgzE0Nddxj4Hg--.24960S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7KF1DGr1Dury7AFWrZFykGrg_yoW8GF4rpr 13J3WrWrWxXryUJr1DXF4xG3W7Kw1UCFn5WF9xJr18Xr1agFsxJr43tr48try5uFykKr17 Jr1FqF4Utr18Aw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U2PfdUUUUU= X-Originating-IP: [36.22.237.80] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBZhsEbVaD20SnaQABsR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.14 Subject: [Qemu-devel] [PATCH] hw: intel_iommu: initialize 'name' in vtd_find_add_as X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The 'name' variable in vtd_find_add_as function is not initialized now, so when in gdb, we will got following output: (gdb) p name $1 =3D "vtd-00.0\000\000\000\000\000\000\000\000\060\330\377\377\377\177\00= 0\000\001\000\000\000\000\000\000\000p\330\377\377\377\177\000\000\353\362\= 372VUU\000\000p\330\377\377\377\177\000\000 \000\000\060b\000\000\220\021\= 000\000\360a\000\000\200\"\002\000\020a\000\000 \000\000\060b\000\000\200\= 332\377\377\377\177\000\000\240\330\377\377\377\177\000\000<\364\372VUU\000= \000\000\000\000\000\000\000\000\000 \000\000\060b\000" After this patch, it is more clear: (gdb) p name $1 =3D "vtd-00.0", '\000' Signed-off-by: Li Qiang --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index de86f53b4e..e379c2a512 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3286,7 +3286,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, = PCIBus *bus, int devfn) uintptr_t key =3D (uintptr_t)bus; VTDBus *vtd_bus =3D g_hash_table_lookup(s->vtd_as_by_busptr, &key); VTDAddressSpace *vtd_dev_as; - char name[128]; + char name[128] =3D {}; =20 if (!vtd_bus) { uintptr_t *new_key =3D g_malloc(sizeof(*new_key)); --=20 2.17.1