From nobody Sun Apr 28 03:34:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564646030; cv=none; d=zoho.com; s=zohoarc; b=ml+drxgnZ81ruRJHH8vHsv3f1njmxP827OQe0KNhchGLqVC+fBNhENfRuYHXAqvQeCCYwpPtDEu28YXLafU7O8pPwQVUwir8qnHmVRAawcyxklF9DtZTFjrxdhoPRoRqTY8wlHkGkELun31GTIgkRSFfAEOC9D1Sgp7sa2T/yzE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564646030; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=BAY8HBCPGxex5X1kXXs8ZB/qrABn1Lsrkp1bKdo1IdU=; b=aSe/osam/gzPxNb7pNoOY0bRES1bgrgDuOUWyk04fK0dYzgux7W/XIyoNrXZ4f6xnSZBkZVh/AbROaQBl8ZsjdeKD1SdCFNzf1KzOSCOFmStW1nUDWWuiCd89vbwWARuvgjgrjj9zUWNIIb8SwHNTGR9rP28Om0lE53DzUQIDkw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564646030922523.3751581937647; Thu, 1 Aug 2019 00:53:50 -0700 (PDT) Received: from localhost ([::1]:46232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht5u7-0005DX-2x for importer@patchew.org; Thu, 01 Aug 2019 03:53:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45745) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht5tg-0004he-Vh for qemu-devel@nongnu.org; Thu, 01 Aug 2019 03:53:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ht5tf-00061f-Og for qemu-devel@nongnu.org; Thu, 01 Aug 2019 03:53:12 -0400 Received: from mga02.intel.com ([134.134.136.20]:58176) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ht5td-0005qM-3V; Thu, 01 Aug 2019 03:53:09 -0400 Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 00:53:04 -0700 Received: from tao-optiplex-7060.sh.intel.com ([10.239.159.37]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2019 00:53:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,333,1559545200"; d="scan'208";a="172830896" From: Tao Xu To: ehabkost@redhat.com, imammedo@redhat.com, marcel.apfelbaum@gmail.com, david@gibson.dropbear.id.au Date: Thu, 1 Aug 2019 15:52:58 +0800 Message-Id: <20190801075258.19070-1-tao3.xu@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: [Qemu-devel] [RFC PATCH] numa: add auto_enable_numa to fix broken check in spapr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tao Xu , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Introduce MachineClass::auto_enable_numa for one implicit NUMA node, and enable it to fix broken check in spapr_validate_node_memory(), when spapr_populate_memory() creates a implicit node and info then use nb_numa_nodes which is 0. Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost Signed-off-by: Tao Xu Acked-by: David Gibson --- This patch has a dependency on https://patchwork.kernel.org/cover/11063235/ --- hw/core/numa.c | 9 +++++++-- hw/ppc/spapr.c | 9 +-------- include/hw/boards.h | 1 + 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 75db35ac19..756d243d3f 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -580,9 +580,14 @@ void numa_complete_configuration(MachineState *ms) * guest tries to use it with that drivers. * * Enable NUMA implicitly by adding a new NUMA node automatically. + * + * Or if MachineClass::auto_enable_numa is true and no NUMA nodes, + * assume there is just one node with whole RAM. */ - if (ms->ram_slots > 0 && ms->numa_state->num_nodes =3D=3D 0 && - mc->auto_enable_numa_with_memhp) { + if (ms->numa_state->num_nodes =3D=3D 0 && + ((ms->ram_slots > 0 && + mc->auto_enable_numa_with_memhp) || + mc->auto_enable_numa)) { NumaNodeOptions node =3D { }; parse_numa_node(ms, &node, &error_abort); } diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index f607ca567b..e50343f326 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -400,14 +400,6 @@ static int spapr_populate_memory(SpaprMachineState *sp= apr, void *fdt) hwaddr mem_start, node_size; int i, nb_nodes =3D machine->numa_state->num_nodes; NodeInfo *nodes =3D machine->numa_state->nodes; - NodeInfo ramnode; - - /* No NUMA nodes, assume there is just one node with whole RAM */ - if (!nb_nodes) { - nb_nodes =3D 1; - ramnode.node_mem =3D machine->ram_size; - nodes =3D &ramnode; - } =20 for (i =3D 0, mem_start =3D 0; i < nb_nodes; ++i) { if (!nodes[i].node_mem) { @@ -4369,6 +4361,7 @@ static void spapr_machine_class_init(ObjectClass *oc,= void *data) */ mc->numa_mem_align_shift =3D 28; mc->numa_mem_supported =3D true; + mc->auto_enable_numa =3D true; =20 smc->default_caps.caps[SPAPR_CAP_HTM] =3D SPAPR_CAP_OFF; smc->default_caps.caps[SPAPR_CAP_VSX] =3D SPAPR_CAP_ON; diff --git a/include/hw/boards.h b/include/hw/boards.h index 2eb9a0b4e0..4a350b87d2 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -220,6 +220,7 @@ struct MachineClass { bool smbus_no_migration_support; bool nvdimm_supported; bool numa_mem_supported; + bool auto_enable_numa; =20 HotplugHandler *(*get_hotplug_handler)(MachineState *machine, DeviceState *dev); --=20 2.20.1