From nobody Mon Feb 9 02:13:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1564596471; cv=none; d=zoho.com; s=zohoarc; b=lO6AX0qA5RFvm8RPPQ0QGz2fErcSN4/BBpAPqbjvar64i+wG/lYmQNnXARbGfNJsJlcCelhjaBtG1DztIFvY8yxDRu1eG2gA7zoXKucbrkuuNepSUTdMI/sS1WHLBBom6Bij94uM9a5eLFKZwPZprg/GVDbI6Z5E6XBaFppHQIw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564596471; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qwNJraZExAiEk69izkYfz3uLADtLZ4vzJetI20/CgG4=; b=M7qJ7w/uC4TL08DSqqiTpz+yryfIi7HbbpcG1yMUYuGAeRLE2UQgjSQXiwmFGBFPs/mq82hqVkcYo1fx0xE25l/C/byJBNrW6VSgOotTpWG2n6v4XYBA7VuuNdcq/2ogu3aE0+4rpBjjQCIbM/vhFAqDYwjeuxbCojtk4x2dKCY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564596471702727.197821866597; Wed, 31 Jul 2019 11:07:51 -0700 (PDT) Received: from localhost ([::1]:43486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hst0w-0005SB-Pf for importer@patchew.org; Wed, 31 Jul 2019 14:07:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42987) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hssrM-0002gk-P2 for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hssrL-00034s-LI for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:56 -0400 Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]:40125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hssrL-00034Q-GX for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:55 -0400 Received: by mail-yw1-xc44.google.com with SMTP id b143so25253974ywb.7 for ; Wed, 31 Jul 2019 10:57:55 -0700 (PDT) Received: from dionysus.attlocal.net (69-222-133-165.lightspeed.tukrga.sbcglobal.net. [69.222.133.165]) by smtp.gmail.com with ESMTPSA id 206sm16077696ywk.44.2019.07.31.10.57.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 10:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qwNJraZExAiEk69izkYfz3uLADtLZ4vzJetI20/CgG4=; b=NCTInTmr+D3ZkZ/d2QQAYUN1e1Mk4EcAVMp2lFc9ptRPvzLsSoEWwNeAcp6w6fsgF4 dsjj9Pj9Vwxdix3R7ykscerWlOnPuAHrYgavc7uMdG4aJnU7TIfp/GZe0BeLEtFT+ibH jOt3OmerpQrkJ60x9aPldR7ULviC+52mSFYP97l8O5PRGuF57HO/Ds02euwfpBfyZYof 5fdTNYzr7Dqm8urWTllYc+IKwjv8RBQjaPnXKHm7Al1kDilQT8tHpLayXXRh7ORNJp0l xp9teXOUTYlluiSPIwxkIeygFKXGz+G6yHV3ZptSeBGFM7IfHlQwCjzANMT7um/0XeFK uLjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qwNJraZExAiEk69izkYfz3uLADtLZ4vzJetI20/CgG4=; b=Gde51l7eet2bVrryYjNXT4ZCmLwRyz0HwPv5cFihEXBhHdFEZsMZ1vwBAlIb/IYA6A 6nloO3ITbnwRE7o0EYY9d/e2XKiD/V9vi4Rviy882QwbbbaElzLJGTljlxc/Jlhs93/X 0QggjtcnNST5mLdCZSJGwrndkSKD8gcJpSp5eIU1Y13ze9nFDZ5LVFwCMbIkbOdE0mNK +FeaA/YpWNTXP4HMeGSzK34U4xswIce23bhT35obmQVCiT/HhCl7Nfw0igjJPB6Mnvvl qLdnoa4FlWcsyH2QSons1BhoufpIwpjQx2Oj21NsYA9VRtrDUtOPhLoCYpeSVNeOi1Rt udug== X-Gm-Message-State: APjAAAWishxlhow6BxkrJt0iyu6/np+D9kf+tdIZuVpcyh4w0IC/vuEd jfvPEUxVxalhi9KDLSEVjI6qceSg X-Google-Smtp-Source: APXvYqyH/lanD9JlxPxXsLddvMGzPSiPuQgg4z0aP7XpW1EeOhABSU2lAYR9YQBOKdMPtoFVpmOOQQ== X-Received: by 2002:a81:a50c:: with SMTP id u12mr71761104ywg.287.1564595874902; Wed, 31 Jul 2019 10:57:54 -0700 (PDT) From: Jan Bobek To: qemu-devel@nongnu.org Date: Wed, 31 Jul 2019 13:57:01 -0400 Message-Id: <20190731175702.4916-22-jan.bobek@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731175702.4916-1-jan.bobek@gmail.com> References: <20190731175702.4916-1-jan.bobek@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c44 Subject: [Qemu-devel] [RFC PATCH v1 21/22] target/i386: reimplement (V)PMAXUB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Jan Bobek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use the gvec infrastructure to achieve the desired functionality. Signed-off-by: Jan Bobek --- target/i386/ops_sse.h | 4 ---- target/i386/ops_sse_header.h | 2 -- target/i386/translate.c | 12 +++++++++++- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 92d0544474..75ff686bb6 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -337,8 +337,6 @@ static inline int satsw(int x) } } =20 -#define FMAXUB(a, b) ((a) > (b)) ? (a) : (b) - #define FCMPGTB(a, b) ((int8_t)(a) > (int8_t)(b) ? -1 : 0) #define FCMPGTW(a, b) ((int16_t)(a) > (int16_t)(b) ? -1 : 0) #define FCMPGTL(a, b) ((int32_t)(a) > (int32_t)(b) ? -1 : 0) @@ -352,8 +350,6 @@ static inline int satsw(int x) #define FAVG(a, b) (((a) + (b) + 1) >> 1) #endif =20 -SSE_HELPER_B(helper_pmaxub, FMAXUB) - SSE_HELPER_B(helper_pcmpgtb, FCMPGTB) SSE_HELPER_W(helper_pcmpgtw, FCMPGTW) SSE_HELPER_L(helper_pcmpgtl, FCMPGTL) diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index bf38738783..9c7451d28e 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -60,8 +60,6 @@ DEF_HELPER_3(glue(pslldq, SUFFIX), void, env, Reg, Reg) #define SSE_HELPER_Q(name, F)\ DEF_HELPER_3(glue(name, SUFFIX), void, env, Reg, Reg) =20 -SSE_HELPER_B(pmaxub, FMAXUB) - SSE_HELPER_B(pcmpgtb, FCMPGTB) SSE_HELPER_W(pcmpgtw, FCMPGTW) SSE_HELPER_L(pcmpgtl, FCMPGTL) diff --git a/target/i386/translate.c b/target/i386/translate.c index 48bfb4e47b..d08d2cedce 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -2828,7 +2828,7 @@ static const SSEFunc_0_epp sse_op_table1[256][4] =3D { [0xdb] =3D { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xdc] =3D { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xdd] =3D { SSE_TOMBSTONE, SSE_TOMBSTONE }, - [0xde] =3D MMX_OP2(pmaxub), + [0xde] =3D { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xdf] =3D { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xe0] =3D MMX_OP2(pavgb), [0xe1] =3D MMX_OP2(psraw), @@ -3211,6 +3211,11 @@ static inline void gen_gvec_ld_modrm_3(CPUX86State *= env, DisasContext *s, #define gen_vpmaxs_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), = (s), (modrm), (vece), tcg_gen_gvec_smax, 0123) #define gen_vpmaxs_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), = (s), (modrm), (vece), tcg_gen_gvec_smax, 0123) =20 +#define gen_pmaxu_mm(env, s, modrm, vece) gen_gvec_ld_modrm_mm ((env), = (s), (modrm), (vece), tcg_gen_gvec_umax, 0112) +#define gen_pmaxu_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_xmm ((env), = (s), (modrm), (vece), tcg_gen_gvec_umax, 0112) +#define gen_vpmaxu_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), = (s), (modrm), (vece), tcg_gen_gvec_umax, 0123) +#define gen_vpmaxu_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), = (s), (modrm), (vece), tcg_gen_gvec_umax, 0123) + #define gen_pand_mm(env, s, modrm) gen_gvec_ld_modrm_mm ((env), (s), (m= odrm), MO_64, tcg_gen_gvec_and, 0112) #define gen_pand_xmm(env, s, modrm) gen_gvec_ld_modrm_xmm ((env), (s), (m= odrm), MO_64, tcg_gen_gvec_and, 0112) #define gen_vpand_xmm(env, s, modrm) gen_gvec_ld_modrm_vxmm((env), (s), (m= odrm), MO_64, tcg_gen_gvec_and, 0123) @@ -3436,6 +3441,11 @@ static void gen_sse(CPUX86State *env, DisasContext *= s, int b) case 0xea | M_0F | P_66 | VEX_128: gen_vpmins_xmm(env, s, modrm, MO_16= ); return; case 0xea | M_0F | P_66 | VEX_256: gen_vpmins_ymm(env, s, modrm, MO_16= ); return; =20 + case 0xde | M_0F: gen_pmaxu_mm(env, s, modrm, MO_8); = return; + case 0xde | M_0F | P_66: gen_pmaxu_xmm(env, s, modrm, MO_8);= return; + case 0xde | M_0F | P_66 | VEX_128: gen_vpmaxu_xmm(env, s, modrm, MO_8)= ; return; + case 0xde | M_0F | P_66 | VEX_256: gen_vpmaxu_ymm(env, s, modrm, MO_8)= ; return; + case 0xee | M_0F: gen_pmaxs_mm(env, s, modrm, MO_16);= return; case 0xee | M_0F | P_66: gen_pmaxs_xmm(env, s, modrm, MO_16)= ; return; case 0xee | M_0F | P_66 | VEX_128: gen_vpmaxs_xmm(env, s, modrm, MO_16= ); return; --=20 2.20.1