From nobody Tue Nov 11 17:36:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564447138; cv=none; d=zoho.com; s=zohoarc; b=Odi28/DgdtG3F9Neab1V85Gpav4d40MtBl8XTSzx4wo38wA+Du6rixFe/Gjy55Goqt5xgLaL3hQ49x/ogKPMz+hS3fVaPud6likK6+oIexDx4arxitjCm8dWbGOBkWYlU94/h40RggPNnmQsKDQvfO/eruFQKR+p05hQh6PXbuo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564447138; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=b7D8/ZbGzuPMc4IW2PFP5VXzhXKw1v33e2sGk0Ehkdo=; b=ZQtvX/EUTR8SPAxVF0NKMYXHIzmFDUaB7fDiUqpvJVl8Zs5AhIeh0DDMLdoFWSTqCsan56quGQst+eTDeP1jTxMARTxZnP3QY9Vm2JtbAd1IzBeYJUy95VULm3bbhf+2heFM1q58UBl4C4OYC4BM38urKx3pUoC/gtjGO8h8aFA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564447138449952.9776889286117; Mon, 29 Jul 2019 17:38:58 -0700 (PDT) Received: from localhost ([::1]:57208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsGAL-0001Kt-Hz for importer@patchew.org; Mon, 29 Jul 2019 20:38:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59645) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsG9f-0000VX-3M for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsG9e-0000IE-6f for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:38:15 -0400 Received: from mga04.intel.com ([192.55.52.120]:22827) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsG9d-0000FN-VU for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:38:14 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 17:38:07 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga002.jf.intel.com with ESMTP; 29 Jul 2019 17:38:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,324,1559545200"; d="scan'208";a="182952568" From: Wei Yang To: qemu-devel@nongnu.org Date: Tue, 30 Jul 2019 08:37:39 +0800 Message-Id: <20190730003740.20694-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190730003740.20694-1-richardw.yang@linux.intel.com> References: <20190730003740.20694-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: [Qemu-devel] [PATCH v2 1/2] memory-device: not necessary to use goto for the last check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imammedo@redhat.com, david@redhat.com, Wei Yang , mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We are already at the last condition check. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: David Hildenbrand --- hw/mem/memory-device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c index 5f2c408036..df3261b32a 100644 --- a/hw/mem/memory-device.c +++ b/hw/mem/memory-device.c @@ -186,7 +186,6 @@ static uint64_t memory_device_get_free_addr(MachineStat= e *ms, if (!range_contains_range(&as, &new)) { error_setg(errp, "could not find position in guest address space f= or " "memory device - memory fragmented due to alignments"); - goto out; } out: g_slist_free(list); --=20 2.17.1