From nobody Sun Feb 8 19:59:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1564296302; cv=none; d=zoho.com; s=zohoarc; b=W+dnf/UDv/uLjWsjJ6JBw18+2egcXUFXksSYtOfPjSj559CdTEVDvzhsSeHRgq9kDMrm+lRBzHyCX+RmbnDHCYzK40WCofFiWUDcpz8yzZJLLuZlkf1f0G5IwHflXfztRRJrWCIZeXU6aO2wOd4dEntHyfrFhQ6aq2Ip/FYkMFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564296302; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YXPCCbeIBibkyE/x11gE/xZdtnhwPTPBS1QYy6IQQx0=; b=VjW5xP6ZCO9SJGA4v2OqiARBBfC4BKZlmJDO1Xmt3W1ReAYZ4U1pqcrUXB5VbBMV3HWAjLPOd5MG+UX+sw2JtT1CUuXZKNCHlri/XUZbNqrOEXccQQ79CTCSItiyUxN/bc6TRLfnxdSQ9aSepvP+nbblTlZ52oAaetnb3M3VpL4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564296301603873.1727540849517; Sat, 27 Jul 2019 23:45:01 -0700 (PDT) Received: from localhost ([::1]:43778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrcvL-0005DF-Eb for importer@patchew.org; Sun, 28 Jul 2019 02:44:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42383) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrcub-0003xJ-UC for qemu-devel@nongnu.org; Sun, 28 Jul 2019 02:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrcua-0000x6-Mn for qemu-devel@nongnu.org; Sun, 28 Jul 2019 02:44:05 -0400 Received: from ozlabs.org ([203.11.71.1]:33861) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hrcuZ-0000wE-Lf; Sun, 28 Jul 2019 02:44:04 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45xCvz2Wqpz9s7T; Sun, 28 Jul 2019 16:43:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1564296239; bh=c1s9iOXvizLw8tE6vsGL8bG1Z4MGes82/Q3OpOj7wQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9JoTdamFsQxY8LJJ0l3Cf8/YcDMQKCMXLPg+AruQ70kkDmgQsBn1hRjIJTcHys7O r107SjJGsECd8vDR3DlZTKR3s6stRZ5LNnHOKGZ1j8iP2wErSOsqtj0DwPOMUurNcM 7uFI9nwcXQfZMqAmuGCpauuHzCyxIYj5caXpc3pI= From: David Gibson To: peter.maydell@linaro.org Date: Sun, 28 Jul 2019 16:43:54 +1000 Message-Id: <20190728064355.2605-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190728064355.2605-1-david@gibson.dropbear.id.au> References: <20190728064355.2605-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 1/2] spapr/irq: Inform the user when falling back to emulated IC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, Satheesh Rajendran , clg@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Greg Kurz Just to give an indication to the user that the error condition is handled and how. Reported-by: Satheesh Rajendran Signed-off-by: Greg Kurz Message-Id: <156398743479.546975.14566809803480887488.stgit@bahia.lan> Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index ff3df0bbd8..d07aed8ca9 100644 --- a/hw/ppc/spapr_irq.c +++ b/hw/ppc/spapr_irq.c @@ -86,6 +86,7 @@ static void spapr_irq_init_kvm(SpaprMachineState *spapr, * emulated mode */ error_prepend(&local_err, "kernel_irqchip allowed but unavailable:= "); + error_append_hint(&local_err, "Falling back to kernel-irqchip=3Dof= f\n"); warn_report_err(local_err); } } --=20 2.21.0 From nobody Sun Feb 8 19:59:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1564296302; cv=none; d=zoho.com; s=zohoarc; b=kk/STsKBA4USc9G5t1C12keATIkfP7eFVo4RH/dpTJAPqCmz5oK4HmvwcSWg2lkn/RPkNKKSMtxDURovoVbXsW2KYSWMfXpq4buneqa0CbR0zrTY9JyU3WJM9EmkwXgCcKVKDhU4FL8J8/qIWKl8ERSO736T+fT1lOA7JRI8zbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564296302; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=/KW6kfhhKFm8ziKh8fCgqB9j7IJEM/gv0iRYPQM+GBs=; b=AvVzu3Yif+hk8DxjJsls6kQfcOI/tLrf0Jx7XWZiGMKTg4gLIm4+V7890B+OoyEe8EEHz0gPZdpemkP+TMuopTwcK5p3vi7RU6S9L3qfh6yde1pFI7FId8B6bhMx+oSdm+xWuYJMjszsshpBA7NSXozZlEeoGVnU0N3QG5+82iE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564296301015185.53365690651867; Sat, 27 Jul 2019 23:45:01 -0700 (PDT) Received: from localhost ([::1]:43782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrcvP-0005PL-07 for importer@patchew.org; Sun, 28 Jul 2019 02:44:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42382) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrcub-0003xI-Ti for qemu-devel@nongnu.org; Sun, 28 Jul 2019 02:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrcua-0000xB-Ms for qemu-devel@nongnu.org; Sun, 28 Jul 2019 02:44:05 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:52927 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hrcuZ-0000wC-P5; Sun, 28 Jul 2019 02:44:04 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45xCvz3XQ4z9sBZ; Sun, 28 Jul 2019 16:43:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1564296239; bh=atB4xTwVLsInpndsct/mtvdqulF48I7MHFoHS8zHoZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gaQA3oOP9eBJOH4oPNF6P9V85ta7Ex4P/QyJxuufYRoBQ8nQphcUyUNsfNwNj9drZ MwMpA2CAIcHTncVaYbHq+cjWC8ptHJrIsRHLkXRL4S/fHkiswqO7kQCr/6xVstbR0v xEkz3Vw/iGMQJHkzuC8ZAESRGow9we2yuHmxRJuc= From: David Gibson To: peter.maydell@linaro.org Date: Sun, 28 Jul 2019 16:43:55 +1000 Message-Id: <20190728064355.2605-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190728064355.2605-1-david@gibson.dropbear.id.au> References: <20190728064355.2605-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 2/2] xics/kvm: Fix fallback to emulated XICS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Greg Kurz Commit 4812f2615288 tried to fix rollback path of xics_kvm_connect() but it isn't enough. If we fail to create the KVM device, the guest fails to boot later on with: [ 0.010817] pci 0000:00:00.0: Adding to iommu group 0 [ 0.010863] irq: unknown-1 didn't like hwirq-0x1200 to VIRQ17 mapping (r= c=3D-22) [ 0.010923] pci 0000:00:01.0: Adding to iommu group 0 [ 0.010968] irq: unknown-1 didn't like hwirq-0x1201 to VIRQ17 mapping (r= c=3D-22) [ 0.011543] EEH: No capable adapters found [ 0.011597] irq: unknown-1 didn't like hwirq-0x1000 to VIRQ17 mapping (r= c=3D-22) [ 0.011651] audit: type=3D2000 audit(1563977526.000:1): state=3Dinitiali= zed audit_enabled=3D0 res=3D1 [ 0.011703] ------------[ cut here ]------------ [ 0.011729] event-sources: Unable to allocate interrupt number for /even= t-sources/epow-events [ 0.011776] WARNING: CPU: 0 PID: 1 at arch/powerpc/platforms/pseries/eve= nt_sources.c:34 request_event_sources_irqs+0xbc/0x150 [ 0.011828] Modules linked in: [ 0.011850] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.1.17-300.fc30.pp= c64le #1 [ 0.011886] NIP: c0000000000d4fac LR: c0000000000d4fa8 CTR: c0000000018= f0000 [ 0.011923] REGS: c00000001e4c38d0 TRAP: 0700 Not tainted (5.1.17-300= .fc30.ppc64le) [ 0.011966] MSR: 8000000002029033 CR: 28000= 284 XER: 20040000 [ 0.012012] CFAR: c00000000011b42c IRQMASK: 0 [ 0.012012] GPR00: c0000000000d4fa8 c00000001e4c3b60 c0000000015fc400 00= 00000000000051 [ 0.012012] GPR04: 0000000000000001 0000000000000000 0000000000000081 77= 2d6576656e7473 [ 0.012012] GPR08: 000000001edf0000 c0000000014d4830 c0000000014d4830 6e= 6576652f20726f [ 0.012012] GPR12: 0000000000000000 c0000000018f0000 c000000000010bf0 00= 00000000000000 [ 0.012012] GPR16: 0000000000000000 0000000000000000 0000000000000000 00= 00000000000000 [ 0.012012] GPR20: 0000000000000000 0000000000000000 0000000000000000 00= 00000000000000 [ 0.012012] GPR24: 0000000000000000 0000000000000000 c000000000ebbf00 c0= 000000000d5570 [ 0.012012] GPR28: c000000000ebc008 c00000001fff8248 0000000000000000 00= 00000000000000 [ 0.012372] NIP [c0000000000d4fac] request_event_sources_irqs+0xbc/0x150 [ 0.012409] LR [c0000000000d4fa8] request_event_sources_irqs+0xb8/0x150 [ 0.012445] Call Trace: [ 0.012462] [c00000001e4c3b60] [c0000000000d4fa8] request_event_sources_= irqs+0xb8/0x150 (unreliable) [ 0.012513] [c00000001e4c3bf0] [c000000001042848] __machine_initcall_pse= ries_init_ras_IRQ+0xc8/0xf8 [ 0.012563] [c00000001e4c3c20] [c000000000010810] do_one_initcall+0x60/0= x254 [ 0.012611] [c00000001e4c3cf0] [c000000001024538] kernel_init_freeable+0= x35c/0x444 [ 0.012655] [c00000001e4c3db0] [c000000000010c14] kernel_init+0x2c/0x148 [ 0.012693] [c00000001e4c3e20] [c00000000000bdc4] ret_from_kernel_thread= +0x5c/0x78 [ 0.012736] Instruction dump: [ 0.012759] 38a00000 7c7f1b78 7f64db78 2c1f0000 2fbf0000 78630020 418000= 2c 409effa8 [ 0.012805] 7fa4eb78 7f43d378 48046421 60000000 <0fe00000> 3bde0001 2c1e= 0010 7fde07b4 [ 0.012851] ---[ end trace aa5785707323fad3 ]--- This happens because QEMU fell back on XICS emulation but didn't unregister the RTAS calls from KVM. The emulated RTAS calls are hence never called and the KVM ones return an error to the guest since the KVM device is absent. The sanity checks in xics_kvm_disconnect() are abusive since we're freeing the KVM device. Simply drop them. Fixes: 4812f2615288 "xics/kvm: Add proper rollback to xics_kvm_init()" Signed-off-by: Greg Kurz Message-Id: <156398744035.546975.7029414194633598474.stgit@bahia.lan> Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: David Gibson --- hw/intc/xics_kvm.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c index 2df1f3e92c..65c35f90f9 100644 --- a/hw/intc/xics_kvm.c +++ b/hw/intc/xics_kvm.c @@ -430,17 +430,6 @@ fail: =20 void xics_kvm_disconnect(SpaprMachineState *spapr, Error **errp) { - /* The KVM XICS device is not in use */ - if (kernel_xics_fd =3D=3D -1) { - return; - } - - if (!kvm_enabled() || !kvm_check_extension(kvm_state, KVM_CAP_IRQ_XICS= )) { - error_setg(errp, - "KVM and IRQ_XICS capability must be present for KVM XI= CS device"); - return; - } - /* * Only on P9 using the XICS-on XIVE KVM device: * --=20 2.21.0