From nobody Sun Feb 8 21:38:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564070150; cv=none; d=zoho.com; s=zohoarc; b=XZjmioLAX8z0ng3YewUD1luZeU7RWYYxHpAQI3jIhX0RhbVHbyw8dUtWCZSy72xkT2gRAJ2petaFIqqdANEZJ/NKvfzj1y86PsPUgdpMSgzkdjTUdLCfjmK8TET+g0Eq/CPuEHOsfSdQIy/RPosLF4+CSbohxFqem77BjokCdh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564070150; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=29DgOm0ZGZT3ZwJJl7EYYTYxTn/odNRmnmkMGtlD2N8=; b=hEHpG2FhK3v8inTC3zh1sCpPGUPufkS/FfJ/Cv4Y3SbOTv4w7kLRh+2DOtv6Ec/j24BnBZd7iGUd4V+uwY1SiradDrs5rPC6Gpysa5IA6f6spzqUrxBV80tJyT4c6J06W4ItGB7tVGjmRyFtGmNZy1dK1mOFbCJ6tGZu+090ObI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564070150827887.9817184338123; Thu, 25 Jul 2019 08:55:50 -0700 (PDT) Received: from localhost ([::1]:33280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg5q-0007jj-Dl for importer@patchew.org; Thu, 25 Jul 2019 11:55:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54049) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg5S-0006Z1-FB for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqg5R-000593-Ie for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqg5P-000583-Ie; Thu, 25 Jul 2019 11:55:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD01C81F10; Thu, 25 Jul 2019 15:55:18 +0000 (UTC) Received: from localhost (ovpn-117-225.ams2.redhat.com [10.36.117.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5904C5DE80; Thu, 25 Jul 2019 15:55:18 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Thu, 25 Jul 2019 17:55:10 +0200 Message-Id: <20190725155512.9827-2-mreitz@redhat.com> In-Reply-To: <20190725155512.9827-1-mreitz@redhat.com> References: <20190725155512.9827-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 25 Jul 2019 15:55:18 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed images X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Suggested-by: Vladimir Sementsov-Ogievskiy Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/vdi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vdi.c b/block/vdi.c index b9845a4cbd..40d40c34d5 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -542,7 +542,8 @@ static int coroutine_fn vdi_co_block_status(BlockDriver= State *bs, *map =3D s->header.offset_data + (uint64_t)bmap_entry * s->block_size + index_in_block; *file =3D bs->file->bs; - return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID; + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | + (s->header.image_type =3D=3D VDI_TYPE_STATIC ? BDRV_BLOCK_RECURSE = : 0); } =20 static int coroutine_fn --=20 2.21.0 From nobody Sun Feb 8 21:38:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564070174; cv=none; d=zoho.com; s=zohoarc; b=F89L6jJ+e1wFkFAXS3jFEGyyBzDs0qau7Ps0TMk5PW0sMtcDz+qkpdazEPrmjujwiGkXL66jG6z9GbI55DIQPq7Zj479K7z7lxCrylawmdT6BlMn698fnvDcvtgNBVU/cxbTgPEvXQQvtPk32SVpunALS3FDlqu1Hq8X2h2Q3C4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564070174; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=uTnZFKLdPC10eLKBAuMK5XzedJrgg9t1jLLitzhiE68=; b=NxGdDbeKWhFqFGuUm7cMZaSGFvAgVpwglnNhHobBHwtJI1lYfCG75QhvubXCuh5i4GyS8rKwKKZnZlzsda8GzBT743/gM2d4woU2iTrWNi2V9+LUmnbWa8/yXd68PfN16/WtcDUq8a7Xj1H4wehoiyJCqF58CrA4wAkZOdMIyo8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564070174104753.0806136931972; Thu, 25 Jul 2019 08:56:14 -0700 (PDT) Received: from localhost ([::1]:33298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg6H-0001Cx-1Z for importer@patchew.org; Thu, 25 Jul 2019 11:56:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54084) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg5W-0006oC-1M for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqg5V-0005Am-5e for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16441) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqg5T-00059X-73; Thu, 25 Jul 2019 11:55:23 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 882C344BD1; Thu, 25 Jul 2019 15:55:22 +0000 (UTC) Received: from localhost (ovpn-117-225.ams2.redhat.com [10.36.117.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE7265DE80; Thu, 25 Jul 2019 15:55:20 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Thu, 25 Jul 2019 17:55:11 +0200 Message-Id: <20190725155512.9827-3-mreitz@redhat.com> In-Reply-To: <20190725155512.9827-1-mreitz@redhat.com> References: <20190725155512.9827-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 25 Jul 2019 15:55:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] vmdk: Make block_status recurse for flat extents X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/vmdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index bd36ece125..fd78fd0ccf 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1692,6 +1692,9 @@ static int coroutine_fn vmdk_co_block_status(BlockDri= verState *bs, if (!extent->compressed) { ret |=3D BDRV_BLOCK_OFFSET_VALID; *map =3D cluster_offset + index_in_cluster; + if (extent->flat) { + ret |=3D BDRV_BLOCK_RECURSE; + } } *file =3D extent->file->bs; break; --=20 2.21.0 From nobody Sun Feb 8 21:38:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564070176; cv=none; d=zoho.com; s=zohoarc; b=gPAtfExDHMTMdtjSajo54TbTHCE6BF8VQ+TuVic9OXLZkYrw7haM4j9afwn8k7SQDac5NSKFgo/TVuaA8rGspSoWBS2iNDgvQcJToX4n3Xn6aUWfuJkYfMx9CNkDprgWCkTJTl57zyFFt2LI7EGHN0lzpr9ERXALyHzt7SSRIFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564070176; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fBiPv5mqdz82OEd+tFkgKXM0qIwfKJL9jKaOm3Rtgck=; b=cvSpkVTR+rGSys72XTorT5Pcjr3BDl2Ghiwvuo5LOHOi4Ys/u4YykgwH8ei7ItmfAJzZ+fIUZCbOr12SMzMEdZqGhvxoL9gPXpt5Nwbb+W0ozzuT1540PTj+9muxxNzjhMsDt0NYA5vg6P32c697BpRHKbnOVMUAvtrXaxvDZRs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15640701760191004.0026111014457; Thu, 25 Jul 2019 08:56:16 -0700 (PDT) Received: from localhost ([::1]:33296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg6G-00018Y-6L for importer@patchew.org; Thu, 25 Jul 2019 11:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54115) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqg5Y-0006zB-K1 for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqg5X-0005Be-KA for qemu-devel@nongnu.org; Thu, 25 Jul 2019 11:55:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqg5V-0005Ag-KY; Thu, 25 Jul 2019 11:55:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E775E46672; Thu, 25 Jul 2019 15:55:24 +0000 (UTC) Received: from localhost (ovpn-117-225.ams2.redhat.com [10.36.117.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 898051001B12; Thu, 25 Jul 2019 15:55:24 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Thu, 25 Jul 2019 17:55:12 +0200 Message-Id: <20190725155512.9827-4-mreitz@redhat.com> In-Reply-To: <20190725155512.9827-1-mreitz@redhat.com> References: <20190725155512.9827-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 25 Jul 2019 15:55:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" vpc is not really a passthrough driver, even when using the fixed subformat (where host and guest offsets are equal). It should handle preallocation like all other drivers do, namely by returning DATA | RECURSE instead of RAW. There is no tangible difference but the fact that bdrv_is_allocated() no longer falls through to the protocol layer. Signed-off-by: Max Reitz Reviewed-by: John Snow --- block/vpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vpc.c b/block/vpc.c index d4776ee8a5..b25aab0425 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -737,7 +737,7 @@ static int coroutine_fn vpc_co_block_status(BlockDriver= State *bs, *pnum =3D bytes; *map =3D offset; *file =3D bs->file->bs; - return BDRV_BLOCK_RAW | BDRV_BLOCK_OFFSET_VALID; + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | BDRV_BLOCK_RECU= RSE; } =20 qemu_co_mutex_lock(&s->lock); --=20 2.21.0