From nobody Mon Feb 9 15:10:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564014090; cv=none; d=zoho.com; s=zohoarc; b=YNiVQVsiuzDkuoxOT1ETksMhvLVSse2hA3A9K0o9yNXicy3XBZiqV6EfREdOnR4uPC5pxA6FGsuEVeCU+uJAFKmpJ7yRLtYoIZSubSWV5k2RZ6MFnNMcentGHT5bnWGbzrjACQFhkruht737mjKShLq9eNJQqd8NF0KVGHOKD/U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564014090; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Wdop/yML943KxfRGN/XqXgdqVzIIN6vXnF7zRXPDFCA=; b=mgPEcjUk1D5WfHD/clOUqmQKl1rbdfi3x2MNceAbOLxdlj5izyZVWlBrvvpaBd01hJ9NFZZVFrabRL79Y2v6ap0zkpWzsP145wsMm+9U+KZGHs5uV8XPGaqDU/e+1jhmw/N6Yx9zaWqEW8MZrz+ly3fi355yhFazIaceF/G5p7A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564014090032386.3099932749511; Wed, 24 Jul 2019 17:21:30 -0700 (PDT) Received: from localhost ([::1]:55046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqRVg-0007Ts-Ao for importer@patchew.org; Wed, 24 Jul 2019 20:21:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40449) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqRVD-00065k-7i for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:20:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqRVB-0001aP-Eu for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:20:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:54502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqRVB-0001aB-7Z for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:20:57 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 17:20:55 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 24 Jul 2019 17:20:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; d="scan'208";a="193634658" From: Wei Yang To: qemu-devel@nongnu.org Date: Thu, 25 Jul 2019 08:20:22 +0800 Message-Id: <20190725002023.2335-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190725002023.2335-1-richardw.yang@linux.intel.com> References: <20190725002023.2335-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 Subject: [Qemu-devel] [PATCH v2 1/2] migration: return -EINVAL directly when version_id mismatch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It is not reasonable to continue when version_id mismatch. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 66792568e2..69c8a6bb0f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -4217,7 +4217,7 @@ static int ram_load(QEMUFile *f, void *opaque, int ve= rsion_id) seq_iter++; =20 if (version_id !=3D 4) { - ret =3D -EINVAL; + return -EINVAL; } =20 if (!migrate_use_compression()) { --=20 2.17.1 From nobody Mon Feb 9 15:10:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564014091; cv=none; d=zoho.com; s=zohoarc; b=AQKyssz+Cw6SJuR5KqDQNwH58fTXFgItfJ83skpi9DMpr5BhUTr7MCuNPISXoZYk9Wo85/grG5qFrW0vIgOezvuVvzVDxH86skxEEwUEmghtgAKbvV03/+kPZdCdyeGFyn7zLF+5CZ+66EKGiLmECWlR5S7MY0e+0oNodiCPXuI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564014091; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=e0ahOD8jBWtZR71yFRuosi2G58akteTg6Tizi1B3Tj4=; b=aXuNqoYp9F6GBNxqWCzWlFvbamTP8lH/PA0tIdQvVRgBghZ7Cc+zRoVvvRsejxUREEQGxwn0aXEZEGy0ywhrIzJ7+cMeyJ7nenHXnKbWMYziMb0iklUk4da9Xr4cDDfg7l05a5tTBi3ayuabkyXlXyqWWPzMLCfEFmjWJWjpI08= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1564014091677888.9521160904167; Wed, 24 Jul 2019 17:21:31 -0700 (PDT) Received: from localhost ([::1]:55048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqRVi-0007Xz-3r for importer@patchew.org; Wed, 24 Jul 2019 20:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40447) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqRVD-00065i-5F for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqRVB-0001aX-TZ for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:20:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:54502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqRVB-0001aB-M3 for qemu-devel@nongnu.org; Wed, 24 Jul 2019 20:20:57 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 17:20:56 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 24 Jul 2019 17:20:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; d="scan'208";a="193634668" From: Wei Yang To: qemu-devel@nongnu.org Date: Thu, 25 Jul 2019 08:20:23 +0800 Message-Id: <20190725002023.2335-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190725002023.2335-1-richardw.yang@linux.intel.com> References: <20190725002023.2335-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 Subject: [Qemu-devel] [PATCH v2 2/2] migration: extract ram_load_precopy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" After cleanup, it would be clear to audience there are two cases ram_load: * precopy * postcopy And it is not necessary to check postcopy_running on each iteration for precopy. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- v2: fix a comment --- migration/ram.c | 73 +++++++++++++++++++++++++++++++------------------ 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 69c8a6bb0f..bee6a88c6d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -4201,40 +4201,26 @@ static void colo_flush_ram_cache(void) trace_colo_flush_ram_cache_end(); } =20 -static int ram_load(QEMUFile *f, void *opaque, int version_id) +/** + * ram_load_precopy: load pages in precopy case + * + * Returns 0 for success or -errno in case of error + * + * Called in precopy mode by ram_load(). + * rcu_read_lock is taken prior to this being called. + * + * @f: QEMUFile where to send the data + */ +static int ram_load_precopy(QEMUFile *f) { - int flags =3D 0, ret =3D 0, invalid_flags =3D 0; - static uint64_t seq_iter; - int len =3D 0; - /* - * If system is running in postcopy mode, page inserts to host memory = must - * be atomic - */ - bool postcopy_running =3D postcopy_is_running(); + int flags =3D 0, ret =3D 0, invalid_flags =3D 0, len =3D 0; /* ADVISE is earlier, it shows the source has the postcopy capability = on */ bool postcopy_advised =3D postcopy_is_advised(); - - seq_iter++; - - if (version_id !=3D 4) { - return -EINVAL; - } - if (!migrate_use_compression()) { invalid_flags |=3D RAM_SAVE_FLAG_COMPRESS_PAGE; } - /* This RCU critical section can be very long running. - * When RCU reclaims in the code start to become numerous, - * it will be necessary to reduce the granularity of this - * critical section. - */ - rcu_read_lock(); - - if (postcopy_running) { - ret =3D ram_load_postcopy(f); - } =20 - while (!postcopy_running && !ret && !(flags & RAM_SAVE_FLAG_EOS)) { + while (!ret && !(flags & RAM_SAVE_FLAG_EOS)) { ram_addr_t addr, total_ram_bytes; void *host =3D NULL; uint8_t ch; @@ -4391,6 +4377,39 @@ static int ram_load(QEMUFile *f, void *opaque, int v= ersion_id) } } =20 + return ret; +} + +static int ram_load(QEMUFile *f, void *opaque, int version_id) +{ + int ret =3D 0; + static uint64_t seq_iter; + /* + * If system is running in postcopy mode, page inserts to host memory = must + * be atomic + */ + bool postcopy_running =3D postcopy_is_running(); + + seq_iter++; + + if (version_id !=3D 4) { + return -EINVAL; + } + + /* + * This RCU critical section can be very long running. + * When RCU reclaims in the code start to become numerous, + * it will be necessary to reduce the granularity of this + * critical section. + */ + rcu_read_lock(); + + if (postcopy_running) { + ret =3D ram_load_postcopy(f); + } else { + ret =3D ram_load_precopy(f); + } + ret |=3D wait_for_decompress_done(); rcu_read_unlock(); trace_ram_load_complete(ret, seq_iter); --=20 2.17.1