From nobody Mon Feb 9 01:20:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563969560; cv=none; d=zoho.com; s=zohoarc; b=P4+xW3/W6jB3VxcO8K0djrd2TQBxJ5wc44jsNCwE8JfxEK6nHHmV1l0e/tXTTpxkLF6bp+x9F3a5LU+I02v/Gwn9QluslZXXLJ9L0onasu4sY+4VxkkLxtqJltsINFOt6Hh8Z7lPV/mndPdBgFXd/Ag2GKyXX71mcGiZfklxduc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563969560; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=k0d1mqYNV7B88c6QdsBBrOmvR/9ydnCCUak97p6JhV0=; b=dTzeYERIKF3hY395hScPG2KWbfWsgQOXbKg6FhMOtLO+HtowoRJs7PgiY7vTBGd1wC6REvyDbzbL6cSK6MGDKlXbh4RY9xwc/KR1yBFATdkecP2dNDVVxrykuVLQ2g4X0Gom6fLTisBo5tz0LaMdV08n+13u1aSbQ1/8boFuNlc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156396956037321.473514698523786; Wed, 24 Jul 2019 04:59:20 -0700 (PDT) Received: from localhost ([::1]:50738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqFvS-0000Cu-Sb for importer@patchew.org; Wed, 24 Jul 2019 07:59:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36625) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqFui-0005dp-Ql for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:58:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqFuh-0004ei-PB for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:58:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47564) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqFuh-0004dO-K5 for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:58:31 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC6053086272; Wed, 24 Jul 2019 11:58:30 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-166.ams2.redhat.com [10.36.117.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D281600D1; Wed, 24 Jul 2019 11:58:29 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, pbonzini@redhat.com, pavel.dovgaluk@ispras.ru Date: Wed, 24 Jul 2019 12:58:23 +0100 Message-Id: <20190724115823.4199-5-dgilbert@redhat.com> In-Reply-To: <20190724115823.4199-1-dgilbert@redhat.com> References: <20190724115823.4199-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 24 Jul 2019 11:58:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [for 4.2 PATCH v2 4/4] timer: last, remove last bits of last X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" The reset notifiers kept a 'last' counter to notice jumps; now that we've remove the notifier we don't need to keep 'last'. Signed-off-by: Dr. David Alan Gilbert --- include/qemu/timer.h | 13 ------------- util/qemu-timer.c | 22 +--------------------- 2 files changed, 1 insertion(+), 34 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 6817c78ef4..5bcab935f6 100644 --- a/include/qemu/timer.h +++ b/include/qemu/timer.h @@ -248,19 +248,6 @@ bool qemu_clock_run_timers(QEMUClockType type); */ bool qemu_clock_run_all_timers(void); =20 -/** - * qemu_clock_get_last: - * - * Returns last clock query time. - */ -uint64_t qemu_clock_get_last(QEMUClockType type); -/** - * qemu_clock_set_last: - * - * Sets last clock query time. - */ -void qemu_clock_set_last(QEMUClockType type, uint64_t last); - =20 /* * QEMUTimerList diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 2faaaf9926..b73041df4e 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -48,8 +48,6 @@ typedef struct QEMUClock { /* We rely on BQL to protect the timerlists */ QLIST_HEAD(, QEMUTimerList) timerlists; =20 - int64_t last; - QEMUClockType type; bool enabled; } QEMUClock; @@ -130,7 +128,6 @@ static void qemu_clock_init(QEMUClockType type, QEMUTim= erListNotifyCB *notify_cb =20 clock->type =3D type; clock->enabled =3D (type =3D=3D QEMU_CLOCK_VIRTUAL ? false : true); - clock->last =3D INT64_MIN; QLIST_INIT(&clock->timerlists); main_loop_tlg.tl[type] =3D timerlist_new(type, notify_cb, NULL); } @@ -628,9 +625,6 @@ int64_t timerlistgroup_deadline_ns(QEMUTimerListGroup *= tlg) =20 int64_t qemu_clock_get_ns(QEMUClockType type) { - int64_t now; - QEMUClock *clock =3D qemu_clock_ptr(type); - switch (type) { case QEMU_CLOCK_REALTIME: return get_clock(); @@ -642,26 +636,12 @@ int64_t qemu_clock_get_ns(QEMUClockType type) return cpu_get_clock(); } case QEMU_CLOCK_HOST: - now =3D REPLAY_CLOCK(REPLAY_CLOCK_HOST, get_clock_realtime()); - clock->last =3D now; - return now; + return REPLAY_CLOCK(REPLAY_CLOCK_HOST, get_clock_realtime()); case QEMU_CLOCK_VIRTUAL_RT: return REPLAY_CLOCK(REPLAY_CLOCK_VIRTUAL_RT, cpu_get_clock()); } } =20 -uint64_t qemu_clock_get_last(QEMUClockType type) -{ - QEMUClock *clock =3D qemu_clock_ptr(type); - return clock->last; -} - -void qemu_clock_set_last(QEMUClockType type, uint64_t last) -{ - QEMUClock *clock =3D qemu_clock_ptr(type); - clock->last =3D last; -} - void init_clocks(QEMUTimerListNotifyCB *notify_cb) { QEMUClockType type; --=20 2.21.0