From nobody Mon May 20 01:44:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563898171; cv=none; d=zoho.com; s=zohoarc; b=aIgCAn0d/Eeh6qxg51hXGlEhIjkD0Iz0XXGysAclRdSRfn81L1POsh6YgaacMfn4zukefybyMG/SXErXZ+qPE6ggQI+/8mMvKpZohLguYQ9t0/5Zttmhk1HyKZdSYJhI1tFjKpaqOutZRI8Br1/X80SOb0ojwybQtAVLT/XSsVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563898171; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=LDR0IXHq1b0Jayl3O4VIDnOp3Pmi1PQmNmAW0I3NlsA=; b=mZizJCMYcKf9KMjbyyAdjr22lLIg4LvLGX0Y+PRzPfZKb/GM+nyxc8qyphOGcal8ZKJMzAbW82HnlhaSYJIXLZQqMm0z/zsLn5pEkWDsq65Z+WIHypPD/xDz1ZvMoRwDuthZ2CZuhPPABoGCc8XErYckWMtxqfjsA5EwsJYU1VM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 15638981718661017.0255957154646; Tue, 23 Jul 2019 09:09:31 -0700 (PDT) Received: from localhost ([::1]:45506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpxLs-0008BR-Fc for importer@patchew.org; Tue, 23 Jul 2019 12:09:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56948) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpxLi-0007nC-P1 for qemu-devel@nongnu.org; Tue, 23 Jul 2019 12:09:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpxLh-00065c-ST for qemu-devel@nongnu.org; Tue, 23 Jul 2019 12:09:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45021) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpxLh-00065J-Nb for qemu-devel@nongnu.org; Tue, 23 Jul 2019 12:09:09 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB50630BA078; Tue, 23 Jul 2019 16:09:08 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id A572019D71; Tue, 23 Jul 2019 16:09:04 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Date: Tue, 23 Jul 2019 12:08:59 -0400 Message-Id: <20190723160859.27250-1-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 23 Jul 2019 16:09:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] pc-dimm: fix crash when invalid slot number is used X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@gibson.dropbear.id.au, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" QEMU will crash with: Segmentation fault (core dumped) when negative slot number is used, ex: qemu-system-x86_64 -m 1G,maxmem=3D20G,slots=3D256 \ -object memory-backend-ram,id=3Dmem1,size=3D1G \ -device pc-dimm,id=3Ddimm1,memdev=3Dmem1,slot=3D-2 fix it by checking that slot number is within valid range. Signed-off-by: Igor Mammedov Reviewed-by: David Gibson Reviewed-by: Li Qiang Reviewed-by: Pankaj Gupta --- hw/mem/pc-dimm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index b1239fd0d3..29c785799c 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -38,6 +38,13 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *= machine, =20 slot =3D object_property_get_int(OBJECT(dimm), PC_DIMM_SLOT_PROP, &error_abort); + if ((slot < 0 || slot >=3D machine->ram_slots) && + slot !=3D PC_DIMM_UNASSIGNED_SLOT) { + error_setg(&local_err, "invalid slot number, valid range is [0-%" + PRIu64 "]", machine->ram_slots - 1); + goto out; + } + slot =3D pc_dimm_get_free_slot(slot =3D=3D PC_DIMM_UNASSIGNED_SLOT ? N= ULL : &slot, machine->ram_slots, &local_err); if (local_err) { --=20 2.18.1