From nobody Sun May 19 02:38:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563451483; cv=none; d=zoho.com; s=zohoarc; b=ajMANP/JtN777UOsGBpVLulodx/9e9FpitLzXEnbx+X/EAUiu7uClX2EeOzBaMVAVUPD/6LBimeRo7yHTj08X0n+a+WXMRlfRk+Hfbodqq+dbIgL39Yd3sg0Wetv0n8mO55r/aVHdYTQqhqSOfJT93XnqttUQ2KZy7G3klaDbYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563451483; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=VAVK1uDuzCXH+Gjaq9+PrrQgdH+ysYXs17Z5QWH4Ne8=; b=JC5Vgsl1pGKrRRy/ulQECCS9osPo3KIPyHkAZHv6HmOFszXU5m+4RifmbGn8BALyf++k4n7q/SJYzRzzPi4gdIuTtsqPG2ycWNAEIMz1pRjH2rSlYgYcVCP6D1er9F5jIIAWFvXGr4b0T+xjXRxa7ibxMyuELUKZZUyzwRcm7/I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563451483738340.83196892745434; Thu, 18 Jul 2019 05:04:43 -0700 (PDT) Received: from localhost ([::1]:37294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho59J-0000uP-QQ for importer@patchew.org; Thu, 18 Jul 2019 08:04:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34174) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho597-0000Ud-G8 for qemu-devel@nongnu.org; Thu, 18 Jul 2019 08:04:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho596-0003NM-8w for qemu-devel@nongnu.org; Thu, 18 Jul 2019 08:04:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47218) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho596-0003Lg-3T for qemu-devel@nongnu.org; Thu, 18 Jul 2019 08:04:24 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A3443082AEF for ; Thu, 18 Jul 2019 12:04:21 +0000 (UTC) Received: from localhost (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 06DBD1001B03; Thu, 18 Jul 2019 12:04:17 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Thu, 18 Jul 2019 16:04:13 +0400 Message-Id: <20190718120413.27678-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 18 Jul 2019 12:04:21 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] build-sys: do no support modules on Windows X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Our module system does not support Windows, because it relies on resolving symbols from the main executable. If there is enough interest in supporting modules on Windows, we could generate an import library for the executable and link with it: https://stackoverflow.com/questions/15454968/dll-plugin-that-uses-functions= -defined-in-the-main-executable However, there is a small chicken egg problem, since the executable link and exports extra symbols needed by the library... Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- configure | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index eb635c3b9a..2833402844 100755 --- a/configure +++ b/configure @@ -1751,7 +1751,7 @@ disabled with --disable-FEATURE, default is enabled i= f available: guest-agent build the QEMU Guest Agent guest-agent-msi build guest agent Windows MSI installation package pie Position Independent Executables - modules modules support + modules modules support (non-Windows) debug-tcg TCG debugging (default is disabled) debug-info debugging information sparse sparse checker @@ -2006,6 +2006,11 @@ else QEMU_CFLAGS=3D"$QEMU_CFLAGS -Wno-missing-braces" fi =20 +# Our module code doesn't support Windows +if test "$modules" =3D "yes" && test "$mingw32" =3D "yes" ; then + error_exit "Modules are not available for Windows" +fi + # Static linking is not possible with modules or PIE if test "$static" =3D "yes" ; then if test "$modules" =3D "yes" ; then --=20 2.22.0.428.g6d5b264208