From nobody Sun May 19 07:16:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563441512; cv=none; d=zoho.com; s=zohoarc; b=jG9axXNtqhQFcEZnZpovOsCVUyiB0ugTCqgxqHeypoLEhj9JB2J6GQoIOtdr10fX+tDL42q5vSMySUpNHARGOgx5W9AYGzwCqacyYnph3pW3ilNiv177S8ePRfmS+5nrH+HfgJrYl8DxjDcHQBSpFACJSgcSJOyPeXI5hgE49fE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563441512; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=hZc/wOzYZcXgDbFg3+AOXpXDzPyUdg2XcJvpd2bB5gQ=; b=BY2eOeOhdBKc3VbgobPmfMAK705u1lX8CsPk2OGPs+WeyZQoEwQzQ+5sLQQeZMEvHfF/Xd0llGCxfAB0AdTpKl5qbD5YUHUc7/Y2xrvUXSu6lgNethSoPoBN7H4tgeJZK6EVrmfMz/TPChUMJdsaDEUDn+ztah4zyRsQDzjd6uE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563441512272793.5115878157546; Thu, 18 Jul 2019 02:18:32 -0700 (PDT) Received: from localhost ([::1]:35736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho2YW-0007Ey-Pc for importer@patchew.org; Thu, 18 Jul 2019 05:18:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38983) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho2Y4-0005hs-Uw for qemu-devel@nongnu.org; Thu, 18 Jul 2019 05:18:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho2Y3-00084d-U9 for qemu-devel@nongnu.org; Thu, 18 Jul 2019 05:18:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48068) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho2Y1-00082q-Vt; Thu, 18 Jul 2019 05:17:58 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9916830872DA; Thu, 18 Jul 2019 09:17:56 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 631F15D6A9; Thu, 18 Jul 2019 09:17:43 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Thu, 18 Jul 2019 11:17:40 +0200 Message-Id: <20190718091740.6834-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 18 Jul 2019 09:17:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH-for-4.1] hw/ide/piix: Mark the PIIX IDE interfaces as not user_creatable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-block@nongnu.org, "Michael S . Tsirkin" , John Snow , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The 'piix3-ide' (and 'piix3-ide-xen') devices are part of the PIIX3 chipset modelled as TYPE_PIIX3_PCI_DEVICE (respectivelly TYPE_PIIX3_XEN_DEVICE). The PIIX3 chipset can not be created in part, it has to be created and used as a whole. Similarly with the 'piix4-ide' device and the PIIX4 chipset modelled as TYPE_PIIX4_PCI_DEVICE. Disable the 'user_creatable' flag. part of TYPE_PIIX3_PCI_DEVICE (TYPE_PIIX3_XEN_DEVICE) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ide/piix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index b97e555072..c02e768668 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -253,6 +253,7 @@ static void piix3_ide_class_init(ObjectClass *klass, vo= id *data) k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_1; k->class_id =3D PCI_CLASS_STORAGE_IDE; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + dc->user_creatable =3D false; dc->hotpluggable =3D false; } =20 @@ -279,6 +280,7 @@ static void piix4_ide_class_init(ObjectClass *klass, vo= id *data) k->device_id =3D PCI_DEVICE_ID_INTEL_82371AB; k->class_id =3D PCI_CLASS_STORAGE_IDE; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + dc->user_creatable =3D false; dc->hotpluggable =3D false; } =20 --=20 2.20.1