From nobody Sat May 18 19:24:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563439177; cv=none; d=zoho.com; s=zohoarc; b=QnhB3zAT9e8/hd4YeUbc3qwK8PzCSHEHH5Ycc2QOnaNhkj2Lytmi7dR34tWF75vbaUBsiRIC8BGSQGQVyU3ZZqsr2RIftkWrTQ3JsR47uT34RVaWZ2BZ37BFb2pdNlIKMD7qV5TlrpUM17Z2Ozmdy2+C6CnjWpL7Pb9ns6h1ONE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563439177; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=lNf5kWpVCxY+U6iPDPT8bHlGVwP4tmkBmJknHldvr8w=; b=WHyEC/AVAVyNmRwwQqO6T2Dy7zgCuvaK/GEBKD4XkQrh73+kZQ8uWXmejy49CBcFrkz/FMtpPEKwuVfpR7Pt/uBXlEETzyM02kbarpYWoIUSBu3kYpptrD5fcvqJ8oWK9LKIT5w1T31woOXvqE4r9BdxZXfe/ZFfmgrBEL3uR9A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563439177848626.7853059245436; Thu, 18 Jul 2019 01:39:37 -0700 (PDT) Received: from localhost ([::1]:35516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho1wu-0003VG-CM for importer@patchew.org; Thu, 18 Jul 2019 04:39:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55368) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho1wg-0002g9-3m for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho1wf-0006gS-94 for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:39:22 -0400 Received: from mga14.intel.com ([192.55.52.115]:60716) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho1wf-0005cq-0z for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:39:21 -0400 Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 01:38:14 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga007.fm.intel.com with ESMTP; 18 Jul 2019 01:38:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="169793069" From: Wei Yang To: qemu-devel@nongnu.org Date: Thu, 18 Jul 2019 16:37:47 +0800 Message-Id: <20190718083747.5859-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.115 Subject: [Qemu-devel] [PATCH] migration/postcopy: start_postcopy could be true only when migrate_postcopy() return true X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There is only one place to set start_postcopy to true, qmp_migrate_start_postcopy(), which make sure start_postcopy could be set to true when migrate_postcopy() return true. So start_postcopy is true implies the other one. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 719d125041..27ca10122f 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3101,8 +3101,7 @@ static MigIterateState migration_iteration_run(Migrat= ionState *s) =20 if (pending_size && pending_size >=3D s->threshold_size) { /* Still a significant amount to transfer */ - if (migrate_postcopy() && !in_postcopy && - pend_pre <=3D s->threshold_size && + if (!in_postcopy && pend_pre <=3D s->threshold_size && atomic_read(&s->start_postcopy)) { if (postcopy_start(s)) { error_report("%s: postcopy failed to start", __func__); --=20 2.17.1