From nobody Sun May 19 03:02:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563413195; cv=none; d=zoho.com; s=zohoarc; b=fSL7Cwx28atZfXmRI1/6aV3aI3CxT6nriaXeuHJZ7GE5cdjtekRgrPOg9tXSrmk3JYczS4BwuHbbXtLpfc5OuRKgjyusfkX8munJVBuLC4L5gYHSjeq7JcPd6FoOP7cbKkpkLIBcuB0bRCpu5QVt2FPxieRzVPqNlHK/V31JRjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563413195; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=sAjXfKijO+jcbJCCOTfcYqP6DovDEz+WlDmTgdNvjtU=; b=h9NkrQ5IcoF5+fVvSD6rY+P+T3/oQCSThYIqdvsPQLbcqsikFJWCkRnztbRQ+Dnwo3/YV8CoZ3S5ZMW+BqHQoMP+OEG8/ZAHiSnEtjRRD6G52bcaGtKCP3mpAGjpBUJrT+BZKBsVV8QyVod2zq+UQUZQ+pGvFi/3XjxgBGrHGqA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563413195700589.4962786577399; Wed, 17 Jul 2019 18:26:35 -0700 (PDT) Received: from localhost ([::1]:33612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnvBn-0007sa-Mm for importer@patchew.org; Wed, 17 Jul 2019 21:26:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58821) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnvBd-0007Lm-Cj for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:26:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnvBc-0002j4-Df for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:26:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:8488) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnvBb-0002hG-43 for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:26:20 -0400 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 18:26:16 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2019 18:26:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="319493326" From: Wei Yang To: qemu-devel@nongnu.org Date: Thu, 18 Jul 2019 09:25:47 +0800 Message-Id: <20190718012547.16373-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.43 Subject: [Qemu-devel] [PATCH] migration: just pass RAMBlock is enough X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" RAMBlock->used_length is always passed to migration_bitmap_sync_range(), which could be retrieved from RAMBlock. Suggested-by: Paolo Bonzini Signed-off-by: Wei Yang Reviewed-by: Paolo Bonzini Reviewed-by: Peter Xu --- migration/ram.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 908517fc2b..0a6070d787 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1669,11 +1669,10 @@ static inline bool migration_bitmap_clear_dirty(RAM= State *rs, return ret; } =20 -static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb, - ram_addr_t length) +static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb) { rs->migration_dirty_pages +=3D - cpu_physical_memory_sync_dirty_bitmap(rb, 0, length, + cpu_physical_memory_sync_dirty_bitmap(rb, 0, rb->used_length, &rs->num_dirty_pages_period); } =20 @@ -1762,7 +1761,7 @@ static void migration_bitmap_sync(RAMState *rs) qemu_mutex_lock(&rs->bitmap_mutex); rcu_read_lock(); RAMBLOCK_FOREACH_NOT_IGNORED(block) { - migration_bitmap_sync_range(rs, block, block->used_length); + migration_bitmap_sync_range(rs, block); } ram_counters.remaining =3D ram_bytes_remaining(); rcu_read_unlock(); @@ -4193,7 +4192,7 @@ static void colo_flush_ram_cache(void) memory_global_dirty_log_sync(); rcu_read_lock(); RAMBLOCK_FOREACH_NOT_IGNORED(block) { - migration_bitmap_sync_range(ram_state, block, block->used_length); + migration_bitmap_sync_range(ram_state, block); } rcu_read_unlock(); =20 --=20 2.17.1