From nobody Sun May 19 07:16:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563326998; cv=none; d=zoho.com; s=zohoarc; b=FzhsYZP/cC3LxJHr8IPN5OTKUDFJWpnfvINBRCTJjB414ycIPGsdOIcxdSdTt+uo2/2ory1liT8dDRW7vHOy3linK80IL/OsA2Sh8EPRvsW/Qi/MF5He0oX+u+ZQzTfqizkyFYFBY8WHqz8bv5akJ+pRF2WUKAFtKYcBfV1y3eI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563326998; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=SE9Pb7wklvNSE9dDhkKhKuMihOBqeIgNOxn549hXEDQ=; b=NCDMWJwztX1you8Jp4MvppYvfiAgdgeGQy4E+1npCDUC6ywWVtdzlNyjDfpI9mrKh6X2iWwWvQsTYxe6e5EI37HAN+OEkKfvq33JjfHEE+/q/3QRs3Qu41L/vz7kqZ9Wmbozz0N085OCHLcty0kuvp3ALzDO3eBo4q4m5jnVKuo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563326998614871.1516274631456; Tue, 16 Jul 2019 18:29:58 -0700 (PDT) Received: from localhost ([::1]:53432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnYlS-0000Yc-5D for importer@patchew.org; Tue, 16 Jul 2019 21:29:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37974) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnYlH-0000AO-6g for qemu-devel@nongnu.org; Tue, 16 Jul 2019 21:29:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnYlG-0002fR-8K for qemu-devel@nongnu.org; Tue, 16 Jul 2019 21:29:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:54000) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnYlG-0002en-0O for qemu-devel@nongnu.org; Tue, 16 Jul 2019 21:29:38 -0400 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 18:29:36 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga006.fm.intel.com with ESMTP; 16 Jul 2019 18:29:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,272,1559545200"; d="scan'208";a="366855425" From: Wei Yang To: qemu-devel@nongnu.org Date: Wed, 17 Jul 2019 09:29:02 +0800 Message-Id: <20190717012902.23958-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: [Qemu-devel] [RESEND][PATCH] bitmap: get last word mask from nr directly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, corentincj@iksaif.net, pl@kamp.de, peterx@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The value left in nr is the number of bits for the last word, which could be calculate the last word mask directly. Remove the unnecessary size. Signed-off-by: Wei Yang --- resend with wider audience --- util/bitmap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/bitmap.c b/util/bitmap.c index cb618c65a5..5aa60b8717 100644 --- a/util/bitmap.c +++ b/util/bitmap.c @@ -160,7 +160,6 @@ int slow_bitmap_andnot(unsigned long *dst, const unsign= ed long *bitmap1, void bitmap_set(unsigned long *map, long start, long nr) { unsigned long *p =3D map + BIT_WORD(start); - const long size =3D start + nr; int bits_to_set =3D BITS_PER_LONG - (start % BITS_PER_LONG); unsigned long mask_to_set =3D BITMAP_FIRST_WORD_MASK(start); =20 @@ -174,7 +173,7 @@ void bitmap_set(unsigned long *map, long start, long nr) p++; } if (nr) { - mask_to_set &=3D BITMAP_LAST_WORD_MASK(size); + mask_to_set &=3D BITMAP_LAST_WORD_MASK(nr); *p |=3D mask_to_set; } } @@ -221,7 +220,6 @@ void bitmap_set_atomic(unsigned long *map, long start, = long nr) void bitmap_clear(unsigned long *map, long start, long nr) { unsigned long *p =3D map + BIT_WORD(start); - const long size =3D start + nr; int bits_to_clear =3D BITS_PER_LONG - (start % BITS_PER_LONG); unsigned long mask_to_clear =3D BITMAP_FIRST_WORD_MASK(start); =20 @@ -235,7 +233,7 @@ void bitmap_clear(unsigned long *map, long start, long = nr) p++; } if (nr) { - mask_to_clear &=3D BITMAP_LAST_WORD_MASK(size); + mask_to_clear &=3D BITMAP_LAST_WORD_MASK(nr); *p &=3D ~mask_to_clear; } } --=20 2.17.1