From nobody Wed Feb 11 02:39:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1563289061; cv=none; d=zoho.com; s=zohoarc; b=QF7t1p+PyZ1Xduh7EWWZ2V98MbI8Coirt3FASzBupxMq/O5ynZTUAaEJF/an9jLBEQIC9UPyh/ki3njXHak/dS4GtR/Cb83T7P7jCygSNTaOGIFO40KPBTsPNkG6dm8u27DbSufzWd9fH8o5QQpWDn8dwEluk3CsRRzduKnEaBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563289061; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=55HY6PBNcBpkKXNETRmpIpH2ryGBnbqosTzeu9PNbuw=; b=F8PRTMeu1xJI1mh9hBTjjbDqjMsg07xxnF6Z95ataWyxFGPdSl4pMjsTN+XhMjx2TqVqMcK00736GNaE6CPWPndQk6BsMs6sbhvNc5Gyrarx+e4/l6BQL21RPZkKtxgVn3ljF7rzPW7D4UZq+KDA3qFs+kfmcSblZZamVutxiSo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563289061559295.186627698258; Tue, 16 Jul 2019 07:57:41 -0700 (PDT) Received: from localhost ([::1]:49832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnOtf-000176-DW for importer@patchew.org; Tue, 16 Jul 2019 10:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50035) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnOrE-0007kL-7l for qemu-devel@nongnu.org; Tue, 16 Jul 2019 10:55:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnOrB-0001Lt-Nk for qemu-devel@nongnu.org; Tue, 16 Jul 2019 10:55:07 -0400 Received: from forwardcorp1j.mail.yandex.net ([5.45.199.163]:41894) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnOr9-0001JM-Oy for qemu-devel@nongnu.org; Tue, 16 Jul 2019 10:55:05 -0400 Received: from mxbackcorp1o.mail.yandex.net (mxbackcorp1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::301]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id 495A62E14CB; Tue, 16 Jul 2019 17:54:59 +0300 (MSK) Received: from smtpcorp1j.mail.yandex.net (smtpcorp1j.mail.yandex.net [2a02:6b8:0:1619::137]) by mxbackcorp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id rBKl0R8qAI-sxi8aH1M; Tue, 16 Jul 2019 17:54:59 +0300 Received: from dynamic-red.dhcp.yndx.net (dynamic-red.dhcp.yndx.net [2a02:6b8:0:40c:68fa:19fe:5639:24b5]) by smtpcorp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id RzIFhwRP0o-swQiWvsR; Tue, 16 Jul 2019 17:54:58 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1563288899; bh=xRh29Dw9Cfd0xEIMjZVO3dh4OdPRUBmM+9AVkE70jm0=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=MvcNGG+Z9QSUzcV1V3s3XjjSBKVCaFC9d2TOR7uRgwnTx4mLv5eO7+SADaRbUOg5l 3EwNErqrShRtuJ2bseJypibCwuh3QbYzRbz3/XpFi4F3GDknc5rBdhRfIdLbzd63PN Pd0F+/pE7j1KFTUzP+ysBMuxTEAT0Mr0lViSvlwk= Authentication-Results: mxbackcorp1o.mail.yandex.net; dkim=pass header.i=@yandex-team.ru From: Yury Kotov To: Paolo Bonzini , Richard Henderson , Thomas Huth , Laurent Vivier , Juan Quintela , "Dr. David Alan Gilbert" , Stefan Weil Date: Tue, 16 Jul 2019 17:54:21 +0300 Message-Id: <20190716145421.17645-4-yury-kotov@yandex-team.ru> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190716145421.17645-1-yury-kotov@yandex-team.ru> References: <20190716145421.17645-1-yury-kotov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.45.199.163 Subject: [Qemu-devel] [PATCH v2 3/3] tests/migration: Add a test for auto converge X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, yc-core@yandex-team.ru Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Yury Kotov --- tests/migration-test.c | 119 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 108 insertions(+), 11 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index e0407576cb..8a755dfaf2 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -250,6 +250,17 @@ static int64_t read_ram_property_int(QTestState *who, = const char *property) return result; } =20 +static int64_t read_migrate_property_int(QTestState *who, const char *prop= erty) +{ + QDict *rsp_return; + int64_t result; + + rsp_return =3D migrate_query(who); + result =3D qdict_get_try_int(rsp_return, property, 0); + qobject_unref(rsp_return); + return result; +} + static uint64_t get_migration_pass(QTestState *who) { return read_ram_property_int(who, "dirty-sync-count"); @@ -264,20 +275,22 @@ static void read_blocktime(QTestState *who) qobject_unref(rsp_return); } =20 +static bool check_migration_status(QTestState *who, const char *status) +{ + bool completed; + char *current_status; + + current_status =3D migrate_query_status(who); + completed =3D strcmp(current_status, status) =3D=3D 0; + g_assert_cmpstr(current_status, !=3D, "failed"); + g_free(current_status); + return completed; +} + static void wait_for_migration_status(QTestState *who, const char *goal) { - while (true) { - bool completed; - char *status; - - status =3D migrate_query_status(who); - completed =3D strcmp(status, goal) =3D=3D 0; - g_assert_cmpstr(status, !=3D, "failed"); - g_free(status); - if (completed) { - return; - } + while (!check_migration_status(who, goal)) { usleep(1000); } } @@ -1127,6 +1140,89 @@ static void test_migrate_fd_proto(void) test_migrate_end(from, to, true); } =20 +static void test_migrate_auto_converge(void) +{ + char *uri =3D g_strdup_printf("unix:%s/migsocket", tmpfs); + QTestState *from, *to; + int i; + int64_t remaining, downtime; + + /* + * We want the test to be fast enough, but stable. + * Throttle percentages are chosen to cover all cases (init, increment= , max) + */ + static const int64_t expected_pcts[] =3D { 0, 1, 51, 98 }; + const int64_t max_bandwidth =3D 200000000; /* ~200Mb/s */ + const int64_t downtime_limit =3D 50; /* 50ms */ + /* + * We migrate through unix-socket (> 500Mb/s). + * Thus, expected migration speed ~=3D bandwidth limit (< 500Mb/s). + * So, we can predict expected_threshold + */ + const int64_t expected_threshold =3D max_bandwidth * downtime_limit / = 1000; + + if (test_migrate_start(&from, &to, uri, false, false)) { + return; + } + + migrate_set_capability(from, "auto-converge", true); + migrate_set_parameter(from, "cpu-throttle-initial", expected_pcts[1]); + migrate_set_parameter(from, "cpu-throttle-increment", + expected_pcts[2] - expected_pcts[1]); + migrate_set_parameter(from, "max-cpu-throttle", expected_pcts[3]); + + migrate_set_parameter(from, "max-bandwidth", max_bandwidth); + migrate_set_parameter(from, "downtime-limit", downtime_limit); + + /* To check remaining size after precopy */ + migrate_set_capability(from, "pause-before-switchover", true); + + /* Wait for the first serial output from the source */ + wait_for_serial("src_serial"); + + migrate(from, uri, "{}"); + + for (i =3D 0; i < ARRAY_SIZE(expected_pcts); i++) { + int64_t pct; + pct =3D read_migrate_property_int(from, "cpu-throttle-percentage"); + g_assert_cmpint(pct, =3D=3D, expected_pcts[i]); + while (pct =3D=3D expected_pcts[i] && !got_stop) { + usleep(1000); + pct =3D read_migrate_property_int(from, "cpu-throttle-percenta= ge"); + } + /* We break out of this loop only in paused state */ + if (got_stop || i + 1 =3D=3D ARRAY_SIZE(expected_pcts)) { + /* Check unexpected throttle percentage change */ + g_assert_true(got_stop); + /* Check unexpected converge */ + g_assert_cmpint(i + 1, =3D=3D, ARRAY_SIZE(expected_pcts)); + g_assert_true(check_migration_status(from, "pre-switchover")); + } + } + + remaining =3D read_ram_property_int(from, "remaining"); + g_assert_cmpint(remaining, <, expected_threshold); + + wait_command(from, "{ 'execute': 'migrate-continue' , 'arguments':" + " { 'state': 'pre-switchover' } }"); + + qtest_qmp_eventwait(to, "RESUME"); + + wait_for_serial("dest_serial"); + wait_for_migration_complete(from); + + downtime =3D read_migrate_property_int(from, "downtime"); + /* + * Actual downtime may be greater than downtime limit, + * but the difference should be small enough (~20ms) + */ + g_assert_cmpint(downtime, <, downtime_limit + 20); + + g_free(uri); + + test_migrate_end(from, to, true); +} + int main(int argc, char **argv) { char template[] =3D "/tmp/migration-test-XXXXXX"; @@ -1182,6 +1278,7 @@ int main(int argc, char **argv) /* qtest_add_func("/migration/ignore_shared", test_ignore_shared); */ qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix); qtest_add_func("/migration/fd_proto", test_migrate_fd_proto); + qtest_add_func("/migration/auto_converge", test_migrate_auto_converge); =20 ret =3D g_test_run(); =20 --=20 2.22.0